[dpdk-stable] [PATCH] test: fix build without timer

[dpdk-stable] [PATCH] test: fix build without timer

[Timothy Redaelli]

The action for timer_secondary_spawn_wait should be enabled only when
CONFIG_RTE_LIBRTE_TIMER is enabled.

Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process")
Cc: erik.g.carrillo@intel.com
Cc: stable@dpdk.org

Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
---
 app/test/test.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/test/test.c b/app/test/test.c
index 194a92a39..cd7aaf645 100644
--- a/app/test/test.c
+++ b/app/test/test.c
@@ -67,7 +67,9 @@ do_recursive_call(void)
 			{ "test_memory_flags", no_action },
 			{ "test_file_prefix", no_action },
 			{ "test_no_huge_flag", no_action },
+#ifdef RTE_LIBRTE_TIMER
 			{ "timer_secondary_spawn_wait", test_timer_secondary },
+#endif
 	};
 
 	if (recursive_call == NULL)
-- 
2.21.0

Re: [dpdk-stable] [dpdk-dev] [PATCH] test: fix build without timer

[Bruce Richardson]

On Thu, Jul 04, 2019 at 05:36:08PM +0200, Timothy Redaelli wrote:
> The action for timer_secondary_spawn_wait should be enabled only when
> CONFIG_RTE_LIBRTE_TIMER is enabled.
> 
> Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process")
> Cc: erik.g.carrillo@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---

Is there a reason why DPDK can't always be built with the timer library? It
doesn't have any external dependencies, and having the ability to turn on
and off various libraries individually in the build makes validating the
combinations problematic.

/Bruce

Re: [dpdk-stable] [dpdk-dev] [PATCH] test: fix build without timer

[Thomas Monjalon]

04/07/2019 18:27, Bruce Richardson:
> On Thu, Jul 04, 2019 at 05:36:08PM +0200, Timothy Redaelli wrote:
> > The action for timer_secondary_spawn_wait should be enabled only when
> > CONFIG_RTE_LIBRTE_TIMER is enabled.
> > 
> > Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process")
> > Cc: erik.g.carrillo@intel.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> > ---
> 
> Is there a reason why DPDK can't always be built with the timer library? It
> doesn't have any external dependencies, and having the ability to turn on
> and off various libraries individually in the build makes validating the
> combinations problematic.

Every libraries can be disabled in the "make" build system.
It allows to build a small DPDK.
Anyway, this capability is removed in the "meson" build system.

Applied, thanks