From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29DC2A0C46 for ; Thu, 29 Jul 2021 19:38:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19337410E3; Thu, 29 Jul 2021 19:38:43 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 5BC034067A; Thu, 29 Jul 2021 19:38:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C8C775C016D; Thu, 29 Jul 2021 13:38:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 29 Jul 2021 13:38:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= D7Iqtd1o19TCMIQs1bJNKA6Ex34V6mbq65/1fQU6OiQ=; b=BGbZTE6XnbYTql54 2IKFOCARLC7zrDZs3pKdKe7GXY0+bXGsoVYlb0FrgNs3KXZ4VbFy9wKNLjLc4RaA mifwACoPmoqj8yKyVgLzPAQgeM189v64z8G05g4IswRTaObWN0tAxxfPD5qlSHpa 76bZrFL2XtWWZes1+/VQmcZiMCUyiYQbyVolTIzN1QvoSs+BJgDvY/HWoLFzvtyi BignUT8oxfmWfBYWvoMwojHyuFasUS/3+QMT7bN+D/F59sKOEN+LsIGEcVG7cDNu C1Fl57VKNd53mzsnNuTJDxLhxC86OD0FD3+TsWo48AnIWTRP7pZHnIuJQoB/6aD4 +kIFbw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=D7Iqtd1o19TCMIQs1bJNKA6Ex34V6mbq65/1fQU6O iQ=; b=tV54BfHS9KJVJg2hnDc5fcMoXhF9za/1QdnmbNwUQOTj+aS+8ll0l84Jr zft7liOTrKSbdNY7w+WW9eGIsu5xJ/SR95dHoHRfr1P1+l0+YtesO42dyQ/nwztR ZlY65BX87OLtB4tsZ+zqUGFS3J2qXrr9PTmKYF+/aNyZsmy1W1BvMi2mxn6DLJ0w uoDI2NtvUX2grAkaMTeFEslvCVO2XRbx1ereMWPbF6qBaANKmRPGPF+LyK+OGIsL stYMrYXWty17PdepntCItjYCodk5Hq/7at4qFsWmNpC4UKJbbE1RE1eaS0cv2jRm F+Oz33I8NoiCgespP5QYBwCicS8Tg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrheefgdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Jul 2021 13:38:38 -0400 (EDT) From: Thomas Monjalon To: Viacheslav Ovsiienko Cc: dev@dpdk.org, rasland@nvidia.com, matan@nvidia.com, stable@dpdk.org Date: Thu, 29 Jul 2021 19:39:22 +0200 Message-ID: <3586973.7bhWBlh76Z@thomas> In-Reply-To: <20210729122643.24865-1-viacheslavo@nvidia.com> References: <20210729122643.24865-1-viacheslavo@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix Tx queues creation type check for scheduling X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 29/07/2021 14:26, Viacheslav Ovsiienko: > + if (config->tx_pp && > + (priv->config.dv_esw_en || > + priv->obj_ops.txq_obj_new != mlx5_os_txq_obj_new)) { > + /* > + * HAVE_MLX5DV_DEVX_UAR_OFFSET is required to support > + * packet pacing and already checked above. Hence, we should > + * only make sure the SQs will be created with DevX, not with > + * Verbs. Verbs allocates the SQ UAR on its own and it can't > + * be shared with Clock Queue UAR as it required for the > + * Tx scheduling feature. > + */ > + DRV_LOG(ERR, "Verbs SQs, UAR can't be shared" > + " as required for packet pacing"); Don't split logs. > + err = ENODEV; > + goto error; > + err = ENODEV; > + goto error; I assume only the last 2 lines should be kept.