From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id F04531B297;
 Mon,  2 Oct 2017 23:46:07 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 02 Oct 2017 14:46:06 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,471,1500966000"; d="scan'208";a="906015404"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.131])
 ([10.241.225.131])
 by FMSMGA003.fm.intel.com with ESMTP; 02 Oct 2017 14:45:56 -0700
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>, skhare@vmware.com
Cc: dev@dpdk.org, deepak.k.jain@intel.com, yongwang@vmware.com,
 stable@dpdk.org, Tomasz Kulasek <tomaszx.kulasek@intel.com>
References: <20170922123906.13308-1-michalx.k.jastrzebski@intel.com>
 <20170929130402.32196-1-michalx.k.jastrzebski@intel.com>
 <ca21412e-a09b-02f3-ec0a-b206c3f2859f@intel.com>
Message-ID: <35c2fd54-ffcf-597e-c9d0-a8ca4f7ba8f1@intel.com>
Date: Mon, 2 Oct 2017 22:45:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <ca21412e-a09b-02f3-ec0a-b206c3f2859f@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [PATCH v2] net/vmxnet3: fix dereference before
 null check
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Oct 2017 21:46:08 -0000

On 10/2/2017 10:39 PM, Ferruh Yigit wrote:
> On 9/29/2017 2:04 PM, Michal Jastrzebski wrote:
>> Coverity reports check_after_deref:
>> Null-checking rq suggests that it may be null, but it
>> has already been dereferenced on all paths leading to
>> the check.
>> This patch removes NULL checking of "rq" from function
>> vmxnet3_dev_rx_queue_reset as it is already checked against NULL
>> one level up the callstack (function vmxnet3_dev_clear_queues).
>>
>> Coverity issue: 143468
>> Fixes: 5aecdc17a97d ("vmxnet3: fix stop/restart")
>> Cc: yongwang@vmware.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
>> Signed-off-by: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.