From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: stable@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Bernard Iremonger <bernard.iremonger@intel.com>, dev@dpdk.org Subject: Re: [dpdk-stable] [PATCH 08/10] app/testpmd: fix global variable multiple definitions Date: Sat, 12 Oct 2019 14:36:45 +0200 Message-ID: <3656667.7vqnHmEFed@xps> (raw) In-Reply-To: <20190905145315.19395-9-ferruh.yigit@intel.com> 05/09/2019 16:53, Ferruh Yigit: > --- a/app/test-pmd/testpmd.h > +++ b/app/test-pmd/testpmd.h > @@ -507,7 +507,8 @@ struct vxlan_encap_conf { > uint8_t eth_src[RTE_ETHER_ADDR_LEN]; > uint8_t eth_dst[RTE_ETHER_ADDR_LEN]; > }; > -struct vxlan_encap_conf vxlan_encap_conf; > + > +extern struct vxlan_encap_conf vxlan_encap_conf; > > /* NVGRE encap/decap parameters. */ > struct nvgre_encap_conf { > @@ -522,7 +523,8 @@ struct nvgre_encap_conf { > uint8_t eth_src[RTE_ETHER_ADDR_LEN]; > uint8_t eth_dst[RTE_ETHER_ADDR_LEN]; > }; > -struct nvgre_encap_conf nvgre_encap_conf; > + > +extern struct nvgre_encap_conf nvgre_encap_conf; I guess the empty line is not needed here and above. > /* L2 encap parameters. */ > struct l2_encap_conf { > @@ -532,13 +534,13 @@ struct l2_encap_conf { > uint8_t eth_src[RTE_ETHER_ADDR_LEN]; > uint8_t eth_dst[RTE_ETHER_ADDR_LEN]; > }; > -struct l2_encap_conf l2_encap_conf; > +extern struct l2_encap_conf l2_encap_conf; > > /* L2 decap parameters. */ > struct l2_decap_conf { > uint32_t select_vlan:1; > }; > -struct l2_decap_conf l2_decap_conf; > +extern struct l2_decap_conf l2_decap_conf; > > /* MPLSoGRE encap parameters. */ > struct mplsogre_encap_conf { > @@ -553,14 +555,14 @@ struct mplsogre_encap_conf { > uint8_t eth_src[RTE_ETHER_ADDR_LEN]; > uint8_t eth_dst[RTE_ETHER_ADDR_LEN]; > }; > -struct mplsogre_encap_conf mplsogre_encap_conf; > +extern struct mplsogre_encap_conf mplsogre_encap_conf; > > /* MPLSoGRE decap parameters. */ > struct mplsogre_decap_conf { > uint32_t select_ipv4:1; > uint32_t select_vlan:1; > }; > -struct mplsogre_decap_conf mplsogre_decap_conf; > +extern struct mplsogre_decap_conf mplsogre_decap_conf; > > /* MPLSoUDP encap parameters. */ > struct mplsoudp_encap_conf { > @@ -577,14 +579,14 @@ struct mplsoudp_encap_conf { > uint8_t eth_src[RTE_ETHER_ADDR_LEN]; > uint8_t eth_dst[RTE_ETHER_ADDR_LEN]; > }; > -struct mplsoudp_encap_conf mplsoudp_encap_conf; > +extern struct mplsoudp_encap_conf mplsoudp_encap_conf; > > /* MPLSoUDP decap parameters. */ > struct mplsoudp_decap_conf { > uint32_t select_ipv4:1; > uint32_t select_vlan:1; > }; > -struct mplsoudp_decap_conf mplsoudp_decap_conf; > +extern struct mplsoudp_decap_conf mplsoudp_decap_conf; > > static inline unsigned int > lcore_num(void)
next prev parent reply index Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20190905145315.19395-1-ferruh.yigit@intel.com> 2019-09-05 14:53 ` [dpdk-stable] [PATCH 01/10] bus/fslmc: " Ferruh Yigit 2019-09-10 16:36 ` Sachin Saxena 2019-09-05 14:53 ` [dpdk-stable] [PATCH 02/10] net/igb: " Ferruh Yigit 2019-09-05 14:53 ` [dpdk-stable] [PATCH 03/10] crypto/null: " Ferruh Yigit 2019-09-05 14:53 ` [dpdk-stable] [PATCH 04/10] crypto/octeontx: " Ferruh Yigit 2019-09-26 11:20 ` [dpdk-stable] [EXT] " Anoob Joseph 2019-09-26 18:03 ` Ferruh Yigit 2019-09-05 14:53 ` [dpdk-stable] [PATCH 05/10] crypto/dpaa2_sec: " Ferruh Yigit 2019-09-10 16:53 ` [dpdk-stable] [dpdk-dev] " Sachin Saxena 2019-10-24 14:53 ` [dpdk-stable] " David Marchand 2019-10-24 14:55 ` Ferruh Yigit 2019-10-24 16:56 ` David Marchand 2019-10-25 10:25 ` Ferruh Yigit 2019-09-05 14:53 ` [dpdk-stable] [PATCH 06/10] crypto/virtio: " Ferruh Yigit 2019-09-05 14:53 ` [dpdk-stable] [PATCH 07/10] compress/octeontx: " Ferruh Yigit 2019-09-05 16:00 ` [dpdk-stable] [EXT] " Ashish Gupta 2019-09-05 14:53 ` [dpdk-stable] [PATCH 08/10] app/testpmd: " Ferruh Yigit 2019-10-12 12:36 ` Thomas Monjalon [this message] 2019-09-05 14:53 ` [dpdk-stable] [PATCH 09/10] app/test-pipeline: " Ferruh Yigit 2019-09-05 15:01 ` Dumitrescu, Cristian 2019-09-05 15:19 ` Ferruh Yigit 2019-09-05 14:53 ` [dpdk-stable] [PATCH 10/10] test: " Ferruh Yigit 2019-09-05 15:45 ` Honnappa Nagarahalli
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3656667.7vqnHmEFed@xps \ --to=thomas@monjalon.net \ --cc=adrien.mazarguil@6wind.com \ --cc=bernard.iremonger@intel.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=jingjing.wu@intel.com \ --cc=stable@dpdk.org \ --cc=wenzhuo.lu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches Archives are clonable: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/ public-inbox