From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00084.outbound.protection.outlook.com [40.107.0.84]) by dpdk.org (Postfix) with ESMTP id 466BA1DBE for ; Tue, 4 Sep 2018 20:41:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pGKVD0oeyiSmXirLy3T9VOCIbDOjxoXMwI57HP1Xp1E=; b=esDP8Dg+prepkXilgBm8SYm31+6/A+lRbKHp5NbM/N4J05FikjGH6kqQzi3X+e3Nl21gp7jFoFMyM0WbPiwKRvRWpmSSzXgyXVkgeLL+QifstF2NDmDCw7NKBOLw/r8zWchxjEWpBdIEHZ7nFbvwaJx2th5vRxsZew8ItTe7vSo= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4074.eurprd05.prod.outlook.com (52.134.72.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.14; Tue, 4 Sep 2018 18:41:40 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c%2]) with mapi id 15.20.1101.016; Tue, 4 Sep 2018 18:41:40 +0000 From: Yongseok Koh To: Honnappa Nagarahalli CC: "stable@dpdk.org" , nd Thread-Topic: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined Thread-Index: AQHUQutHksvtrTRwPEy6+Zaj0UhVC6TdYOGAgAAHzUCAAENzgIAAjS9QgAI+roA= Date: Tue, 4 Sep 2018 18:41:40 +0000 Message-ID: <3669CA39-FCDC-4138-8B8F-1BD629A73197@mellanox.com> References: <1535913120-22426-1-git-send-email-honnappa.nagarahalli@arm.com> <8BD04EEF-AF53-4990-9273-A0F737EF8F4D@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4074; 6:9dLwxYE0/VQUW87aXIJWOPtfk5FI9e84zwEsb5Zpo3ypOICGLCQsjDDKhS7kU9VNTSE4cIh+izBA0xxHzmnGkkiEBHw3xvPI+/WrHieCiqdCZkiLen6T83iYL1TUWr+PwhP/dBzeMar+uu9eRBY+2h26hct+6iCKjYTCKfQ6QZSaB6LgHpPsLwdEuXpda/ERPHK5g65L2gUla1S0KMahkzZKp1MCgsthpwmER1UI4T7+MN5yw8IpyssOfUmhL/cfordFssT7nolHxNYgJVzeXGh/VcxMithNHDNjB0bg6QeVmvLq3o03acc5ZMcIA+rqt4N9aHptNA67OYM7vF3vRKvrFH+MfVJekF/EIvjd5kkK/R24kOeFZeVz85+OhgZH5q56a18kgYj+d1PvfwGeurOLoAhBtqwYoj8E1cQdkhBhxM/IJSqHaMsZcBXMpWmHj+tD5NLK+bkDD8BPXNUI3Q==; 5:f8gxnqQ2YhJHiRr639EcDpihfhPwDP/yywfUrLrX9ntDa7BJa6eAdJxVpzcDYU+WOkaSl7bxHLmfGo8WUbnU2WWqCDawLlq3iE2UxDwsf48iMLnUA3+jN4AKJU+Hn504/dBDoT3K9Mu42tGfy1VDwTu2A88X3oW6FuPezmHyQWQ=; 7:Hh55hHyl+eEve4uXVwRJ4VWvRJQ4pwBh/xyByUNU1UjNa6b7dCNJ7kOZpGBJykySxNhYgP+5MGfGywFwwiMLscAEPujsSJsGxLv8/IDIF5Xcqd9QSTlPP0+u0LS+Wf1wxbX4/AZVVXGPZikenBdVscLhjFDsRxsJz9IRezBBYmFb/bVfnOumxexdHUkDsv2gF9KtCGUfhXnJcr5FfcPO4qV9XPxnmn0HoQ6PoJfJdWJDj0i3No4X8W5jB9JFom1r x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 34467bd2-a55a-4e80-d5af-08d612960e09 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4074; x-ms-traffictypediagnostic: DB3PR0502MB4074: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699016); SRVR:DB3PR0502MB4074; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4074; x-forefront-prvs: 0785459C39 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(136003)(346002)(396003)(366004)(189003)(199004)(69234005)(13464003)(93886005)(54906003)(83716003)(11346002)(446003)(8936002)(81166006)(4326008)(186003)(102836004)(26005)(81156014)(6916009)(53546011)(6506007)(2616005)(476003)(25786009)(316002)(6246003)(14454004)(99286004)(486006)(86362001)(7736002)(305945005)(76176011)(478600001)(2906002)(5660300001)(68736007)(36756003)(256004)(6512007)(97736004)(6436002)(82746002)(2900100001)(229853002)(33656002)(5250100002)(14444005)(6486002)(106356001)(66066001)(6116002)(3846002)(105586002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4074; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 8Ob3lpXOUGMR+STbH8WdNwUbjYP4RoK5InCqUaRUDCoWhUiVUsCsPgtFrl9N3QfSCp3kzy/HJjJnWngT0xdL1Pb8Gj4HDg/zu7skY/zqTyJYKbGZefN2PKHYR2FGpQXlXx7oRRrpHjaKgavvxunrCr7UZJInNea92BuCbVCSnZ0zRzgn+svjdL3VWDFsF8cXDFD4U5+lO93huJndugOuWV3YAfmdvz1LBR34ndFOhz5ReQmGpaPY5DA0KmfXWGWDZ5K1eWbODNvkQpSjWecYCTO/Wx8dMSX9T2GVQg8ilr9//d3yUHVFS34r+medY9GOFs9ctZbVk07pGlcIneI7uso2CNh/ItIER+OW3ZPON5Y= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <0E579BC6B7D7804C97BBF787952BEEE0@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34467bd2-a55a-4e80-d5af-08d612960e09 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2018 18:41:40.8312 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4074 Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2018 18:41:42 -0000 > On Sep 3, 2018, at 1:25 AM, Honnappa Nagarahalli wrote: >=20 >=20 >=20 > -----Original Message----- > From: Yongseok Koh =20 > Sent: Sunday, September 2, 2018 7:00 PM > To: Honnappa Nagarahalli > Cc: stable@dpdk.org; nd > Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when _= _aarch64__ is defined >=20 >> On Sep 2, 2018, at 12:59 PM, Honnappa Nagarahalli wrote: >>=20 >> -----Original Message----- >> From: Yongseok Koh >> Sent: Sunday, September 2, 2018 2:30 PM >> To: Honnappa Nagarahalli >> Cc: stable@dpdk.org >> Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags=20 >> when __aarch64__ is defined >>=20 >>> On Sep 2, 2018, at 11:32 AM, Honnappa Nagarahalli wrote: >>>=20 >>> GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not=20 >>> optional for ArmV8. Hence NEON related code can be enabled when=20 >>> __aarch64__ is defined. >>>=20 >>> Bugzilla ID: 82 >>> Cc: stable@dpdk.org >>>=20 >>> Reported-by: Raslan Darawsheh >>> Reported-by: Thomas F Herbert >>> Signed-off-by: Honnappa Nagarahalli >>> Reviewed-by: Phil Yang >>> Reviewed-by: Gavin Hu >>> Acked-by: Gavin Hu >>> Acked-by: Jerin Jacob >>> --- >>> V2: >>> * Corrected the order of contribution tags >>> * Added Jerin's Ack >>=20 >> I didn't check out the details yet but a quick question. >> Do you want me to include this patch in 17.11.4? >>=20 >> Yes, please include. >=20 > I didn't realized that this is fixing the meson build. > 17.11 doesn't have that. >=20 > Thanks, > Yongseok >=20 > It has a fix for the make build as well. Does it mean, it needs to be a d= ifferent patch? I could've applied the second hunk but actually it was one minute before th= e release of 17.11.4. I'm sorry that I had to skip this patch for the release= . But, I've applied it (the second hunk only) to the stable/17.11 tree today. Please check it out and let me know if there's an issue. This will be incl= uded in 17.11.5 (ETA is Nov). FYI, the most favorable way is that you send patches with '[PATCH 17.11]' p= refix based on the latest stable/17.11 so that it is never forgotten. Thanks, Yongseok >>> config/arm/meson.build | 3 ++- >>> mk/rte.cpuflags.mk | 2 +- >>> 2 files changed, 3 insertions(+), 2 deletions(-) >>>=20 >>> diff --git a/config/arm/meson.build b/config/arm/meson.build index >>> 40dbc87..94cca49 100644 >>> --- a/config/arm/meson.build >>> +++ b/config/arm/meson.build >>> @@ -157,7 +157,8 @@ else >>> endif >>> message(machine_args) >>>=20 >>> -if cc.get_define('__ARM_NEON', args: machine_args) !=3D '' >>> +if (cc.get_define('__ARM_NEON', args: machine_args) !=3D '' or >>> + cc.get_define('__aarch64__', args: machine_args) !=3D '') >>> dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1) >>> compile_time_cpuflags +=3D ['RTE_CPUFLAG_NEON'] endif diff --git=20 >>> a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 6071313..43ed841 >>> 100644 >>> --- a/mk/rte.cpuflags.mk >>> +++ b/mk/rte.cpuflags.mk >>> @@ -89,7 +89,7 @@ CPUFLAGS +=3D VSX >>> endif >>>=20 >>> # ARM flags >>> -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),) >>> +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),) >>> CPUFLAGS +=3D NEON >>> endif >>>=20 >>> -- >>> 2.7.4