From: Thomas Monjalon <thomas@monjalon.net>
To: Quentin Armitage <quentin@armitage.org.uk>
Cc: dev@dpdk.org, Reshma Pattan <reshma.pattan@intel.com>,
Ray Kinsella <mdr@ashroe.eu>,
dev@dpdk.org, stable@dpdk.org,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2] libpcapng: fix timestamp wrapping in output files
Date: Wed, 01 Jun 2022 16:38:01 +0200 [thread overview]
Message-ID: <36758990.XM6RcZxFsP@thomas> (raw)
In-Reply-To: <20220517081521.636cb5a0@hermes.local>
17/05/2022 17:15, Stephen Hemminger:
> On Tue, 17 May 2022 11:01:15 +0100
> Quentin Armitage <quentin@armitage.org.uk> wrote:
>
> > In pcap_tsc_to_ns(), delta * NSEC_PER_SEC will overflow approx 8
> > seconds after pcap_init is called when using a TSC with a frequency
> > of 2.5GHz.
> >
> > To avoid the overflow, update the saved time and TSC value once
> > delta >= tsc_hz.
> >
> > Fixes: 8d23ce8f5ee ("pcapng: add new library for writing pcapng files")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>
>
> Thanks for fixing this.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
next prev parent reply other threads:[~2022-06-01 14:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 16:12 [PATCH] " Quentin Armitage
2022-05-11 16:08 ` Stephen Hemminger
2022-05-11 16:46 ` Stephen Hemminger
2022-05-14 17:14 ` Quentin Armitage
2022-05-16 13:26 ` Stephen Hemminger
2022-05-17 10:01 ` [PATCH v2] " Quentin Armitage
2022-05-17 15:15 ` Stephen Hemminger
2022-06-01 14:38 ` Thomas Monjalon [this message]
2022-05-17 21:04 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36758990.XM6RcZxFsP@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=quentin@armitage.org.uk \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).