From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 309B4A04C5 for ; Fri, 15 Nov 2019 15:04:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 220082B86; Fri, 15 Nov 2019 15:04:51 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 49E992B86 for ; Fri, 15 Nov 2019 15:04:49 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id w9so11145992wrr.0 for ; Fri, 15 Nov 2019 06:04:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=DXK2bhTND4dnvUHeudpeInoEG5UoZ1REkSA2rLDF5VY=; b=TSpLaeWZ1Y1we6ZZPy7d0zJC49sXUL/Ee8c3VICyZ+os5p33x3P14mu71MFiwwglGP GEiTfjf72AxbKHAkRmztwiTHYhO4Adx4+lIO/3LP7quenwEvx31hjWvY7BZPw+7MMKw6 DY9AWtp/UpRLMIbI5mtCSTIle1NFTn4ZAR2kkR8YhIKYMe5o/K9HDXS03bwgZkf8cw5E 4wGufrdNePq268EuGoK6A8UdLgdrCvt9S2hDNR7NmgutYmpGH7wPX5uCm1oRJqwQGFfT +lk1OdcEpd2Zj5iupyqwF/LLLcBX0qU++6L8O/K55IXAhbfLndo8Ax6jP9xLX4tLPmhW Sp0Q== X-Gm-Message-State: APjAAAV1cKda8fO+zLQhSyeCXbXwbEBshSwR+RPElzX8znlQLZvXs68Q ZmYcC/fFhrlKGCvrG2a5h7c= X-Google-Smtp-Source: APXvYqzhkBWEUgnu6838bBprMUq69w4I5jQtQKV4yN56BEjtwgkh2RvMAh2YZtk74BLqW4hxtSFBdw== X-Received: by 2002:a5d:6181:: with SMTP id j1mr14717532wru.251.1573826688864; Fri, 15 Nov 2019 06:04:48 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id j22sm12994217wrd.41.2019.11.15.06.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2019 06:04:48 -0800 (PST) Message-ID: <36d63ecbf14bcd2b32f5ab116a9c97ee4e56a62c.camel@debian.org> From: Luca Boccassi To: Tiwei Bie , Maxime Coquelin Cc: stable@dpdk.org, Zhike Wang Date: Fri, 15 Nov 2019 14:04:47 +0000 In-Reply-To: <20191115122408.GA1432@___> References: <20191115103615.17858-1-maxime.coquelin@redhat.com> <20191115122408.GA1432@___> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [16.11 LTS PATCH v2] vhost: fix vring requests validation broken if no FD X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, 2019-11-15 at 20:24 +0800, Tiwei Bie wrote: > On Fri, Nov 15, 2019 at 11:36:15AM +0100, Maxime Coquelin wrote: > > From: Zhike Wang < > > wangzk320@163.com > > > > >=20 > > When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0, > > so validate_msg_fds() will return error. In this case, > > the negotiation of vring message between vhost user front end and > > back end would fail, and as a result, vhost user link could NOT be > > up. > >=20 > > How to reproduce: > > 1.Run dpdk testpmd insides VM, which locates at host with ovs+dpdk. > > 2.Notice that inside ovs there are endless logs regarding failure > > to > > handle VHOST_USER_SET_VRING_CALL, and link of vm could NOT be up. > >=20 > > Fixes: 1bf11cfb7c7c ("vhost: fix possible denial of service by > > leaking FDs") > > Cc:=20 > > stable@dpdk.org > >=20 > >=20 > > Signed-off-by: Zhike Wang < > > wangzk320@163.com > > > > > Reviewed-by: Maxime Coquelin < > > maxime.coquelin@redhat.com > > > > > --- > > lib/librte_vhost/vhost_user.c | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) >=20 > Reviewed-by: Tiwei Bie < > tiwei.bie@intel.com > > >=20 > Thanks! > Tiwei Thanks, applied --=20 Kind regards, Luca Boccassi