From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E5D2A04B5 for ; Fri, 30 Oct 2020 11:46:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF89BC814; Fri, 30 Oct 2020 11:46:45 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id CE067C7F0; Fri, 30 Oct 2020 11:46:41 +0100 (CET) IronPort-SDR: ODJHlxYMj5T6XgZeaDif19X/7sDaqwiQC7Qh9KlCD3Ne3zg+3qg2cxRzLgnGBsCZFGU2GDW1Qw dT0ziuSS6qaQ== X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="168685808" X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="168685808" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 03:46:39 -0700 IronPort-SDR: alLq79u6woDI09RirbwkqDWAFu4cn6fpy0yEuNkoryZisi0Tr/8pyRUtnT5IXiLiFBJWQ1EMf6 c7V6BD3SdNig== X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="537024109" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.23.197]) ([10.252.23.197]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 03:46:35 -0700 To: Dharmik Thakkar , Zhou Zhenghua Cc: Wenzhuo Lu , Beilei Xing , Bernard Iremonger , dev , dpdk stable , nd References: <20201027064252.9624-1-zhenghuax.zhou@intel.com> <0507A11B-4C8A-4F7D-83E7-0B9EF42121C1@arm.com> From: Ferruh Yigit Message-ID: <3707ad7a-9375-4ee7-d275-25dad725edf4@intel.com> Date: Fri, 30 Oct 2020 10:46:31 +0000 MIME-Version: 1.0 In-Reply-To: <0507A11B-4C8A-4F7D-83E7-0B9EF42121C1@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: don't allow to dynamic change nbcore X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 10/29/2020 4:43 AM, Dharmik Thakkar wrote: <...> >> On Oct 27, 2020, at 1:42 AM, Zhou Zhenghua wrote: >> >> When changing the number of forwarding cores in runtime, two issues may be >> encountered: >> >> - If the setting nbcore little than current nbcore, the forwarding >> thread will still running on the extra cores. Therefore, trying to >> stop forwarding will hang testpmd, since it will wait for the extra >> cores to stop. >> >> - If the setting nbcore greate than actual nbcore, the newly added >> cores are not allocated resources. >> >> This will face the problem of dynamic resource allocation, so it's not >> allow to changes nbcore number when forwarding is running. >> >> Fixes: 0c0db76f42ed ("app/testpmd: separate forward config setup from display") >> Cc: bernard.iremonger@intel.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Zhou Zhenghua > > Hi Zhou, > > Although, I see that a few of the configuration options are checking for ’test_done’, I am wondering if it is truly required. > Since, as per the documentation guidelines: > 'Configuration changes only become active when forwarding is started/restarted.’ > Yes documentation has it and I think that is what happens in below bullet 2 (increase core count). But it is easy to reproduce the hung mentioned in the first bullet, I am for having this fix. And this won't contradict with the above document, the config options you can set will be taken account when forwarding is started/restarted, but this one won't be set because of added check, hence: Acked-by: Ferruh Yigit @Zhou, do you have any objection to remove bullet 2 while merging?