From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E14FE1DB3 for ; Mon, 30 Apr 2018 15:47:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9035021B18; Mon, 30 Apr 2018 09:47:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 30 Apr 2018 09:47:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=EZ+C5a22Gv0Q2vz3hy/l0j9tVN fDCz15S/4BSw1F32Q=; b=Yn0lA14KtkmdfhsMx07FjR2e58fSTZzWx+wK8vcVzu K/w1Lq593g3e246XYhV6yxYa5L9cjbzj/RITXg5+OcO6l3eTwRjKk1y6dnVtm05+ 0363Xp3+rqBYzDV3uAfXbUrHVFz0176myuYKvnqm1pAiJsiag+hzjEU5nmDK4RA+ 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=EZ+C5a 22Gv0Q2vz3hy/l0j9tVNfDCz15S/4BSw1F32Q=; b=ctjlxt63B1T+iofk58jxnl FhjPJ4EF8U6gQBhrMKoiWsQqdJEzxulWCiJXXHjsSDlcPYMSpxkbRWdgFonLRAcs Nkbwky7lr3JSHGzshJkFUEJZZYKOywnaq1hXSCMJpnpW0aOB61cx3rqN3tzQX9xU opuP78uEUufDKK+n7GeI/b1eUitTrqvUhhDJMaWX/RASXbSA7KayADyh+Z8Hx3Ol Ibr3DOhfozFnnTsBUiKq1OjbJ8pyj5ZnTsUlktFriPHqVPdXhltB97ZpkUco5YDG fg2XaoElLIdSwqbr0gK8cMX1BMOEcZ17XangwsF0LPNPb1uA73vaG5i4fVxCGN7Q == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E9E4BE498D; Mon, 30 Apr 2018 09:47:52 -0400 (EDT) From: Thomas Monjalon To: Luca Boccassi Cc: stable@dpdk.org, Ophir Munk Date: Mon, 30 Apr 2018 15:47:51 +0200 Message-ID: <3736968.MDDTzanQ13@xps> In-Reply-To: <1525095746.23337.19.camel@debian.org> References: <1525091032-10700-1-git-send-email-ophirmu@mellanox.com> <1525095746.23337.19.camel@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH v1] net/mlx4: fix CRC stripping capability report X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 13:47:54 -0000 30/04/2018 15:42, Luca Boccassi: > On Mon, 2018-04-30 at 12:23 +0000, Ophir Munk wrote: > > There are two capabilities related to CRC stripping: > > 1. mlx4 HW capability to perform CRC stripping on a recieved packet. > > This capability is built in mlx4 HW. It should be returned by the API > > call mlx4_get_rx_queue_offloads(). > > 2. mlx4 driver capability to enable/disable HW CRC stripping. This > > capability is dependent on the driver version. > > Before this commit the seccond capability was falsely returned by > > the mentioned API. This commit fixes it by returning the first > > capability. > > > > Fixes: de1df14e6e6ec ("net/mlx4: support CRC strip toggling") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ophir Munk > > Has this or a version of this fix been committed to mainline? I think it is a duplicate. A new patch has been sent to dpdk-dev + dpdk-stable.