patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ilya Maximets <i.maximets@samsung.com>
Cc: stable@dpdk.org, dev@dpdk.org,
	Pavan Nikhilesh <pbhagavatula@marvell.com>,
	honnappa.nagarahalli@arm.com
Subject: Re: [dpdk-stable] [PATCH] eal: fix build of external apps with clang on armv8
Date: Mon, 14 Jan 2019 19:49:35 +0100	[thread overview]
Message-ID: <3867865.yVi6bGp0KD@xps> (raw)
In-Reply-To: <2566607.iMXo4xvV1S@xps>

14/01/2019 17:27, Thomas Monjalon:
> 14/01/2019 17:14, Ilya Maximets:
> > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined.
> > But 'rte_atomic.h' is a generic header that included to the
> > external apps like OVS while building with DPDK. As a result,
> > clang build of OVS fails on ARMv8 if DPDK built using gcc:
> > 
> >     include/generic/rte_atomic.h:215:9: error:
> >             implicit declaration of function '__atomic_exchange_2'
> >             is invalid in C99
> >     include/generic/rte_atomic.h:494:9: error:
> >             implicit declaration of function '__atomic_exchange_4'
> >             is invalid in C99
> >     include/generic/rte_atomic.h:772:9: error:
> >             implicit declaration of function '__atomic_exchange_8'
> >             is invalid in C99
> > 
> > We need to check for current compiler, not the compiler used for
> > DPDK build.
> 
> Right, API cannot rely on internal build system configuration.
> 
> > Fixes: 7bdccb93078e ("eal: fix ARM build with clang")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied (if armv8 typo), thanks

  reply	other threads:[~2019-01-14 18:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190114161447eucas1p1c1d73ede17b706e69a4db491f8c94578@eucas1p1.samsung.com>
2019-01-14 16:14 ` Ilya Maximets
2019-01-14 16:27   ` Thomas Monjalon
2019-01-14 18:49     ` Thomas Monjalon [this message]
2019-01-14 19:06       ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-01-14 16:46   ` Richardson, Bruce
2019-01-15 11:32     ` Ilya Maximets
2019-01-14 16:50   ` Honnappa Nagarahalli
2019-01-14 18:47     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3867865.yVi6bGp0KD@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=i.maximets@samsung.com \
    --cc=pbhagavatula@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).