From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24649A00BE for ; Tue, 15 Mar 2022 12:10:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED4494014F; Tue, 15 Mar 2022 12:10:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 432744014F for ; Tue, 15 Mar 2022 12:10:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647342636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NNh3eLMx38ig7vw4+BmMmc+CMIsVt64N77UXmfvx+XY=; b=DWBj0yJihU7tZj7HLePzU1K7e1APdgjCNR37cbw7ICV/w0y4OWRpF6owL3Lz8c4RDFQzN2 qB2Q6JB3yvSrfbiwRjp5r7UlPBKcGQt9dn5+j4JhFzTdC1n+NFibLHwfxiYR9Y6xc0YqRH ioWIHy3ftAoBm66phmtgBcSkGVzs/x4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-654-fPwV3DHBNb-Sd8pXun_k8Q-1; Tue, 15 Mar 2022 07:10:34 -0400 X-MC-Unique: fPwV3DHBNb-Sd8pXun_k8Q-1 Received: by mail-wm1-f72.google.com with SMTP id l1-20020a1c2501000000b00389c7b9254cso783488wml.1 for ; Tue, 15 Mar 2022 04:10:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=NNh3eLMx38ig7vw4+BmMmc+CMIsVt64N77UXmfvx+XY=; b=t/MuUKXZcrfeLXKR/z1XWnhGsMwrU3kkNyZYJcljKQWDMbaCVX2RNrrHwYXayWjR1Z NGhgxf3UzLeOIViH9guSZmz8+S6MzJb7hp796MaTXUCcHgPCyqM3nRcWQTuB+J+qpkH7 JhpTte6Fl37ACQA6lBKoD/qQISYbnoQ+bxu3lNSGX2FwyKDA5TrdCTDU1N+1DtFHe5ZC 3mOpJUNqMvctmfHcqkx/KdVgFTPZIHp4bnfz4/QcYHW5oswGuTLZMRmYPQ0dwlEpKwkN 1WviHwyUE+zRc7srveDufWZ+QCL9aljQZyJaaTrpGb9qaXA6anSOpABH/YTEFbDHllHL AquQ== X-Gm-Message-State: AOAM531uXPUiWyBmITLRH92CFSd/PSHxDl+GL8w1t8yquDY5EOp2h6U5 3BQcl7Z3Jfj/Nbzi27MK1kxbCHIlF1zVg3XU9dZnHK9OpuccaixrwL7AlJ1SoZ6H/PCKzrXsmmM X4lkdWYI= X-Received: by 2002:a1c:cc01:0:b0:37b:dcc8:7dfd with SMTP id h1-20020a1ccc01000000b0037bdcc87dfdmr2912242wmb.134.1647342633236; Tue, 15 Mar 2022 04:10:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzd4U0h21WUVMonXCkAYFlvB8OAGxy+xJsI/nvi06zUaHE9b64eYCcNFUBTGHSVTRnvaIRdzQ== X-Received: by 2002:a1c:cc01:0:b0:37b:dcc8:7dfd with SMTP id h1-20020a1ccc01000000b0037bdcc87dfdmr2912224wmb.134.1647342632983; Tue, 15 Mar 2022 04:10:32 -0700 (PDT) Received: from [192.168.0.36] ([78.18.23.103]) by smtp.gmail.com with ESMTPSA id a17-20020a5d5091000000b001edb61b2687sm24034657wrt.63.2022.03.15.04.10.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Mar 2022 04:10:32 -0700 (PDT) Message-ID: <386cb1f9-b82a-4988-bb34-9536ef2c51fa@redhat.com> Date: Tue, 15 Mar 2022 11:10:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 To: Pablo de Lara , luca.boccassi@gmail.com, stable@dpdk.org References: <20220314110559.1502861-1-pablo.de.lara.guarch@intel.com> From: Kevin Traynor Subject: Re: [PATCH 20.11 1/2] crypto/ipsec_mb: fix length and offset settings In-Reply-To: <20220314110559.1502861-1-pablo.de.lara.guarch@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Pablo, On 14/03/2022 11:05, Pablo de Lara wrote: > [ upstream commit a501609ea6466ed8526c0dfadedee332a4d4a451 ] > > KASUMI, SNOW3G and ZUC require lengths and offsets to > be set in bits or bytes depending on the algorithm. > There were some algorithms that were mixing these two, > so this commit is fixing this issue. > > Fixes: ae8e085c608d ("crypto/aesni_mb: support KASUMI F8/F9") > Fixes: 6c42e0cf4d12 ("crypto/aesni_mb: support SNOW3G-UEA2/UIA2") > Fixes: fd8df85487c4 ("crypto/aesni_mb: support ZUC-EEA3/EIA3") > > Signed-off-by: Pablo de Lara > --- For 21.11. I backported and applied a501609ea6466 from dpdk main branch to 21.11 branch [0]. The version sent here directly to 20.11 is quite different as it adds the 'switch (job->cipher_mode)'. (It feels like some other patch adding 'switch (job->cipher_mode)' was missed for backported) As this switch is not in [0], the following GMAC patch [1] won't apply for 21.11. One option is that you send a patch to just add the missing parts, and then I apply the GMAC patch. But the simplest option is that I revert [0], apply updated 20.11 version + GMAC patch. I'll go with the latter option (assuming they apply cleanly), but please let me know if that sounds ok. thanks, Kevin [0] http://git.dpdk.org/dpdk-stable/commit/?h=21.11&id=daf06c45e8576d8a2a86455e33e2bc4574f8f8b4 [1] 837269c2e5c5 ("crypto/ipsec_mb: fix GMAC parameters setting")