patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: stable@dpdk.org, Chenbo Xia <chenbo.xia@intel.com>,
	Marvin Liu <yong.liu@intel.com>
Subject: Re: [PATCH] net/virtio: restore some optimisations with AVX512
Date: Tue, 19 Apr 2022 11:12:59 +0200
Message-ID: <389b7ac6-1828-013d-b9dd-8d539d212798@redhat.com> (raw)
In-Reply-To: <20220411150420.17796-1-david.marchand@redhat.com>

Hi Marvin,

On 4/11/22 17:04, David Marchand wrote:
> Those optimisations were only enabled with make builds, fix the meson
> part.
> 
> Fixes: 77d66da83834 ("net/virtio: add vectorized packed ring Rx")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   drivers/net/virtio/meson.build | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/virtio/meson.build b/drivers/net/virtio/meson.build
> index 01a333ada2..d78b8278c6 100644
> --- a/drivers/net/virtio/meson.build
> +++ b/drivers/net/virtio/meson.build
> @@ -30,11 +30,11 @@ if arch_subdir == 'x86'
>                             c_args: [cflags, '-mavx512f', '-mavx512bw', '-mavx512vl'])
>               objs += virtio_avx512_lib.extract_objects('virtio_rxtx_packed.c')
>               if (toolchain == 'gcc' and cc.version().version_compare('>=8.3.0'))
> -                cflags += '-DVHOST_GCC_UNROLL_PRAGMA'
> +                cflags += '-DVIRTIO_GCC_UNROLL_PRAGMA'
>               elif (toolchain == 'clang' and cc.version().version_compare('>=3.7.0'))
> -                cflags += '-DVHOST_CLANG_UNROLL_PRAGMA'
> +                cflags += '-DVIRTIO_CLANG_UNROLL_PRAGMA'
>               elif (toolchain == 'icc' and cc.version().version_compare('>=16.0.0'))
> -                cflags += '-DVHOST_ICC_UNROLL_PRAGMA'
> +                cflags += '-DVIRTIO_ICC_UNROLL_PRAGMA'
>               endif
>           endif
>       endif

I wonder how this was not spotted by the Intel performance lab?
Is that these optimizations do not bring performance gains, or it is not
benchmark-ed?

Anyway:

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  reply	other threads:[~2022-04-19  9:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 15:04 David Marchand
2022-04-19  9:12 ` Maxime Coquelin [this message]
2022-05-05 19:56 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=389b7ac6-1828-013d-b9dd-8d539d212798@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git