From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C201A00C4 for ; Fri, 5 Aug 2022 17:09:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E68A42C0C; Fri, 5 Aug 2022 17:09:29 +0200 (CEST) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mails.dpdk.org (Postfix) with ESMTP id 83A2A400D6 for ; Fri, 5 Aug 2022 17:09:27 +0200 (CEST) Received: by mail-wr1-f42.google.com with SMTP id v3so3652099wrp.0 for ; Fri, 05 Aug 2022 08:09:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc; bh=5L+X9chTqQVpQqXmtIiGyIr+MtbgKGFKrnqh7+zDYjQ=; b=cum3B/yId9m+tbkWQF67gYwHI/vfNMNFmA6p04KzLzAvaQivCpXP4kxvU8iPs3Hae2 2s9w9QAjl4JEtXCsf9bjTG2xlWIGH2f+/00hfB13Bs7lTyS2o7Q3dETSVNC1/7Dt8bkS L99RkhCz/YDv0ODE44VDlHlZNeQHPaC1+mtQJ3yyYPZCPH1V/VbIt66YD5ZF5ko8kLjU M6Hiwesak2aKYtln3XHmmA6x6u4f8aKJi0acXJlPdYU+ePVYqR88J/JKvQh+d0X7TPlu 5gqVz8wdmuB5rLATJd85zLLsS4Up8uu4Z5QnMrz4FeQIYwpycTz5Aa+VM8W+BfNrDqaw l7PQ== X-Gm-Message-State: ACgBeo0iXw4TVOXBm/q0MB3w0KrcMPOZo8EwUfjHRXqV7ks1yEm2jW8T MJesLdod/IAZGL1+Pg6MotiiN4u1dr0= X-Google-Smtp-Source: AA6agR5XU7UUPKzCbRVA7GV7hT2qzFyr0OQADcaNz15z6/R/FsRxULKxfmfbCDyNRyEiri/exc9yOg== X-Received: by 2002:a05:6000:186b:b0:220:5bf8:a5e8 with SMTP id d11-20020a056000186b00b002205bf8a5e8mr4604537wri.328.1659712167075; Fri, 05 Aug 2022 08:09:27 -0700 (PDT) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id bd6-20020a05600c1f0600b003a2cf1535aasm5079344wmb.17.2022.08.05.08.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 08:09:26 -0700 (PDT) Message-ID: <38da7a720c298be79038c0a1de17477bbe177160.camel@debian.org> Subject: Re: [PATCH] net/vhost: fix null pointer dereference From: Luca Boccassi To: "Ma, WenwuX" Cc: Maxime Coquelin , "Xia, Chenbo" , dpdk stable , "Hu, Jiayu" , "Wang, Yinan" , "He, Xingguang" Date: Fri, 05 Aug 2022 16:09:25 +0100 In-Reply-To: References: <20220805022127.757324-1-wenwux.ma@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.38.3-1+plugin MIME-Version: 1.0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, 2022-08-05 at 10:12 +0000, Ma, WenwuX wrote: >=20 > > -----Original Message----- > > From: Luca Boccassi > > Sent: 2022=E5=B9=B48=E6=9C=885=E6=97=A5 18:04 > > To: Ma, WenwuX > > Cc: Maxime Coquelin ; Xia, Chenbo > > ; dpdk stable ; Hu, Jiayu > > ; Wang, Yinan ; He, Xingguang > > > > Subject: Re: [PATCH] net/vhost: fix null pointer dereference > >=20 > > On Fri, 5 Aug 2022 at 03:22, Wenwu Ma wrote: > > >=20 > > > Because the async member of the vhost_virtqueue struct can be freed i= n > > > controlpath, so it should be protected by spinlock in datapath, or, i= t > > > may cause null pointer dereference in the following > > > vhost_poll_enqueue_completed(). > > >=20 > > > Fixes: b737fd613969 ("vhost: add unsafe async API to clear packets") > > >=20 > > > Signed-off-by: Wenwu Ma > > > --- > > > =C2=A0lib/vhost/virtio_net.c | 12 +++++++++--- > > > =C2=A01 file changed, 9 insertions(+), 3 deletions(-) > >=20 > > Hi, > >=20 > > Is this for a stable branch? If so, which one? Please use --subject-pre= fix next > > time to clearly identify it. > >=20 > Sorry, it is 21.11 Does this issue affect only 21.11? Or main as well? --=20 Kind regards, Luca Boccassi