From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10064.outbound.protection.outlook.com [40.107.1.64]) by dpdk.org (Postfix) with ESMTP id B73FD2C6B for ; Fri, 13 Jan 2017 20:55:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=D8oAlNd+vQiP2JOM2TTdQvh/wmqBr38FepC/3I224gU=; b=EZ9S1L/UKLmLxexW5tFKqxDqE78HPiOrJGJy6a/58u57cBFOstPoBYx0ydVXnpbwSRyMJNOIRj7r4xINt7ycMQHEA6OYY71RyledXMCLgUWl4McQwtx5oMrraeLZkFe/UmPeTCLTaUwV/6k7VGXjQGCPCQBuOYk5fcDjB98+Dk8= Received: from DB6PR0501MB2455.eurprd05.prod.outlook.com (10.168.73.136) by DB6PR0501MB2167.eurprd05.prod.outlook.com (10.168.55.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.12; Fri, 13 Jan 2017 19:55:37 +0000 Received: from DB6PR0501MB2455.eurprd05.prod.outlook.com ([10.168.73.136]) by DB6PR0501MB2455.eurprd05.prod.outlook.com ([10.168.73.136]) with mapi id 15.01.0829.017; Fri, 13 Jan 2017 19:55:36 +0000 From: Yongseok Koh To: "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix updating total length of multi-packet send Thread-Index: AQHSbdWo4y9ve74egkqCLHPcuR9SOaE20laA Date: Fri, 13 Jan 2017 19:55:36 +0000 Message-ID: <3FEDCB07-DF42-4E44-A839-BDD390FD0656@mellanox.com> References: <20170113194537.19364-1-yskoh@mellanox.com> In-Reply-To: <20170113194537.19364-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [12.250.235.110] x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-exchange-diagnostics: 1; DB6PR0501MB2167; 7:vKklqtmg3HNcZ/vABeM3UgubuwbdxRoTdydIsbGW4H2XvEaBxc3wFJpbCF3YZDziv9ovCYCmn2XdMVSGSJdGVJqfrJe/9i9E61g2WoTmd/F7zpMpNfppfM6qdoAGmqWQ4BZfF/sdGF5/x0NC3gGJqyGCtCutz1+XILUp3mt4m/VwefWLm+ZIJGcit5yFnxhdpxoB59PkgSMr2wckcVEqrW0cHcqmmuewbzBIkSiAHiG0xenpwg5IdT20k1heF05Dd5bh6WPbexYuQwHFh3OfxvmB90tuckIXABLkwNg13qnKHhFY7vw9kpGDc03hlx4QApjyaXyx9l/QhmGs5W49VHla6/ozrh3kj3CLy3T20MJURKeV74M6Is7tKPgrNFgANThZRVw+p6CQ9MrOGiSLsSFRzNGv7actQAQjRxkCNKBhprYA6FRc9aADKJKKeSUFCHuIcs4EoXzK9Dg43hNQxQ== x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39410400002)(39850400002)(39450400003)(39840400002)(189002)(377454003)(24454002)(199003)(8676002)(99286003)(76176999)(8936002)(2900100001)(3280700002)(2906002)(38730400001)(81156014)(50986999)(27001)(25786008)(3660700001)(6486002)(77096006)(6512007)(6436002)(54356999)(101416001)(86362001)(189998001)(68736007)(6506006)(229853002)(6116002)(7736002)(81166006)(110136003)(106116001)(83716003)(107886002)(102836003)(1730700003)(5640700003)(3846002)(82746002)(2351001)(5660300001)(97736004)(66066001)(2501003)(92566002)(6916009)(33656002)(36756003)(305945005)(122556002)(105586002)(2950100002)(106356001)(104396002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2167; H:DB6PR0501MB2455.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; x-ms-office365-filtering-correlation-id: 5cc274f6-d00d-4760-d0bc-08d43bee24aa x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:DB6PR0501MB2167; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148); SRVR:DB6PR0501MB2167; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2167; x-forefront-prvs: 018632C080 received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <0A1FB396A374C240A429C567707B2B4E@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2017 19:55:36.7000 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2167 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix updating total length of multi-packet send X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 19:55:39 -0000 Hi It was my mistake to send it to only stable@dpdk.org. I should've included dev@dpdk.org and the maintainer. I will send it again appropriately, please ignore this email. Thanks, Yongseok > On Jan 13, 2017, at 11:45 AM, Yongseok Koh wrote: >=20 > The total length field in descriptor of inlined multi-packet send must be > updated before closing a seesion. There's possibility of updating it > afterward. This bug might cause one packet out of MLX5_MPW_DSEG_MAX gets > silently dropped by HW and impact performance, escpecially lossless test.= . >=20 > Fixes: 230189d9ff22 ("net/mlx5: support multi-packet send") >=20 > CC: stable@dpdk.org > Signed-off-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 89b1300e6..a5b492dcc 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -1179,6 +1179,7 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte= _mbuf **pkts, > mpw.data.raw +=3D length; > } > ++mpw.pkts_n; > + mpw.total_len +=3D length; > ++j; > if (mpw.pkts_n =3D=3D MLX5_MPW_DSEG_MAX) { > mlx5_mpw_inline_close(txq, &mpw); > @@ -1188,7 +1189,6 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte= _mbuf **pkts, > inline_room -=3D length; > } > } > - mpw.total_len +=3D length; > elts_head =3D elts_head_next; > #ifdef MLX5_PMD_SOFT_COUNTERS > /* Increment sent bytes counter. */ > --=20 > 2.11.0 >=20