From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 6FC242BAA; Thu, 13 Jul 2017 17:56:18 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jul 2017 08:56:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,354,1496127600"; d="scan'208";a="124770413" Received: from dwdohert-mobl1.ger.corp.intel.com (HELO [163.33.228.177]) ([163.33.228.177]) by orsmga005.jf.intel.com with ESMTP; 13 Jul 2017 08:56:16 -0700 To: Pablo de Lara References: <20170713033512.25123-1-pablo.de.lara.guarch@intel.com> Cc: dev@dpdk.org, stable@dpdk.org From: Declan Doherty Message-ID: <3a49844a-e31b-d8fe-d1ef-0c03778bba56@intel.com> Date: Thu, 13 Jul 2017 16:56:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170713033512.25123-1-pablo.de.lara.guarch@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH] crypto/aesni_mb: fix possible crypto job leak X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jul 2017 15:56:19 -0000 On 13/07/2017 4:35 AM, Pablo de Lara wrote: > When dequeueing operations from an AESNI-MB device, > crypto jobs are dequeued from the internal scheduler > in the Multi-buffer library. > > If the number of jobs available to retrieve > are higher than the number of crypto operations > that are required, then an extra job is retrieved > (due to an incorrect conditional), but not used. > This leads to a job leak and the operation associated > to that job will not be ever dequeued. > > Fixes: 0f548b50a160 ("crypto/aesni_mb: process crypto op on dequeue") > Cc: stable@dpdk.org > > Signed-off-by: Pablo de Lara > --- ... > Acked-by: Declan Doherty