From: Hemant <hemant.agrawal@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 02/13] net/dpaa: fix jumbo buffer config
Date: Tue, 18 Sep 2018 21:52:06 +0530 [thread overview]
Message-ID: <3a653f4d-794e-a8cc-1943-5b9592c9f4b0@nxp.com> (raw)
In-Reply-To: <4111188.BaBaHoflxE@xps>
On 9/18/2018 7:33 PM, Thomas Monjalon wrote:
> 18/09/2018 15:31, Hemant Agrawal:
>> Avoid return after the jumbo buffer config in dev config API
>>
>> Fixes: 9658ac3a4ef6 ("net/dpaa: set the correct frame size in device MTU")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Thanks for adding some comments in this series.
>
> About this fix, would it be easier to understand if explaining
> what is the bug first?
>
>
yes. I can be more specific here.
1. the dev->data->mtu was not getting updated earlier for the jumbo
buffer config.
2. we don't expect to return error, if this config fails. A debug err
log is ok. DPAA1 - supports jumbo by default, enable/disable may give
errors.
next prev parent reply other threads:[~2018-09-18 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1535539660-20228-2-git-send-email-hemant.agrawal@nxp.com>
[not found] ` <1537277516-8876-1-git-send-email-hemant.agrawal@nxp.com>
2018-09-18 13:31 ` [dpdk-stable] " Hemant Agrawal
2018-09-18 14:03 ` Thomas Monjalon
2018-09-18 16:22 ` Hemant [this message]
2018-09-18 13:31 ` [dpdk-stable] [PATCH v2 04/13] net/dpaa: fix link speed based on MAC type Hemant Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a653f4d-794e-a8cc-1943-5b9592c9f4b0@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).