From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B491DA00BE for ; Tue, 15 Mar 2022 12:19:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9200F4014F; Tue, 15 Mar 2022 12:19:04 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 207D54014F for ; Tue, 15 Mar 2022 12:19:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647343142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kn7l3EqYac05RRUp2RkSfgC/zPBrGvdugA+cXN+f2Fg=; b=ZRmVdDk+74D3J5niZHkfS4nl6eCYcyAmBSVckoQ+6JT2EEGqznfwiVfHgGDpf4LSRlmI+Q 7R5yikJ5CXsi9ew906LlGMi1s1oFX5775ihiDb82YdlbfD32w3rgjevnrzKaGERwjhza4P YMLNYFImcBDPuTZOXZoXcogX/OxOlFc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-587-FGEVtYiTNxaFEMQboXPTuw-1; Tue, 15 Mar 2022 07:19:01 -0400 X-MC-Unique: FGEVtYiTNxaFEMQboXPTuw-1 Received: by mail-wm1-f72.google.com with SMTP id j42-20020a05600c1c2a00b00381febe402eso1106622wms.0 for ; Tue, 15 Mar 2022 04:19:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:from:to:references:subject:in-reply-to :content-transfer-encoding; bh=Kn7l3EqYac05RRUp2RkSfgC/zPBrGvdugA+cXN+f2Fg=; b=iWW0pKLNT3OcW7x53htqTDJdl/8/oUTDx11RdvQrSZNtiZOTNqXEOLQZ/ZJIl3Ok8L XNO684KchYUHRQqcHVklLMEKqlfyXUHAejAw5e0o3qjXcjvn8QmrhQnT7hbDj9mv3xfl 2kzlI1vL2Lc76b9hx0G6Ndvf/x8Rbsmiu4oXpASB/F03uVda2eGkGzDihPp7Hhg3Z3V3 uHEwVOvwBixpAKR0UMJC5bNkqcZsaxTrgRPqV86br4ifztxdGH4aA+i6C29SNpWXpte8 AV8AiwFr0ufcpwl7wexPO0dHvPeQlROkoWWHU78yZ8BlB+u4MkrIQXh8TDQ6HmuG/sIf Ufuw== X-Gm-Message-State: AOAM530TJQbbMjdbRA8pT6fp1HjNytTDt0lv0fhFZ2Pj2ayWkR67QBnP kBXITnmjYpYFO7zB1pcZ37wI0v3SBaKr/JFrggxW8DA5eiVl81Mb2H7PNaWZrr8tqHtLJ5KSpdD t3fg44tg= X-Received: by 2002:a05:600c:35ce:b0:389:ec57:1d7f with SMTP id r14-20020a05600c35ce00b00389ec571d7fmr2847011wmq.149.1647343137830; Tue, 15 Mar 2022 04:18:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxA5Gb88HIuo+2KxBu+6gIHtd3hptzF7qnA1GULPh5ZestHTcDd0Yjwk1xQUg4EmzKBZrpJA== X-Received: by 2002:a05:600c:35ce:b0:389:ec57:1d7f with SMTP id r14-20020a05600c35ce00b00389ec571d7fmr2846993wmq.149.1647343137659; Tue, 15 Mar 2022 04:18:57 -0700 (PDT) Received: from [192.168.0.36] ([78.18.23.103]) by smtp.gmail.com with ESMTPSA id m20-20020a05600c4f5400b0038b5162260csm2961236wmq.23.2022.03.15.04.18.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Mar 2022 04:18:57 -0700 (PDT) Message-ID: <3a9ab8af-0a11-248d-24e3-37c7bde7b850@redhat.com> Date: Tue, 15 Mar 2022 11:18:56 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Kevin Traynor To: Pablo de Lara , luca.boccassi@gmail.com, stable@dpdk.org References: <20220314110559.1502861-1-pablo.de.lara.guarch@intel.com> <386cb1f9-b82a-4988-bb34-9536ef2c51fa@redhat.com> Subject: Re: [PATCH 20.11 1/2] crypto/ipsec_mb: fix length and offset settings In-Reply-To: <386cb1f9-b82a-4988-bb34-9536ef2c51fa@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 15/03/2022 11:10, Kevin Traynor wrote: > Hi Pablo, > > On 14/03/2022 11:05, Pablo de Lara wrote: >> [ upstream commit a501609ea6466ed8526c0dfadedee332a4d4a451 ] >> >> KASUMI, SNOW3G and ZUC require lengths and offsets to >> be set in bits or bytes depending on the algorithm. >> There were some algorithms that were mixing these two, >> so this commit is fixing this issue. >> >> Fixes: ae8e085c608d ("crypto/aesni_mb: support KASUMI F8/F9") >> Fixes: 6c42e0cf4d12 ("crypto/aesni_mb: support SNOW3G-UEA2/UIA2") >> Fixes: fd8df85487c4 ("crypto/aesni_mb: support ZUC-EEA3/EIA3") >> >> Signed-off-by: Pablo de Lara >> --- > > For 21.11. I backported and applied a501609ea6466 from dpdk main branch > to 21.11 branch [0]. The version sent here directly to 20.11 is quite > different as it adds the 'switch (job->cipher_mode)'. (It feels like > some other patch adding 'switch (job->cipher_mode)' was missed for > backported) > > As this switch is not in [0], the following GMAC patch [1] won't apply > for 21.11. > > One option is that you send a patch to just add the missing parts, and > then I apply the GMAC patch. > > But the simplest option is that I revert [0], apply updated 20.11 > version + GMAC patch. > > I'll go with the latter option (assuming they apply cleanly), but please > let me know if that sounds ok. > I just noticed Luca is reporting build failures. In that case, please send these 2 patches rebased for 21.11 branch as well. If the same patches work for 20.11/21.11 you can indicate in the subject-prefix. I will revert [0] and apply those. > thanks, > Kevin > > [0] > http://git.dpdk.org/dpdk-stable/commit/?h=21.11&id=daf06c45e8576d8a2a86455e33e2bc4574f8f8b4 > > [1] 837269c2e5c5 ("crypto/ipsec_mb: fix GMAC parameters setting") > >