From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bing Zhao <bingz@nvidia.com>, <viacheslavo@nvidia.com>,
<orika@nvidia.com>, <wenzhuo.lu@intel.com>,
<beilei.xing@intel.com>, <bernard.iremonger@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH] app/testpmd: fix raw encap of GENEVE option
Date: Fri, 25 Feb 2022 15:44:33 +0000 [thread overview]
Message-ID: <3aef94f4-238c-00db-3dfd-f2928ec8f3c2@intel.com> (raw)
In-Reply-To: <20220224070214.326158-1-bingz@nvidia.com>
On 2/24/2022 7:02 AM, Bing Zhao wrote:
> The structure "rte_flow_item_geneve_opt" is not a protocol header of
> geneve tunnel option from rfc8926. The field "data" is a pointer
> which points to the actual variable-length option data. So the
> structure is not packed.
>
> There is 4 bytes hole before the pointer in a 64-bit system. The
> option header is just 4 bytes. When using offsetof() to get the
> fixed part's size of option header, the wrong value 8 was got. When
> constructing the encap header, a wrong size and offset was used due
> to this hole.
>
> With this commit, the fixed part's size is calculated explicitly
> based on all fields.
>
> Fixes: 55c074f3ba1d ("app/testpmd: support GENEVE option item")
> Cc: viacheslavo@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2022-02-25 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 7:02 Bing Zhao
2022-02-25 15:44 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aef94f4-238c-00db-3dfd-f2928ec8f3c2@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).