From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2714143C27 for ; Fri, 8 Mar 2024 10:46:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 178D642FC9; Fri, 8 Mar 2024 10:46:11 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2073.outbound.protection.outlook.com [40.107.223.73]) by mails.dpdk.org (Postfix) with ESMTP id E56B242F81; Fri, 8 Mar 2024 10:46:07 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HS1y54xiCotxav5Y4WFedwObjJoUID3KOxmThYBfFsAZ1uMyx7BpbfnVdluzAflmRel0E8AWfTrJOBGn7TO4LoRlk6ehV0O/2B0KzEr2iKfOHd8NN7pl6QW8yMKArgyqFruefkO+bH05n2yck6F3qWDUvZDoCh3aAzFcLi2nsQ76ym8Zj8LfWV5uSfyTcB69xk1T4cTP7L0owFVe4m3z47Yiibb3MmpfjMQiG0FYggNkz3npI9uCreCGa8mhx4U/jSiCmXLzbYIBd5ayRnuVye70e0gWJH2MYnYJ96SilHBymqMXMYv94VyI+w1KY2sbF0ykviUOjGvy0HKhJ7Uj8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/bx+KWoKvUbWWkiyrDXB04+FxbO/0lwSAqVF3uJB7kA=; b=FDG3YUlGuUXMXSXNW5+pM6gV9QqlSE+4mk10vtsaa2QQg7tANtC50Wez7BIwCUR7Vq0hggiPZ0l6mOEql16WqHBXBN2uSGzvhvl4QXzJ31wabjwg0E4viXqCyqnm4h6CDShp8gSMsNK/hpD5tdOi7bLVEbj2iELxvASOha6I4fe8E/yy6/W7ncNDF4FsV8a7Yqj1Yqo4WIXd/6jf5STHxCyp/PCA8/g94Vw+eai4H70ZaK7wRHeixgcddEv6Jn/+ku5vnlaBR9BjqphKVu8vxCHgw0glTCYuj7CvyLK1CppWjgIt4qptJf9sgXP/GESf2d0qT0QDfkg4hz0dJjJeUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/bx+KWoKvUbWWkiyrDXB04+FxbO/0lwSAqVF3uJB7kA=; b=OTCG5ewy5W4aiIyY+62/U/6czjxAHrgL2/sUv2644JjesXkq9OX37+BcPW7WPl/TuG/zwVoGDnYnGVWLcBfpqFxlA9pXVv2gGvRrU15F7+NZPQyij4sKVv3yAbd+q6qoU9y3HC9R7wpqgRAm0JsQB8eaAibdQ68jOqh/RRW2wcg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by LV2PR12MB5797.namprd12.prod.outlook.com (2603:10b6:408:17b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Fri, 8 Mar 2024 09:46:06 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.028; Fri, 8 Mar 2024 09:46:06 +0000 Message-ID: <3b038def-d26a-4d0f-9bca-584ce55930f9@amd.com> Date: Fri, 8 Mar 2024 09:46:00 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/nfp: fix failure of PF initiation on flower firmware To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, Zerun Fu , stable@dpdk.org, Long Wu , Peng Zhang References: <20240308031110.2041280-1-chaoyong.he@corigine.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240308031110.2041280-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0029.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|LV2PR12MB5797:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d860f27-4286-4107-9e5f-08dc3f54933c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dUf0WnfMtv8lSox25Y1lWgqcH/hcDbOyYMr/HRmd+KbmMqOc0j4iCYD/2WU+KWvHE/d+DjWRDHhvqs6oDeQOrzWyN4cehR4ohOWlYzlsiw52BZKg/lf3DH4dWvFlvedQiTzNk6GHEztcP2+e9yjnkZ4KSR0djhUGAP10RtZKRW3b+e26z3pd1dn4EvTA9Ozfc0mfA33YvJAW0dvw4f97ZpYpg8p0EraQhBjULcFF7zStcj3LE5J3uOQjs1ogHoDpqVvbZylE8pz2yyiN5FsUpy2DPCWJc2Ecsdnpgx9kz4xWqsro+4hmNOAQSoks6MkAByCAkRFJ77Mk7RIAZRnNgPc9XDcoHBkm0jmJzkw9NovWZ4BsZIE8tfxgffqVza5krLW8oFPfEOp4VpmGSnCFclciLeqBRAXthdJCTR0BnGblJY9ssRVMFb75iHP5UNR8dMEWLF3Ff/pA9o16LHegHIF2wsGzyjfv9ebTelSEJ1cn/ZD0FM9xd6Yy4X8uIW37wd3ARz0s5U9Jl99pZ2SdIQAkVo3Qcq4PtoIhAhf0J0FkX7p48zLQe+sDLJ2vvuy+r/TEZaTccDj52iKhlqP+YleOiL8jh394l6dmdQzETd3LgE+IxLmog6nQTCEdIGWxA/ZPN468JyP5x4j3ND67IX3tJAU+BgDkfjqH6yc8JBU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDgrMlpFZEFEcVdSQnlDMnBoeXpGS1JobThJYVVvTVExVGtqdDdKcE1NYjBC?= =?utf-8?B?aWhEc1Z0YWNtQ3pnYit2TzVJZWNrUzk2Q0lCUmNmWkVNZVFFMXBMRnR1M3pN?= =?utf-8?B?bzdJS1c1T3crWGpMS0tiRDdweGpxZ0JaMjRtT0pRSmcwTmxHUzM5SW1ydGNO?= =?utf-8?B?NER3ODkrUURIS082Nk1TSitRd3VkNVovWWE5S2JONVhQdlFDaDlmaDBBMy9r?= =?utf-8?B?NEx1RG51YXJicGtJK2oxVGN6Yzl1Y2s3d2orZ1dsaUI3djViSCtqVWs1Z2hj?= =?utf-8?B?NkR4eVdCMWVJSnZjOGdQdFA3ZUhMNWg3a1p1alllZVlWakJGbVhuWmhGVDJR?= =?utf-8?B?VDRBK3pFTE9GWHZWdU50aXV5R2lsakVBblpobGY2aUZOMkNnKzBFR0VlSDk2?= =?utf-8?B?bDJqOTYxLzhtWlBjQjQ0bWZaeFNaK0ZLeUlPTmJUVG9UcVhjbEZvSHJCMnh5?= =?utf-8?B?aXN5Vmk0cHF4VFh2SGtoMDRwQ3UzRUF5bHBLamZqSDExQm9kTkdJS25XWmRh?= =?utf-8?B?MlE1L09rRFl3V2pWY0hPdGpBRmVSRVNyZTBET2ZQdG1VY0thSTZxU1c4NWdP?= =?utf-8?B?OWYzQTkrajBaNUZPdEk3VTAyVk9LUlZKeEpMWjlOQ1cxa3lVY2dhUW1sVzJt?= =?utf-8?B?M2d2dlAwd3p6MUFKMTNPWDl2d3BvSkowR1VTVDdZUzBUVFNNajlrU1ZRY2hM?= =?utf-8?B?RzVFSnRyOHBtMWcwaG9pdHZNUFU2eVYwNGlSNlRiM1o4VWJXTU4wcDlUQnBr?= =?utf-8?B?STFZNGNoQWE4VzNNNm80dnJYb2svbll3T3FGNlVJcFRRRjVjUVNFaHNkSFBF?= =?utf-8?B?ZTNRRTBrekZ5YWRtUG5HeCtZd1dOTCt5cWlkNUd5ak9rejZweXYyZlNPdXRj?= =?utf-8?B?MXJhN2R1UWZZZHVxZmFTOGhEclRFVjIzSTI1dXJOcXZmK2hRQnpqSXhLMy85?= =?utf-8?B?Ri85WFZIbTFPWkhyWnJwSFBkZ3ZzclZmay9mK3pZVTZLeEpmVnMyZ3ovd1BB?= =?utf-8?B?K2djcGhESGJQTndpRmF5Tkk0Z1gvSE9iYVA5SDBqZC9UZWpPWWEydllzNEdv?= =?utf-8?B?L3htczd5dlBEWW03MWdyQzhHeFNjT3psUmZwb0tCS09WUHBzY2N0UktBZXdl?= =?utf-8?B?bTYxQ21SL2I0QXJpYXBHZkVhWWwwTUkzZ1hoVUNzeTN3WVBqcWRWc3BJUEJC?= =?utf-8?B?TjlDNE5ZaTdKLzkxY2tqS2FjM3ZzbHo1ZktUa3F6QnN3TUR4bmZlQ3FManVC?= =?utf-8?B?TDhLNjc5bFZCNmlaZEFHNzcxckp5Vms3NVU0S3JCNm5Ma1lmWVgyME51Zk5r?= =?utf-8?B?UGpjQmcraUdteGJscVJjYTV5LzQ1eWRQd21VWGRCUjRjdllZeTRDeUNXRW84?= =?utf-8?B?ZlIzcjlQV3dWbm1vcFhLdExGOWdFQzZwMWNkMzRIUEh6dWRDVUdzVmFibHA3?= =?utf-8?B?K3dPbTFDbEpFTGpxcWhKSWtULzF0NlJjL3V5czdvajUxZW1XeWk5N2hkTW44?= =?utf-8?B?MDdQYWw5LzFieXI5R1ZVMUd4d0tEazNSSmdvdHBWcUZwUUNsR0s0eFIzRy9r?= =?utf-8?B?bTJUUDE1eGMvNE9JT21vYkg5bWlHc1BnYjNubHpNRTFUU1V5b0JRYklkTnhs?= =?utf-8?B?MWx4RzJkSnZnckRoREJ3YnhwNmlhN2RoZklZa3JBMHBIN2gzbDZEYmhobFV1?= =?utf-8?B?aEQvSGlPYXlqYkFhL1Uxdk9vdzNUZ0RvSDNabktSUVFCd0NJUGZINTh3Rmkw?= =?utf-8?B?NVQ0WGRJdkJrWWdMamRpT2k4SlpYM1I0ZTIrYmFlY2x0dXdSckNPdGhuamdS?= =?utf-8?B?THdMVzlIR1I4YzdvQ3V2VGsyaU0zeXFxdGVWaXlpR1FYUlA3c3pGY1Y3YzJS?= =?utf-8?B?Zm52VkM3cVlGNDY1WlZ2NUZHa082bTA3S2I4eWR4VjhvUmhtamlSYmpWWkdD?= =?utf-8?B?YmNYa2VZUHJML0xMTkVWNXdUa3lPNDE4R3JFZThzbW9GSk9nZng4WE9jUHBI?= =?utf-8?B?dld6TTdVUHpLYXYwNXNtWHNLVjF4MWFSeXRpVUREMWFiVEZ4VndNdTZTMEtz?= =?utf-8?B?YXJ6TGhmNmNYQzNKcnBzaGxuQ3c4b1c5ZGh1NTNidVZ1VU9ZRHc0T1d3TW1F?= =?utf-8?Q?eEUYLZHBWsNt0y58AIG1hoya3?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d860f27-4286-4107-9e5f-08dc3f54933c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 09:46:06.0914 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z7AFVhJXGI6s8zr8ZxJ9VlsWXWA0HTGwyU9yLL6Mn9p1f2xfGhSvnYuLimC2QpfW X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5797 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 3/8/2024 3:11 AM, Chaoyong He wrote: > From: Zerun Fu > > The previous logic did not distinguish the firmware type when > reading the value of "app_cap" during the initialization of the > PF. This operation is not supported by the flower firmware, and > this will lead to a startup failure. > Fix this by adding the logic to check the firmware type. > > Fixes: c7a6970fc637 ("net/nfp: notify BSP if FW speed needs to be switched") > Cc: stable@dpdk.org > > Signed-off-by: Zerun Fu > Reviewed-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang > Applied to dpdk-next-net/main, thanks.