From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F124F45903 for ; Wed, 4 Sep 2024 16:31:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAC194025A; Wed, 4 Sep 2024 16:31:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CD93C4014F for ; Wed, 4 Sep 2024 16:31:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725460264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=R78PwlQbm5xVjVezFuI/D1O3qu1YGEqjDgTpJEieWes=; b=JzlyEJSE6Fl5yO/OfAlgSQF9YwW3I8PTrXZb5G2LmLMkZk02to7chK0zsBavlj4x6XWsOu RzJLksu3hT7HSQIXjg7awifng2aOwuuegh38oaEw2AMxQzF6kpMQKjast2Iy5DdKa+aAcN /t+rvwZa7XsreFs6U2M5yKEUies9buA= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-gnhHpMrTPweWyHjDZTD55A-1; Wed, 04 Sep 2024 10:31:03 -0400 X-MC-Unique: gnhHpMrTPweWyHjDZTD55A-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-5c25e0a50bfso613421a12.0 for ; Wed, 04 Sep 2024 07:31:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725460262; x=1726065062; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R78PwlQbm5xVjVezFuI/D1O3qu1YGEqjDgTpJEieWes=; b=rQC33OFEwHsTZOG7FHY1bixfobqYk8FAOD9nuR66UvSwEWa9UrI9Ug5i6GV7XqHdtq c9ApGZBbqHimkIs05naYdL7koYu+l0MFCEZqTMsCZ1w0DWIsM948yo6GB2OQ7fA7dpn3 Nug/pfV7hbxIXy9MDyQOPRGY3+dhB9HDeR514Si9+x+lLywF+iydZm36KPR/xKwRIDwq c9avg4ohzyuzrSXyRmPJrgYjwBaDtixgxGv/3omgQHCJ4WwGQ3Kpc2HZv10L6fUujaot xnVgeexqUu9puyMwaXIE2ZHmv57sHG+apbK4+wBioWLsRFkD9i+VoCFcD1x8ffKL7Qv+ pOmA== X-Forwarded-Encrypted: i=1; AJvYcCWEp5NVKYcOuZ9EgNRrJSxOwVsRMsDYXX48FDaNKdlteN/LZqlnMtLNK8nhfxXEgBfsOHfCsh8=@dpdk.org X-Gm-Message-State: AOJu0YxxTPNoouqAW7mZXSRHJjTSL2lH56jRS6HG9FxLLQOlVmGAuQJM ZMKg0tpUA9tp6Gt+j3vcfOxTgTR99/lImKwsaBu8az+zJd1FCoQpwSbgUOamm4/HikqZ1kb+spR H3YrN6ozpahzWzEULJITIEyIqKSp+8gSxJh3XpVmVZ3fW+mUC/YQU X-Received: by 2002:a05:6402:42cd:b0:5b8:d362:3f46 with SMTP id 4fb4d7f45d1cf-5c2caf33337mr2293176a12.35.1725460261771; Wed, 04 Sep 2024 07:31:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG046vCkiksgf31lyppnN05FDGO5AzwQhNK/O/aI6mb3NdiBvly82mrSwEYmzjFVUP9ZwLR8Q== X-Received: by 2002:a05:6402:42cd:b0:5b8:d362:3f46 with SMTP id 4fb4d7f45d1cf-5c2caf33337mr2293152a12.35.1725460261349; Wed, 04 Sep 2024 07:31:01 -0700 (PDT) Received: from [192.168.0.36] ([78.19.103.36]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c226ce4e37sm8056430a12.81.2024.09.04.07.30.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 07:30:59 -0700 (PDT) Message-ID: <3b0c2676-b856-405c-856d-b152096f9102@redhat.com> Date: Wed, 4 Sep 2024 15:30:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 21.11] net: fix outer UDP checksum in Intel prepare helper To: David Marchand , stable@dpdk.org Cc: Ali Alnubani References: <20240829112150.2317735-1-david.marchand@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <20240829112150.2317735-1-david.marchand@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 29/08/2024 12:21, David Marchand wrote: > [ upstream commit f876dbef080932dbeb1de075d7ca3cbe2ed6d7eb ] > > Setting a pseudo header checksum in the outer UDP checksum is a Intel > (and some other vendors) requirement. > Applications (like OVS) requesting outer UDP checksum without doing this > extra setup have broken outer UDP checksums. > > Move this specific setup from testpmd to the "common" helper > rte_net_intel_cksum_flags_prepare(). > > net/hns3 can then be adjusted. > > Bugzilla ID: 1406 > Fixes: d8e5e69f3a9b ("app/testpmd: add GTP parsing and Tx checksum offload") > > Signed-off-by: David Marchand > Tested-by: Ali Alnubani > --- > app/test-pmd/csumonly.c | 7 --- > drivers/net/hns3/hns3_rxtx.c | 93 ++++++++++-------------------------- > lib/net/rte_net.h | 18 ++++++- > 3 files changed, 42 insertions(+), 76 deletions(-) > Thanks David. Applied. Kevin.