* [dpdk-stable] [PATCH] net/ice/base: fix wrong outer ipv6 ptype table @ 2020-09-06 13:01 Qi Zhang 2020-09-08 3:59 ` [dpdk-stable] [dpdk-dev] " Guo, Jia 0 siblings, 1 reply; 3+ messages in thread From: Qi Zhang @ 2020-09-06 13:01 UTC (permalink / raw) To: qiming.yang; +Cc: ting.xu, dev, Qi Zhang, stable ptype 264, 265, 266, 267, 275 is should not be set in ice_ptypes_ipv6_ofos_all. Fixes: 88824213be8a ("net/ice/base: enable RSS for PFCP/L2TP/ESP/AH") Cc: stable@dpdk.org Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> --- drivers/net/ice/base/ice_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c index 6035bdfcf..552e58f9b 100644 --- a/drivers/net/ice/base/ice_flow.c +++ b/drivers/net/ice/base/ice_flow.c @@ -278,7 +278,7 @@ static const u32 ice_ptypes_ipv6_ofos[] = { static const u32 ice_ptypes_ipv6_ofos_all[] = { 0x00000000, 0x00000000, 0x77000000, 0x10002000, 0x00000000, 0x000002AA, 0x00000000, 0x00000000, - 0x00080F00, 0x03F00000, 0x7C1F0000, 0x00000206, + 0x00000000, 0x03F00000, 0x7C1F0000, 0x00000206, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, -- 2.13.6 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ice/base: fix wrong outer ipv6 ptype table 2020-09-06 13:01 [dpdk-stable] [PATCH] net/ice/base: fix wrong outer ipv6 ptype table Qi Zhang @ 2020-09-08 3:59 ` Guo, Jia 2020-09-08 9:00 ` Zhang, Qi Z 0 siblings, 1 reply; 3+ messages in thread From: Guo, Jia @ 2020-09-08 3:59 UTC (permalink / raw) To: Zhang, Qi Z, Yang, Qiming; +Cc: Xu, Ting, dev, Zhang, Qi Z, stable > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Qi Zhang > Sent: Sunday, September 6, 2020 9:02 PM > To: Yang, Qiming <qiming.yang@intel.com> > Cc: Xu, Ting <ting.xu@intel.com>; dev@dpdk.org; Zhang, Qi Z > <qi.z.zhang@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ice/base: fix wrong outer ipv6 ptype table > > ptype 264, 265, 266, 267, 275 is should not be set in ice_ptypes_ipv6_ofos_all. > A tiny comment, "is" should be deleted, right? And I think ptype name is more readable than number when interpret the reason, you choose. After that patch is ok. Acked-by: Jeff Guo <jia.guo@intel.com> > Fixes: 88824213be8a ("net/ice/base: enable RSS for PFCP/L2TP/ESP/AH") > Cc: stable@dpdk.org > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> > --- > drivers/net/ice/base/ice_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ice/base/ice_flow.c > b/drivers/net/ice/base/ice_flow.c index 6035bdfcf..552e58f9b 100644 > --- a/drivers/net/ice/base/ice_flow.c > +++ b/drivers/net/ice/base/ice_flow.c > @@ -278,7 +278,7 @@ static const u32 ice_ptypes_ipv6_ofos[] = { static > const u32 ice_ptypes_ipv6_ofos_all[] = { > 0x00000000, 0x00000000, 0x77000000, 0x10002000, > 0x00000000, 0x000002AA, 0x00000000, 0x00000000, > - 0x00080F00, 0x03F00000, 0x7C1F0000, 0x00000206, > + 0x00000000, 0x03F00000, 0x7C1F0000, 0x00000206, > 0x00000000, 0x00000000, 0x00000000, 0x00000000, > 0x00000000, 0x00000000, 0x00000000, 0x00000000, > 0x00000000, 0x00000000, 0x00000000, 0x00000000, > -- > 2.13.6 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ice/base: fix wrong outer ipv6 ptype table 2020-09-08 3:59 ` [dpdk-stable] [dpdk-dev] " Guo, Jia @ 2020-09-08 9:00 ` Zhang, Qi Z 0 siblings, 0 replies; 3+ messages in thread From: Zhang, Qi Z @ 2020-09-08 9:00 UTC (permalink / raw) To: Guo, Jia, Yang, Qiming; +Cc: Xu, Ting, dev, stable > -----Original Message----- > From: Guo, Jia <jia.guo@intel.com> > Sent: Tuesday, September 8, 2020 11:59 AM > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming > <qiming.yang@intel.com> > Cc: Xu, Ting <ting.xu@intel.com>; dev@dpdk.org; Zhang, Qi Z > <qi.z.zhang@intel.com>; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/ice/base: fix wrong outer ipv6 ptype table > > > > -----Original Message----- > > From: dev <dev-bounces@dpdk.org> On Behalf Of Qi Zhang > > Sent: Sunday, September 6, 2020 9:02 PM > > To: Yang, Qiming <qiming.yang@intel.com> > > Cc: Xu, Ting <ting.xu@intel.com>; dev@dpdk.org; Zhang, Qi Z > > <qi.z.zhang@intel.com>; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] net/ice/base: fix wrong outer ipv6 ptype > > table > > > > ptype 264, 265, 266, 267, 275 is should not be set in > ice_ptypes_ipv6_ofos_all. > > > > A tiny comment, "is" should be deleted, right? yes > And I think ptype name is more > readable than number when interpret the reason, you choose. > After that patch is ok. These ptypes are reserved, they have no name. > > Acked-by: Jeff Guo <jia.guo@intel.com> Applied to dpdk-next-net-intel after correct the commit log. Thanks Qi ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-08 9:00 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-09-06 13:01 [dpdk-stable] [PATCH] net/ice/base: fix wrong outer ipv6 ptype table Qi Zhang 2020-09-08 3:59 ` [dpdk-stable] [dpdk-dev] " Guo, Jia 2020-09-08 9:00 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).