From: Kevin Traynor <ktraynor@redhat.com>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>, stable@dpdk.org
Cc: shirik@nvidia.com
Subject: Re: [dpdk-stable] [PATCH v2] [18.11] net/mlx5: fix xstats reset reinitialization
Date: Tue, 8 Dec 2020 13:39:10 +0000 [thread overview]
Message-ID: <3b575968-747a-7be6-e8a1-474ea7aaf0ef@redhat.com> (raw)
In-Reply-To: <1607431712-3444-1-git-send-email-viacheslavo@nvidia.com>
On 08/12/2020 12:48, Viacheslav Ovsiienko wrote:
> From: Shiri Kuzin <shirik@nvidia.com>
>
> [ upstream commit 42dcd453d9b63841a5460a6ca3872eb7648d73bd ]
>
> The mlx5_xstats_reset clears the device extended statistics.
> In this function the driver may reinitialize the structures
> that are used to read device counters.
>
> In case of reinitialization, the number of counters may
> change, which wouldn't be taken into account by the
> reset API callback and can cause a segmentation fault.
>
> This issue is fixed by allocating the counters size after
> the reinitialization.
>
> Fixes: a4193ae3bc4f ("net/mlx5: support extended statistics")
>
> Reported-by: Ralf Hoffmann <ralf.hoffmann@allegro-packets.com>
> Signed-off-by: Shiri Kuzin <shirik@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_stats.c | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2020-12-08 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 12:48 Viacheslav Ovsiienko
2020-12-08 13:39 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b575968-747a-7be6-e8a1-474ea7aaf0ef@redhat.com \
--to=ktraynor@redhat.com \
--cc=shirik@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).