From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 643BE42363 for ; Thu, 12 Oct 2023 16:50:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55DA84064C; Thu, 12 Oct 2023 16:50:08 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2042.outbound.protection.outlook.com [40.107.220.42]) by mails.dpdk.org (Postfix) with ESMTP id 1EBED4029F; Thu, 12 Oct 2023 16:50:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g3wpMXS05SuU0JbcSppKZv6TnCATbMKpOgfCbAB1nzmThvtYFUnL7i8EaAg0VeMw6uMT/BPaQafHbiRTqPHE6hwkzQmEU86pv2DU1FtidK+7AnI60sgNAwS3PJnaLKbw164vsVobyjF16gBVCKBKesqF2hzS43tb0KqbVvgaOmzqHA1XWyVTBluBuys2Y2UU6J2+i+yxarA8Hs0zC1yePDcj466fwOBVc2LFcZQUz0oFq3qCvk1plKxKj7IZ92d187703MKY/wEFGLI4/fhWbeUyYSuqltE1kIOklxbYYcuy+71LhoeRD9AKncbtvmVJQ6d6+1XjArX6uf89na5agw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WAMDXEhBXdGsMkb4CPH0X/ZUanFvkHG9EI51Z6HAyBw=; b=T5mbAhxU7V5YFnag9foFSs8aZvROA/HFdvRTtKPNzF50pE3LLi+1QDCPj1bksjeQjJbv3GQas4m1CN2hvmfasFY1NNKQ7JKUNA0qBik6OhurbGeVvy35sc53/+CwjN9as70GXyAGt4QRPRPcN8fifuUvftBS2OjYF3aa/++LxHa28sUos4G+odr+tHScE/JQPhh0oNJfl/zpBe/70Vgbft0BM/cX4EaLBwwD25nvi6h4gPMdS2EMyn2n9h56yqRoyf8shJhMSWM4h0WBO2mMW16SVSzXU6+7Ry4CONAivw8XPeS4lQzEqHMNsda/J2dQkLoweiBY3xPi/ywVMQBHgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WAMDXEhBXdGsMkb4CPH0X/ZUanFvkHG9EI51Z6HAyBw=; b=VHNC9dyfQH11XygZf9596B0cUPBYWjlisLQNFKmP/vo9AakURw+m6vLqhWz+2csUE9lPxPIUnrbvWntVexEDgC8/0BgaaUt64c6zNHxc/l3k3v3o2byuxXBh2dBW7zog7W+Rjnwram8hNgsL4/F+uX0RPVBBuKG8WecuQwa2EfU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB6946.namprd12.prod.outlook.com (2603:10b6:806:24d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Thu, 12 Oct 2023 14:50:02 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6863.032; Thu, 12 Oct 2023 14:50:02 +0000 Message-ID: <3b91bf7e-7b0d-426f-9412-78f4c0c79732@amd.com> Date: Thu, 12 Oct 2023 15:49:58 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/nfp: fix the initialization of physical representors Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, Zerun Fu , stable@dpdk.org, Long Wu , Peng Zhang References: <20231010060312.205777-1-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20231010060312.205777-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PA7P264CA0072.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2de::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB6946:EE_ X-MS-Office365-Filtering-Correlation-Id: d9d471ac-595a-42a3-d10a-08dbcb3283b4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X841nwEp/+H0Savg2F+ySr6lWtMPZtD4kaR33BF7d89YtfU/r+ka+02k8DlwEV2cl0Al9sX1RJaaxrvIQuOPqrehh1/Sjv8i1eM031ZeXgPhfFLg9B7mAf7lme962etcCUUk+8ZdEsVNZ6XRIYk6fKyayPPm6OscTLXL8tO3MAs+Jrb7sCh9SGbSSfk0kGhzPaEUk3CwqyKDM5ArmDhnOL0uVjUj7f/Bi8hjUXwWxieTLwQF3owlQdxm6c4V5QnLi4x1Unsi5EEoWDUkqC4OmB6rpPHjAwkBRPR/gACaZ++X7/L5M0bc1a2tZiUGFAgLrXZSNFvItj3+gw0PKXkBapXiCHE/sCfM84q0pfaW5MHMrmzENGyeLL68lS3ZA4Pj23arE8vm27PUe40Q2l1PyKlcr02zMROKXIUE2ogcNm8gXuk3yqEkPyE9VLGVsirLtjhRVoads3TQ1P0JH22CcWdzAo73dWpIqWhIntstJoyBO3jLc0DM8lsbBgwq29fJB/0xcg2JpwPKHJ7XAGUeNgEko7gIMVqzZJdYaaFgJ0I+Ox4RR4qJJzdXubjDh2DS5bP4uMk+ICkCF59L6HrlmX6Bg1v/T3P08WXAo8XL14YT5f8eIn1EnkHnGtv1d/UsykVAFYyvceWvAqXW1nHWYg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(136003)(346002)(396003)(366004)(376002)(230922051799003)(64100799003)(186009)(451199024)(1800799009)(26005)(2616005)(478600001)(53546011)(38100700002)(6666004)(6506007)(31686004)(6512007)(66946007)(66556008)(54906003)(66476007)(6486002)(41300700001)(5660300002)(31696002)(44832011)(8676002)(4326008)(8936002)(4744005)(316002)(2906002)(86362001)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXVFQ2RlakhOSXlIS09nZEZrNEdNMXY0eXk0WHByZE56ZENUZ2oyZmNuYXBZ?= =?utf-8?B?N0dkemF0WTB4L3YxbUlQUWZDYnNCaGRvS1BBZGlvQ2x1QW9LVm03S1ZNTkho?= =?utf-8?B?ZnhkVW1TWFdKd1VnS0NUM2N0Z05XNktveUwvUnZkYTVMejArZVBoSFpOOUFB?= =?utf-8?B?UldtMGxkUmlmMmZyWUp5VklqWEJxZWJieGRPWDAzMmVqR0JsUkR4MStXRHQ4?= =?utf-8?B?ZUJmUUdVQzRnalJNbk9JUy9GQUx2MlFWOXRjYytmQk9TZEhwMFJYbm84dWVL?= =?utf-8?B?d0ZoTjZyYWVyT1BlQnN6K1ZtYWtCMGl3c21pVEdmQ0VNNFp3UHBYY0ZyVktl?= =?utf-8?B?TjNyTXd2YzRvUlZNOVVsSGZxSitjS3hXWTlEenRqelN3ci8xTWR0TmRZOEV6?= =?utf-8?B?M21VbHpqdkJPaEhvWGl4VU92Zng3N09QU25tSmh0SFQ3THpRWU9DcnhsbUla?= =?utf-8?B?WlgveHd4bHZuY1VKQSt0Yks3SjlwTzJzcEdKbmZTa0ZQWEZsT1pGT29TUXJx?= =?utf-8?B?VkRvNVUxNTVWUSsvWVhBMTNubnBBVlcrZ3VaTGZtblYwT2lpTzluR2dCSUxm?= =?utf-8?B?dFA4MzNQeUdQQnBOdFo3T1VSZ3Jpc1pic2J5NTNSVDJvcStNUUVnQnZnNTRO?= =?utf-8?B?dTdoS0JFOVdMaFJTSmMrS3VaS2xyaW5ZdU5GUDJuZGNXeHpoczNWdFJ6MENy?= =?utf-8?B?U2FWb1hjTHZqMWI2RCtlbXVuSWNBUEZ4RXBoWEwvdFhwem9LdDI2M3NZNkFR?= =?utf-8?B?emhEL0h0ckZYZitlMTMrSTd0SGtxaFh4bm1FZjBiSjJkV0ljSmh6MmxHQ09n?= =?utf-8?B?OC9oVVNCU3RjZCtNY0VFY3d0YW02MmpBaXJ2U29JNjZqaU1OYXBoMDAzSUpP?= =?utf-8?B?MWtmRFB2SWFIMHNKbm02U0JXSWwvTFRJKzVRTkcwV3kzdHZJS3VxRTVvNXFr?= =?utf-8?B?TSt6RGxNWTRZRE1waThjck52SUYwRTNHbWN1TXhSVXE3VEc4MWo4UG5lY1NQ?= =?utf-8?B?Tk04OGlQdCtHUUYwMU9JK3FCdXJQdGJSZHRYUlEzQ2Q0NEJaalpYalBLeWFj?= =?utf-8?B?N3ZSK1B2MFJQMFFxcmlrb2kreVBnRUo5SnpKNE5WMDlmcjR0c2lmSUZrVDJu?= =?utf-8?B?czczTXU5azJENzVoZTJ1a0RjRmNrMnZNY0MwRnV2Rm5rSEpuUEN4dmJRZWhI?= =?utf-8?B?eS9GQ3Q4ZHF5WEloZDhGMVVtNWx3VWFSU05PdDBZVFlscGRlbzZRMzA5Y25k?= =?utf-8?B?OUw0dGdiL3lKNVFQZEJORlRzdFZsS2tWZ1RaYkRYbWJWZHZpZnF1dU9KNjMx?= =?utf-8?B?WXVzOXExR0gyOUcrT28xWTJkK1BBNmJJT0VaQlg5eldOWlFSK21pQytXUGI1?= =?utf-8?B?eFJsTDdRdUtXS1pFaS9FY3Y1eHFFdDdSZ3B6K21BbWpjc2dWdDlTY3VZT0RZ?= =?utf-8?B?aU9rVEphODFhWDB3ZGRpMlNjbXNKQVNDMTN4eklrSG1DSnFDQXlpSW5LYTl2?= =?utf-8?B?WDFCaVljc2xzdllQK2FlbEwzNFdWWmc4SGU5aXFVbFBFM1RDWFlJREErd0tt?= =?utf-8?B?UjBIQ0hPWkNkRE14TnB4TTBlTkRTTHQ3TGRGdXE2ZnBJVlBEOHZKclAyNFBX?= =?utf-8?B?UVpadExxNXdLRTFYaVYxUWM3UlhNWkNxdDVpVUk0eDZicU1BSW5iNFNDNEE0?= =?utf-8?B?RURyT2NRTElsL05pTjFnM0VGK0dYZ0ZBZHRiemw0bUZCOC80VXVrWkdrWFg5?= =?utf-8?B?WXhQdXlQSDhYVXMzMFhGbWowMmRMbHBaMXVFT3pWTjY3Sng5OWdCV2VaRUNy?= =?utf-8?B?bVI4ZVZ1RHVxbEJOb2xJdUp5QlUwQVZOdnFrVzdFZ2NpYUNuVFFnTUt0eldJ?= =?utf-8?B?dEFXMGhCaHJKUTFmVko5MERzWlNxdUlLYVhsRU9RaWI1YXY2NXN4bkQ5R3hX?= =?utf-8?B?NXh4SHErZnE5UjdJaFdra1VYbGQvM213ajRGdkN3eTJYcFFhbS9OWlZ2Y28w?= =?utf-8?B?THBqM1VKdlkxYmREaVE3L2ZPWlc1cjIwMXFHOGJ1d1VJQWt5VlNhK1cwZGVJ?= =?utf-8?B?RU1IL2R3eXBXaGN1dXZiYllrUTlmdEZ2bXBkdlU2LzlBOWFRWUpWNFIybU96?= =?utf-8?Q?aQIt8XiriSrSm2WIe4L4GWxyR?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9d471ac-595a-42a3-d10a-08dbcb3283b4 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 14:50:02.5647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eKuFdPJhT2hs5w8VcsAPqRt5uz7uyzU1IlVizvafBlESNIEpL+ogTfisThxGXDFd X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6946 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 10/10/2023 7:03 AM, Chaoyong He wrote: > From: Zerun Fu > > The former logic of initializing the array of physical port > representors is according to 'nfp_idx', but referencing based > on 'port_id'. This is a potential bug and will cause segment > fault when these two values are not equal. Fix it by using the > 'port_id' as index at all time. > > Fixes: e1124c4f8a45 ("net/nfp: add flower representor framework") > Cc: chaoyong.he@corigine.com > Cc: stable@dpdk.org > > Signed-off-by: Zerun Fu > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang > Reviewed-by: Chaoyong He > Applied to dpdk-next-net/main, thanks.