From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4C5041EB1 for ; Thu, 16 Mar 2023 15:10:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF69940DDC; Thu, 16 Mar 2023 15:10:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1A70042D44 for ; Thu, 16 Mar 2023 15:10:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678975823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F8agz57q9JXhWBEt1wGZHjPASJirxGNVMUrHrJHDfCY=; b=Z0gkb+LMcmzTtN4vggEAF41iEEQbDPezzoaTBQ9e2+cEG9qR3IiXun4qoc7sWXI/wuoMek 3GuPfT4RsYtxtmbaf43dyZGH2ePG+oDZsKS6LN6LxrvlTS5ilNGYYizKcIxneSl3M0lZPu Jg2rmwT7iGTbIWBaJUwK+5oer8O8sMo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-401-d0PGfbxmMT-Z2fTeQz7a7A-1; Thu, 16 Mar 2023 10:10:21 -0400 X-MC-Unique: d0PGfbxmMT-Z2fTeQz7a7A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A2683185A7A4; Thu, 16 Mar 2023 14:10:20 +0000 (UTC) Received: from [10.39.208.23] (unknown [10.39.208.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 08F441410F1B; Thu, 16 Mar 2023 14:10:18 +0000 (UTC) Message-ID: <3c1f01cd-8328-e103-e6a0-7a3dc21eaaee@redhat.com> Date: Thu, 16 Mar 2023 15:10:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 2/2] test/bbdev: fix unchecked ret value issue To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, john.mcnamara@intel.com, stable@dpdk.org References: <20230309033624.61660-1-hernan.vargas@intel.com> <20230309033624.61660-3-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230309033624.61660-3-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 3/9/23 04:36, Hernan Vargas wrote: > Add check for return value from get_bbdev_queue_stats. > > Coverity issue: 383155 > Fixes: c25604355a15 ("app/bbdev: add explicit check for counters") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas > --- > app/test-bbdev/test_bbdev_perf.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index 15ebcdfc1556..276bbf0a2e6d 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -5679,7 +5679,7 @@ static int > offload_cost_test(struct active_device *ad, > struct test_op_params *op_params) > { > - int iter; > + int iter, ret; > uint16_t burst_sz = op_params->burst_sz; > const uint16_t num_to_process = op_params->num_to_process; > const enum rte_bbdev_op_type op_type = test_vector.op_type; > @@ -5774,7 +5774,10 @@ offload_cost_test(struct active_device *ad, > rte_get_tsc_hz()); > > struct rte_bbdev_stats stats = {0}; > - get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); > + ret = get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); > + TEST_ASSERT_SUCCESS(ret, > + "Failed to get stats for queue (%u) of device (%u)", > + queue_id, ad->dev_id); > if (stats.enqueue_warn_count > 0) > printf("Warning reported on the queue : %10"PRIu64"\n", > stats.enqueue_warn_count); Reviewed-by: Maxime Coquelin Thanks, Maxime