* [dpdk-stable] [PATCH 1/5] net/mlx5: fix parser inner value [not found] <cover.1509464921.git.nelio.laranjeiro@6wind.com> @ 2017-10-31 15:51 ` Nelio Laranjeiro 2017-10-31 23:46 ` Yongseok Koh 2017-10-31 15:51 ` [dpdk-stable] [PATCH 2/5] net/mlx5: fix flows when VXLAN tunnel is 0 Nelio Laranjeiro 1 sibling, 1 reply; 4+ messages in thread From: Nelio Laranjeiro @ 2017-10-31 15:51 UTC (permalink / raw) To: dev; +Cc: Yongseok Koh, Adrien Mazarguil, stable In validate() it sets the value to 1 whereas the expected one is IBV_FLOW_SPEC_INNER. Fixes: c2c6ddd51da4 ("net/mlx5: limit flow API rules to one tunnel") Cc: stable@dpdk.org Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 3eb84e2a4..68cc8bff5 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -866,7 +866,7 @@ priv_flow_convert_items_validate(struct priv *priv, " VXLAN encapsulations"); return -rte_errno; } - parser->inner = 1; + parser->inner = IBV_FLOW_SPEC_INNER; } if (parser->drop) { parser->drop_q.offset += cur_item->dst_sz; -- 2.11.0 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH 1/5] net/mlx5: fix parser inner value 2017-10-31 15:51 ` [dpdk-stable] [PATCH 1/5] net/mlx5: fix parser inner value Nelio Laranjeiro @ 2017-10-31 23:46 ` Yongseok Koh 0 siblings, 0 replies; 4+ messages in thread From: Yongseok Koh @ 2017-10-31 23:46 UTC (permalink / raw) To: Nélio Laranjeiro; +Cc: dev, Adrien Mazarguil, stable > On Oct 31, 2017, at 8:51 AM, Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote: > > In validate() it sets the value to 1 whereas the expected one is > IBV_FLOW_SPEC_INNER. > > Fixes: c2c6ddd51da4 ("net/mlx5: limit flow API rules to one tunnel") > Cc: stable@dpdk.org > > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > --- Acked-by: Yongseok Koh <yskoh@mellanox.com> Thanks ^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH 2/5] net/mlx5: fix flows when VXLAN tunnel is 0 [not found] <cover.1509464921.git.nelio.laranjeiro@6wind.com> 2017-10-31 15:51 ` [dpdk-stable] [PATCH 1/5] net/mlx5: fix parser inner value Nelio Laranjeiro @ 2017-10-31 15:51 ` Nelio Laranjeiro 2017-11-01 18:56 ` Yongseok Koh 1 sibling, 1 reply; 4+ messages in thread From: Nelio Laranjeiro @ 2017-10-31 15:51 UTC (permalink / raw) To: dev; +Cc: Yongseok Koh, Adrien Mazarguil, stable Fix a strange behavior from the NIC, when the flow starts with a VXLAN layer with a VNI equals to zero all the traffic will match within this rule. Fixes: 2e709b6aa0f5 ("net/mlx5: support VXLAN flow item") Cc: stable@dpdk.org Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> --- doc/guides/nics/mlx5.rst | 2 ++ drivers/net/mlx5/mlx5_flow.c | 12 +++++++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index cdb880a4c..19da9f1ed 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -129,6 +129,8 @@ Limitations is set to multi-packet send or Enhanced multi-packet send. Otherwise it must have less than 50 segments. - Count action for RTE flow is only supported in Mellanox OFED 4.2. +- Flows with a VXLAN Network Identifier equal (or ends to be equal) + to 0 are not supported. Configuration ------------- diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 68cc8bff5..a7864871c 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -1158,7 +1158,7 @@ priv_flow_convert(struct priv *priv, cur_item->mask), parser); if (ret) { - rte_flow_error_set(error, ENOTSUP, + rte_flow_error_set(error, ret, RTE_FLOW_ERROR_TYPE_ITEM, items, "item not supported"); goto exit_free; @@ -1605,6 +1605,16 @@ mlx5_flow_create_vxlan(const struct rte_flow_item *item, /* Remove unwanted bits from values. */ vxlan.val.tunnel_id &= vxlan.mask.tunnel_id; } + /* + * Tunnel id 0 is equivalent as not adding a VXLAN layer, if only this + * layer is defined in the Verbs specification it is interpreted as + * wildcard and all packets will match this rule, if it follows a full + * stack layer (ex: eth / ipv4 / udp), all packets matching the layers + * before will also match this rule. + * To avoid such situation, VNI 0 is currently refused. + */ + if (!vxlan.val.tunnel_id) + return EINVAL; mlx5_flow_create_copy(parser, &vxlan, size); return 0; } -- 2.11.0 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH 2/5] net/mlx5: fix flows when VXLAN tunnel is 0 2017-10-31 15:51 ` [dpdk-stable] [PATCH 2/5] net/mlx5: fix flows when VXLAN tunnel is 0 Nelio Laranjeiro @ 2017-11-01 18:56 ` Yongseok Koh 0 siblings, 0 replies; 4+ messages in thread From: Yongseok Koh @ 2017-11-01 18:56 UTC (permalink / raw) To: Nélio Laranjeiro; +Cc: dev, Adrien Mazarguil, stable > On Oct 31, 2017, at 8:51 AM, Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote: > > Fix a strange behavior from the NIC, when the flow starts with a VXLAN > layer with a VNI equals to zero all the traffic will match within this > rule. > > Fixes: 2e709b6aa0f5 ("net/mlx5: support VXLAN flow item") > Cc: stable@dpdk.org > > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > --- Acked-by: Yongseok Koh <yskoh@mellanox.com> Thanks ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-01 18:56 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <cover.1509464921.git.nelio.laranjeiro@6wind.com> 2017-10-31 15:51 ` [dpdk-stable] [PATCH 1/5] net/mlx5: fix parser inner value Nelio Laranjeiro 2017-10-31 23:46 ` Yongseok Koh 2017-10-31 15:51 ` [dpdk-stable] [PATCH 2/5] net/mlx5: fix flows when VXLAN tunnel is 0 Nelio Laranjeiro 2017-11-01 18:56 ` Yongseok Koh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).