From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B18242B25 for ; Tue, 16 May 2023 16:20:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A624442BDA; Tue, 16 May 2023 16:20:24 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 1728B410EE; Tue, 16 May 2023 16:20:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684246821; x=1715782821; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=6TR4iYNDaygFCPeEPQUAIf+8kgsY8y6nzQnSwWutj/4=; b=exyyL7fUnB9lMufC5co1QBW6IFmLsSGFa5gdpS9+mzdp7INOJWLHr6k3 0KYJTq9x3KWWBQN2GuaThoBVEu1E5V8WI+mM34QH6iEbyduWtz357GAJL SrvyAYNR5lALj9nT0VzpvI18S4OJ1lUToP83/DmL33WoCwxSvzy9Blbbk Kf25aKSjIaH58AQ6BnHRfIaIbZ5VFnQ1zjIeV51tbVefMKrELpeBwylhT QHyOhGEtJ+v6Oy0F7ph2Z5BAzH1vOidpEAQFdsIjurUB0W0CNysqB7b6D ahbkVX2EsEbf90tiEK3Z9Qh6B2rPcqBzpmW0WF2wXkrzYZo/xqQSFJ530 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="340856738" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="340856738" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 07:20:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="771079895" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="771079895" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 16 May 2023 07:20:19 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 07:20:19 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 07:20:19 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 16 May 2023 07:20:19 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 16 May 2023 07:20:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SdqG8u8e8uqynVWTwlvzIeohGkIuVhRIYCZg5Z9MsWmEk8cscERo8l/+d4u0eLhhw0qtpVi5KAn8i5Zpeb/QGUiTB6mInsLU58bfxb+fA1S8cNIpVWUvumDwy5CgVwziFQ0ngcMgntoCldHz5Shoy8xtc7te0J/rF6Ct/5e7L/cedqLdKel6xNYQ7wMJ+k/pK4Q+sznXwGJTKNEJndTTqNEoWHlzyCKtESUplsXgAdkfMnzQvDk95OEhjaTbJEGj4Pc7muPg+VUfQXBmJOVfcXmprLpNaMDwbdGN4UHxZ7CNAVAuHFYocKQKEwQzeIBXdDWkpqe695/E8ybZrlOAUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r7qW43yQXfOCwQn7U8Wmf99QTRGTMIxXtnXL+dEHFcU=; b=XwpBn681rivZaoEixQYxMqMiulyLVzE3c9aZuRoWUP8m67MIAYVIXrHqTUybXILRnyA2x7GCQOlXxqn68rXFhNuIHwpnPUHSWFfeA+ZeruQu56yZaeXndmd6u14Lq9iZugx6f3jh/rTC/ZFViMt38BU2ucZq64JWjMSjRY1tqKwZL485kbl3HYuyIdpU6l1F51oEwECEpKNENU8h18vmMmsn9x42fbCVs5M9u2kb2OIJB5+qg1x9ufx/BP1oSXYAeS+rtLBD3GUN2pVjxVJrCixLVGGW4JzxBXE7sYmDJZ97AG0z7KdJqQJ2UCQICbwX2WeMFHDUU7yC672GeC0sNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by CY8PR11MB7267.namprd11.prod.outlook.com (2603:10b6:930:9a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Tue, 16 May 2023 14:20:18 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718%5]) with mapi id 15.20.6387.033; Tue, 16 May 2023 14:20:17 +0000 Message-ID: <3d6b794c-06ae-190d-1e1e-ed7bc8909b51@intel.com> Date: Tue, 16 May 2023 15:20:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.0 Subject: Re: [PATCH 2/2] Memory Allocation: Fixes ms_idx jump (lookbehind) during find_prev_n() in fb_array library Content-Language: en-US To: Vipin P R CC: , References: <1673615325-20624-1-git-send-email-vipinp@vmware.com> <1673615325-20624-3-git-send-email-vipinp@vmware.com> From: "Burakov, Anatoly" In-Reply-To: <1673615325-20624-3-git-send-email-vipinp@vmware.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0173.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::18) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|CY8PR11MB7267:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f6b9ed1-c2ac-4870-4a54-08db5618ac61 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VWylcjGzqsZytj2jNJPrH3wZtS+oWzKACR6egc/zdP11CGuydMIFCkBIXpVPaKtoqHPqsTPohKrlVonZWilo5Ho+6IMubL9ISnljQhSZndC4zVkTlQ+zV6plzfpxWG8JE7MoMuuJbivKGkKyTFKrEuEJXlKk0dtP1h8J4NSyPEW7Lssk6Fmlua7w1StWjEvcreYksCMyItbJlfEMrPx7Vc7I78iYArRFxggRpITeoY+0xB/pXMI8LrdZfzUl26wVHVz34l/4rtTy1vZSEuJzf6/HLoju8lfA6+echPLxldQR5OuMh+wAuAZ3Kste3E0w9a1PyQYgcP3hoXTzOEqf4Fjd4lWEm6DySBL8K7/hi0m7Migxh5QMpt0SvY3iFLrAdNVcFLI7SzefqP4t0NAismd2aHE8pFrRJJ4B/HbQQ3b/+B/09c3jZl+HXhda2+zFZoL9QGAaTd4Xy9BEDHpJkJnZNDX5MY1vlL4RL+Ey7idECAh7MY9HI7XaHqVfhwcjvvpPZ3GBUNkVLHpUKfs+NZlt8Xnr68jIg1bI66aXVNlJLa6Z3cnWTzYHrGWLJ7bAEgOLGYco1FrEvy8xmjONJnipHpwwXYKTh1bLxF3J+KkdlaUTOIxAqyUHkDZPtHA2ENXDGR5To47jbPBkmTHD0Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(376002)(136003)(366004)(346002)(396003)(451199021)(6486002)(36756003)(83380400001)(6666004)(478600001)(2616005)(53546011)(26005)(6506007)(6512007)(186003)(2906002)(31696002)(4326008)(38100700002)(6916009)(66946007)(66476007)(66556008)(82960400001)(41300700001)(8676002)(8936002)(5660300002)(316002)(86362001)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0ZoTVJRTkgySWRQdWpQZWRmZjh4K0ltUWsxV0l1VGpiWnpPRzlhc0lPRzM0?= =?utf-8?B?Q3paWHAzYnhNUzlmYmVRTlltR3hYQkFMaUxFUGFXcEZtWWg2U01VQXZPT1V1?= =?utf-8?B?RnVzS0Y5bkVOcHk2eFAvcGt6M0diSUR2ZVJ5RmZvd25jOWpIOGhrNk81cEI3?= =?utf-8?B?cWx2bmw1Tmt5M0ovWWdLU2FXQmtIVGxQbllHbW5FbUU2bWpWWjBkaURYakt0?= =?utf-8?B?dUd4d3phVUhtWkszcmhnaXUvTFBmODlpbHJEY2lPYitWN1pWQjQwaHBnYzhv?= =?utf-8?B?OWVrL3l2VmlLZmFFb0tMdG0wQkd6U2pxY0l3TGRvYXBhdEdKSlRYNEZ0ZnNa?= =?utf-8?B?dUVYdHpqSEJucmRad3hXeTlIcXBrQUJDbFgyT0xyUGdFU0hueUU0K0cyU05j?= =?utf-8?B?aWlnQnNqRGpqWmJCQnhrZ3ZHd2p3OC9iczNJcTEyU1EzTm9YRFhJZi90VUFQ?= =?utf-8?B?VW5WanFINHpPYzd2RkZoS2xjKzZTaWVvMVlLUEMvZ2xoRFJrWCtXOEVnb3RB?= =?utf-8?B?OE0zMDg3Yzd6d0NLc1RoVkVIamF6WC96NGRxYk1WbkpkUWl2S0NMc2gxQjdk?= =?utf-8?B?K0NYSGZUcXZwa0lZL1dab0ZNL3UyRkNPTW1HN1pXL2pRUThJaGdCRk9MQWl4?= =?utf-8?B?aTMvZlZyVFI0L3MwdjYrVE8vbkNjaHM0ZVFLY2lKUG5KV2EvakpYZkU2NEJI?= =?utf-8?B?a0VyNlBUaEZmaUdjZGpUK0tyUHd1S0l0SlBaU29kQnZpdjRhYXFXU041cENs?= =?utf-8?B?YTlIUmNpUlJSM1FtZmJwc011QWpBejVFOXR2MVA1bFZLOGkxYk43UHd5YkRQ?= =?utf-8?B?QjZGV0VFWWpQaWRTMTJXQ2MwV0xmdGJIV0paZGx0SStDLy9PRW11eWJMZUxQ?= =?utf-8?B?MENselZ1YkZsMTNJWGVDd3ZkRnpPVmpDcHQzWlJ6VWw4RnNwUGIrWDVOMjRM?= =?utf-8?B?bjhIMHNUVVg4bzVqeFVTanE4U01MaVhuZllpcld0bWlBRVREcE1wSWRnVXhD?= =?utf-8?B?aTJ5ay96d1E3eHZTVXFBd2VJQlRic3crSUZULzBBK0J3NlRGOUZlU0todEZO?= =?utf-8?B?YkM5cW53ZnZPM2hDYjhoSDduZVhoWGtXOXpyZ1c5WUpUMnlEejA1K3RYR2Vo?= =?utf-8?B?by82N3dDK2wrcVkwbDYwVDJrTU84YzRyRFIzSGtNVXhCeVJwcysyVGFWNGZv?= =?utf-8?B?Z2ErWXhBNDRpTFdmVXVITGNRMTFNWW1tZFRqaDFXeGpUNXYzSGhjaTVCUkp5?= =?utf-8?B?NW1vV0cyR2FEQTRmY3hCanEva1dRTllhSGNsTHVsSVA2SlBHMm5tNDFPWmFV?= =?utf-8?B?cGZ5UCtwVDBGWm5zc0FtdUJlcFk4NXFEZ09wdnJJeUdWV2pDK0pwdnM5cHhK?= =?utf-8?B?NVNVMDdpb2tRZHgvc3lBMjA4cGhrNFVWaE9MNEhGeDZadU4vcVkwTmJBSkZy?= =?utf-8?B?elJJYnp1Si9QVndHclFhdWFta0NCcjdvWkhGSi9OTFRuQ1BoM2RWcFphTTZK?= =?utf-8?B?WS94ZGZwS2ZZYklzcFI1eEMrV054c054clh4azlXREQ3N05GdVRaQ1JjSy9D?= =?utf-8?B?UmtkWjMwYm9Pb083MjVRNkJTUHdZRmZKb1JZWmpFLyt5STFqTTRzQVByUWVF?= =?utf-8?B?MnRDM3c0VFVKZ2lJVkhKMXN6NUNEdVFrYUozbkxLVVFFSHlPLzVmWW1LRHhP?= =?utf-8?B?dCtQc0MxOWRtZWVVYWl5OEptRlZCMlNYb1FnaUJvY3ErU0NCYVdqci94ZDBx?= =?utf-8?B?NTZtbDhuOUROQkIzcWVmOEhwVlQ2M3VTRFdJeUM5aWdWWVlMZ1hESTU2aGty?= =?utf-8?B?K0RQR0NSaDF4QW5QWmhsQVdmRVFuaGlCYWlLMzVFdklxYVdtQ0RuRkcvZmFv?= =?utf-8?B?dmVhRlk5eTM2NksrTXFrUG5ub3JOQlNXZmNvcnRKUzliTnZyYW5BK0duWE5D?= =?utf-8?B?SmhuUmRTU0ozcDlvMTNLbWs3N1JkMVJEa3htSTlQMXNvTnN4OHJ5R2FNdm5G?= =?utf-8?B?TzhySkJ6ampGL1BJaWYzU1FEdC9vbE1BWHlGY3dhcEMxS2Zzc25sbWhQWW9R?= =?utf-8?B?Q05RT21XRmJUVkQ3OGo0N3Y2OWdPWVVJSmFraHNYYkZOYmNUV0thbjNjZlJo?= =?utf-8?B?K2twcS9GcWM5R0hINHVkOGcrMVBxK3FBakZWRFN1M1lnbUlXaDZ2TUdybm9w?= =?utf-8?B?OGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3f6b9ed1-c2ac-4870-4a54-08db5618ac61 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 14:20:17.5955 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bMVsBApgJTWczF9h+5HjHzqOFI/9RLuOZ8Pktx945SQJ50BJk4Z+gMq1vgjR6RgFUI/K4zMmZZIF8YM/R4ibx6u7dzGzcO+1nLmxTvbnQB0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7267 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Vipin, This commit should include a more detailed commit message, akin to one I suggested for the first patch. For the patch itself: Reviewed-by: Anatoly Burakov On 1/13/2023 1:08 PM, Vipin P R wrote: > Cc: stable@dpdk.org > > Signed-off-by: Vipin P R > Acked-by: Kumara Parameshwaran > --- > lib/eal/common/eal_common_fbarray.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/eal/common/eal_common_fbarray.c b/lib/eal/common/eal_common_fbarray.c > index 551bd87..90240e8 100644 > --- a/lib/eal/common/eal_common_fbarray.c > +++ b/lib/eal/common/eal_common_fbarray.c > @@ -511,7 +511,7 @@ find_prev_n(const struct rte_fbarray *arr, unsigned int start, unsigned int n, > * as well, so skip that on next iteration. > */ > ignore_msk = UINT64_MAX << need; > - msk_idx = lookbehind_idx; > + msk_idx = lookbehind_idx + 1; > break; > } > The unit test code you suggested does not cover this case. I've reduced this bug to a minimal test case: 1. Allocate fbarray with 256 entries 2. Set idx 63 as used 3. Call rte_fbarray_find_prev_n_free() starting with index 64 and length of 2 Returned value should be 61, but without the fix it returns -1. -- Thanks, Anatoly