From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E8E641C3D for ; Wed, 8 Feb 2023 11:52:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45DC34014F; Wed, 8 Feb 2023 11:52:52 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E9C6C40141 for ; Wed, 8 Feb 2023 11:52:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675853570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yGXAK+OGDFhJn9JcEnPHR3MAcnwyirQpkjzTPqtaZYg=; b=QBif7NesjyyCWsF5CSgx2J8PwAgdD754bpnukjMU+bbispiWhlqkn2gl6/CcWdj7O/nXST lF6TPTunRBAFuiDGBv5G3uVwrVdJJFts+HITLm9ZGC4tp6b8gzS0kOEMESiGHkD5VUC6T2 tz4fLMPIDgtDL0TnvtdpDESH2wexM9w= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-393-dSXCOvTzOQyziMdl2p5rKA-1; Wed, 08 Feb 2023 05:52:49 -0500 X-MC-Unique: dSXCOvTzOQyziMdl2p5rKA-1 Received: by mail-wm1-f69.google.com with SMTP id h9-20020a1ccc09000000b003db1c488826so953890wmb.3 for ; Wed, 08 Feb 2023 02:52:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:cc:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yGXAK+OGDFhJn9JcEnPHR3MAcnwyirQpkjzTPqtaZYg=; b=nhxKUmGTrKmvY+dpTas1qInnsK/f7CTyfiYxEosGpU8M8tyi2e0wZVdlgsDsZ78fSA OMOs7Etfj0CSkmWs80/ThyMXY8fHjTGHg+GoyLc2O0a6XT5YwBwS/e0Rn+W8kJB3z8V6 jpJV5jd4RA6Pj5UVgJIxhghogOu6utL3WaWtSO4qSkoztKgy8tJ0MqlpfQDWxG1j/caH Qpp8xTPpt8KDRuIVrtUx4DE7Dwig1xsNo1VzCQRqiOE2ARyEMQCJumfbHXpg15QK+Rhz 9GNWQb67htZL/dReIBlztWtMUxsNCRT7l+dRxdOmCCqaP1mZuJDtFosGMB8WVt5yLtV4 E4cg== X-Gm-Message-State: AO0yUKXhMnYIQJ7w7lScd1r7NuYRaG0bcBEPmECl9XvegREwVzZ1XoNI 3vGIXgO5iY2rTgrR5BT+kqIp45jPpZyDvd8UTsNmOsAWhuXgdML6uVzq/aRXLKkH/d+RqCLWbbs DlJjo2LI= X-Received: by 2002:a5d:6842:0:b0:2c3:e76e:3115 with SMTP id o2-20020a5d6842000000b002c3e76e3115mr6141030wrw.45.1675853568256; Wed, 08 Feb 2023 02:52:48 -0800 (PST) X-Google-Smtp-Source: AK7set+nVkvd0gRvf/Dx55gLAYwkZDJFz+hiSOyPD36bE98Ns+48gpxkWBEKQjFGk3SNT35t7SSIGg== X-Received: by 2002:a5d:6842:0:b0:2c3:e76e:3115 with SMTP id o2-20020a5d6842000000b002c3e76e3115mr6141011wrw.45.1675853568050; Wed, 08 Feb 2023 02:52:48 -0800 (PST) Received: from [192.168.0.36] ([78.16.251.63]) by smtp.gmail.com with ESMTPSA id r15-20020a5d694f000000b002c3e1e6eda0sm9865563wrw.99.2023.02.08.02.52.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 02:52:47 -0800 (PST) Message-ID: <3ddb871c-673e-50a7-c94c-0d726f0ef8dd@redhat.com> Date: Wed, 8 Feb 2023 10:52:46 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 To: Ke Zhang , stable@dpdk.org, wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, Christian Ehrhardt References: <20230208054518.159406-1-ke1x.zhang@intel.com> From: Kevin Traynor Cc: "Xueming(Steven) Li" , Luca Boccassi Subject: Re: [PATCH 19.11.14-rc1 LTS] app/testpmd: fix compile error In-Reply-To: <20230208054518.159406-1-ke1x.zhang@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 08/02/2023 05:45, Ke Zhang wrote: > [ upstream commit f99f2e55af7a49a6ee6555a5554847094086017f] > Hi, DPDK 19.11 LTS is EOL. Please see: https://core.dpdk.org/roadmap/#stable For reference, the named commit does not exist in dpdk main. It looks like the patch is a rebase of: commit 2809981e858f5cfa3ea9182e400a2c67f7c4744d Author: David Marchand Date: Fri Nov 18 09:53:10 2022 +0100 app/testpmd: fix build with clang 15 in flow code This variable is not used and has been copy/pasted in a lot of other code. Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") > variable 'c' is set but not used, it should be cleard. > > Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") > > Signed-off-by: Ke Zhang > --- > app/test-pmd/config.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 9f96e77ba3..a04ce0ec64 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1457,7 +1457,6 @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule) > { > struct rte_port *port; > struct port_flow **tmp; > - uint32_t c = 0; > int ret = 0; > > if (port_id_is_invalid(port_id, ENABLED_WARN) || > @@ -1490,7 +1489,6 @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule) > } > if (i == n) > tmp = &(*tmp)->next; > - ++c; > } > return ret; > }