From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DFC7A0613 for ; Wed, 25 Sep 2019 20:03:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2BA559E4; Wed, 25 Sep 2019 20:03:14 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 65AFF9E4 for ; Wed, 25 Sep 2019 20:03:13 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id h7so8004508wrw.8 for ; Wed, 25 Sep 2019 11:03:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=w1IKRAOgYQ8j/ga9o2llAYpRZnlelQFBGGl2oZUbSPo=; b=Ua4Sfib5gl+vV3xoNMBRF03GWPYZucL+9H0e1KdO4QanowqAHuAmn0MCm+lJOhGngp ZSAwxrGJo3IpETrhLzw7HnkeqFA+kgss6xE/Y8IFvY+CzjXyxiF0ENT5aBEoM9rfZOou TGQuQoW9QHM6gszrY0bIk3dO0187qfRBLFbCd6eNbY6u7nRn0qQL9cDVuEVUEKgu55jI b9DA2u942yT6lX+ggHCL4nMp+K6sUp/Qs/4nV08JQ8OVzyYaYANIGTvlj1m3w6+pjd3+ oLzicwq80Ugb3Ffh6w5ntb+WYEUjumkZlgJ5nxqNbZWhBldAetjoZ23qyTN+N89NIWic hiwQ== X-Gm-Message-State: APjAAAUP+Pjc9KWlp62DSdx1sLTRHRj0p6KmoHA5aWuVl+vCSvOVjlks b0gBiPy20ZAwpDwfAbCsmGyIyZSAbiE= X-Google-Smtp-Source: APXvYqzDyecEO3pUV2HAQXGA00lcQujQD644bEz0xTOzfIojqI0EbvSpJIuTVB7/ae+IbWI877XUqQ== X-Received: by 2002:adf:e485:: with SMTP id i5mr10948823wrm.175.1569434592980; Wed, 25 Sep 2019 11:03:12 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3]) by smtp.gmail.com with ESMTPSA id o188sm9846196wma.14.2019.09.25.11.03.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2019 11:03:12 -0700 (PDT) Message-ID: <3f956f877cda255b2b69e52bc0dd41c183eb1338.camel@debian.org> From: Luca Boccassi To: Kevin Traynor , stable@dpdk.org Date: Wed, 25 Sep 2019 19:03:11 +0100 In-Reply-To: <20190925171242.8005-2-ktraynor@redhat.com> References: <20190925171242.8005-1-ktraynor@redhat.com> <20190925171242.8005-2-ktraynor@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 18.11 1/1] build: enable BSD features visibility for FreeBSD X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, 2019-09-25 at 18:12 +0100, Kevin Traynor wrote: > From: Marcin Smoczynski < > marcinx.smoczynski@intel.com > > >=20 > [ upstream commit 28188cee2aa0b72d401d3e56942d0db9c7b9e654] >=20 > When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro > explicitly in its build recipe, it restricts visibility of a non > POSIX > features subset, such as IANA protocol numbers (IPPROTO_* macros). > Non standard features are enabled by default for DPDK both for Linux > thanks to _GNU_SOURCE and for FreeBSD thanks to __BSD_VISIBLE. > However > using XOPEN_SOURCE or POSIX_(C_)SOURCE in a component causes > __BSD_VISIBLE to be defined to 0 for FreeBSD, causing different > feature > sets visibility for Linux and FreeBSD. It restricts from using > IPPROTO > macros in public headers, such as rte_ip.h, despite the fact they are > already widely used in sources. >=20 > Add __BSD_VISIBLE macro specified unconditionally for FreeBSD targets > which enforces feature sets visibility unification between Linux and > FreeBSD. >=20 > Add single -D_GNU_SOURCE to config/meson.build as a project argument > instead of adding separate directive for each project subtree. >=20 > This patch solves the problem of build breaks for [1] on FreeBSD [2] > following the discussion [3]. >=20 > [1]=20 > https://mails.dpdk.org/archives/dev/2019-May/131885.html >=20 > [2]=20 > http://mails.dpdk.org/archives/test-report/2019-May/082263.html >=20 > [3]=20 > https://mails.dpdk.org/archives/dev/2019-May/132110.html >=20 >=20 > [18.11] > The following 18.11 branch commit needs __BSD_VISIBLE to be defined, > so backporting this commit to 18.11 branch. >=20 > Fixes: 54e4657b2385 ("net: define IPv4 IHL and VHL") >=20 > Signed-off-by: Marcin Smoczynski < > marcinx.smoczynski@intel.com > > > Acked-by: Konstantin Ananyev < > konstantin.ananyev@intel.com > > > --- > app/meson.build | 3 --- > config/meson.build | 8 ++++++++ > drivers/meson.build | 3 --- > examples/meson.build | 3 --- > lib/meson.build | 3 --- > meson.build | 6 +++++- > mk/target/generic/rte.vars.mk | 5 +++++ > 7 files changed, 18 insertions(+), 13 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi