From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Timothy Redaelli <tredaelli@redhat.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Cc: bruce.richardson@intel.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 0/2] Fix shared lib detection on Fedora/CentOS/RHEL
Date: Wed, 25 Nov 2020 11:57:45 +0100 [thread overview]
Message-ID: <3fa7388d-4bcf-fd01-0aa4-cb9effee5a65@redhat.com> (raw)
In-Reply-To: <cover.1606229937.git.tredaelli@redhat.com>
On 11/24/20 4:14 PM, Timothy Redaelli wrote:
> Currently eal only tries to find shared lib by looking for .so files,
> but on Fedora, CentOS and RHEL the .so file is not installed by dpdk
> package, but it's only installed by dpdk-devel package, since .so files
> should not be necessary in order to run a program [1].
>
> This series fix that by checking for .so.ABI_VERSION that should be
> available on any linux distribution.
>
> [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
>
> Timothy Redaelli (2):
> eal: fix shared lib mode detection
> eal: fix loading of shared libs from driver plugin directories
>
> lib/librte_eal/common/eal_common_options.c | 9 ++++++---
> lib/librte_eal/common/meson.build | 2 ++
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
Looks good to me. For the series:
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2020-11-25 10:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 15:13 [dpdk-stable] " Timothy Redaelli
2020-11-24 15:13 ` [dpdk-stable] [PATCH 1/2] eal: fix shared lib mode detection Timothy Redaelli
2020-11-24 15:14 ` Timothy Redaelli
2020-11-24 15:22 ` Bruce Richardson
2020-11-25 9:10 ` David Marchand
2020-11-24 15:14 ` [dpdk-stable] [PATCH 0/2] Fix shared lib detection on Fedora/CentOS/RHEL Timothy Redaelli
2020-11-24 15:14 ` [dpdk-stable] [PATCH 2/2] eal: fix loading of shared libs from driver plugin directories Timothy Redaelli
2020-11-24 15:22 ` Bruce Richardson
2020-11-25 10:01 ` David Marchand
2020-11-25 11:05 ` Ferruh Yigit
2020-11-25 10:57 ` Maxime Coquelin [this message]
2020-11-25 15:56 ` [dpdk-stable] [PATCH 0/2] Fix shared lib detection on Fedora/CentOS/RHEL Ali Alnubani
2020-11-25 15:59 ` [dpdk-stable] [dpdk-dev] " Ali Alnubani
2020-11-25 22:54 ` [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fa7388d-4bcf-fd01-0aa4-cb9effee5a65@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).