From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B61DA45459 for ; Fri, 14 Jun 2024 11:01:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 956E4402F0; Fri, 14 Jun 2024 11:01:12 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2070.outbound.protection.outlook.com [40.107.94.70]) by mails.dpdk.org (Postfix) with ESMTP id 7F94A402DD; Fri, 14 Jun 2024 11:01:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a5wBhqWw8psPrGBcQt5GKOltbrcW2UJI7Tb1ZLVZo8tCiIs+0MlZl30qWR37tRf7NFbIe7TLm5a5Y6C/GkZc6PQpXF4QXipQebBFq4vM+mDuI3sbrbC6csSdSfLPYvaWMzSibDI7MMSSVe8KfSJXAloEGyHE3l+msTV5nP0rqaqnDNf/utBV1F660D/Bwc6yO3Ew75m/TWD2EPpesHJ0BMmLzwFlPLcbM1yHmVUUqsk+yAt+N1UV/5XuVJN6KDyYDCMQNOiLb8RQY8ijPAg/xFhzmKxXRrB9y5LlwUizHsS9IKQp58Iwtn6BueQGwbIE6+03coggpY1vXnTnvnkWeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HJl/YjHLKA188VzpI7eVeTlCoMENBl6ImWpDNeKD1Mw=; b=OWFwvi/CRdBXwCgLj6LPgqeApJm7Ft3tyXllivm5No7Dvz4+/A9qnJL/jbiSxGITzHpuGePBesqczcPxtqz9ger3hQkHgtZzmp1KZ79ePuJ2Tfqi44QccL1pG7Bwr/WLruoLl/aVZigwSLO9sy3DoPgFbUT/9QQry6OA6mkspvKU1mfW8rkhIXFb2Q/s/5h9nGZsONUocpWMJdBX/eODcjvr5hc2EPeARUVMF1Fn+EygT+SNW9SHCroR0fo0RxBrkvxuC0FteGoKM0VvLz08jC8BG2e02MOlRyCHRBpahJE4f500vmRRToyeTO2jnjVna/OFzOf9kIWHEC72MJYeCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HJl/YjHLKA188VzpI7eVeTlCoMENBl6ImWpDNeKD1Mw=; b=tTG8DiVE6SZf1jrGKNJPwq4Z+Dbxp40ra56zvDwfpnU1jU6EbcIynNsYF3v8xoUU5HKKZI7z65EtLYdaa8LVIU+6+U2r1dRNoC2HPBG8EQu3+NrSY6z+UsxSoSXS/t43CpBFV8lb8wtmE+NfJuNCdtld5YpucbJIZ/YNNdazXVs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB5877.namprd12.prod.outlook.com (2603:10b6:510:1d5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.35; Fri, 14 Jun 2024 09:01:07 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7677.026; Fri, 14 Jun 2024 09:01:07 +0000 Message-ID: <3fad191a-1402-4bb2-9992-6e2f4a50d295@amd.com> Date: Fri, 14 Jun 2024 10:01:02 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] app/testpmd: fix lcore ID restriction To: Stephen Hemminger Cc: Sivaprasad Tummala , david.marchand@redhat.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, dev@dpdk.org, stable@dpdk.org References: <20240415194631.124343-1-sivaprasad.tummala@amd.com> <20240416095556.173787-1-sivaprasad.tummala@amd.com> <5de50671-73b8-432d-a1a2-ce6b3120e73d@amd.com> <5a0370e4-aa42-4bc4-a5a8-34c37b88b95f@amd.com> <20240613121330.71538e19@hermes.local> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240613121330.71538e19@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0136.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c4::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB5877:EE_ X-MS-Office365-Filtering-Correlation-Id: d2839307-2c6d-4645-bebb-08dc8c50873d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230035|1800799019|366011|376009; X-Microsoft-Antispam-Message-Info: =?utf-8?B?d0RQbDlyQ1BhSWo4cHBJTnh6UXNNbFg1YjZDZmF1emR4b1gvajR6b09sOXVU?= =?utf-8?B?RmhmN240ZEJHMXYyM0lEdkRGY2Jlbk1mOFdtK1k5bEQrUUxyUEZlSE13bkJj?= =?utf-8?B?T0oxMVVQb3B5dUFySDVPV3FraW40d1ppbXlXRlBXWU1hVUpDZ01OOWZuT1Az?= =?utf-8?B?N1VDbG5QVkpRNW45MmVSMUNOOTl5Vi9RY1VxUXl3VXlHOTdHN1JFUFVXTEI0?= =?utf-8?B?RmR1TW9iOVBlbkl2QmUwcG55MzNBOWpaeThFblNFYlVFOTFXaTM4U2VGSTI0?= =?utf-8?B?cnZlU3J5RU1zYVpGNDI1Zm1VK2RaR2FjbEZZdEtRTE50L1h6WDEyTml1ZjI5?= =?utf-8?B?bnFjbThiQTZnL2VHMHg4allHUGZwZUlpUnZoWExTOEkzeHZRUzBpYnF1K1BS?= =?utf-8?B?TmZmTDA5MDdyZmY2NmQvazFQNzNEK1dpelJoWXhZeEJwUWFvcFdya3l4K0pG?= =?utf-8?B?ZXcycFZTVk5XR1kyb1FOb2s1alFMeFB3QkNucjAyVVFpZDV4N2cwazhHNFV0?= =?utf-8?B?dHV5cGw2Nm5MM2dOKzBlV2o2ci9GRDdyMXpONVdobWN2cDcvUEFCdXB5dkJ3?= =?utf-8?B?L3ZibjViWnprUXlSV3MyYW5wek1FdDZaK1gydTNmdXJHLzBTeUZrYVF5RFB1?= =?utf-8?B?bXBVR0JlcTBhVmlFV0ZpZXNDUjdFaUk0VXFNY2RJcnlOYnM0K0MzT2ZMcXRz?= =?utf-8?B?T3NpOU1HNjN3V2ZqWUZZbHZ0QnNZS0p3YjI5V0krTUFpVm9UWkRjdG5rSjNG?= =?utf-8?B?UFlabm1xelloZXIwR2tIUDkrT1hWZ1RYeXYrd1V3NkhzYldpMTlpc25HNDBR?= =?utf-8?B?Z2lWdW1aSitSTUcvZ0hiaFh5K28rT3lhdGhadlFWT0YrRXVISUFoMFlqanVF?= =?utf-8?B?Tjljd3MwSnRmcjJCODQ1VVNTQ2JIRDdBY2ZTWGMwTGZRbGZld0tQRGZxdzh3?= =?utf-8?B?QmpqOHdSZVBzaFJ0MnVaTDF5QjJJcHdsSWFHdW1yN2dqSjM3MFdXM0IrZjVI?= =?utf-8?B?MjBWTDlLSHJzYWMwTnREOEZGbnNoKzBLcjkrUVBqODlZUGdmVThycnlFaCtK?= =?utf-8?B?d1dMYmRXemNKT0RuNmlJRDR6OXRhUFNsTy9JeDNKR3pwVEtCdEowbmpvZU1O?= =?utf-8?B?N3lUams1TU1mb2ltWXBnblhlMW14d0xYWXUxYjRoa2cwZlJUMW9IYVBWeWR3?= =?utf-8?B?NUgydFNZQlVzU0Z2bVFzcUFoSnJZalhOMzdNeWkwNUxkNDBtbWk2cTFBYVpm?= =?utf-8?B?WWZ5VVV2NmVkNXg4ZXVRbmJIZm9HZTF2bHpmQWw5eEo0K1NYM2ZsT3U2TndI?= =?utf-8?B?VEhqZklMaHJKNXg3T20xSS95cWNGV3dxSDZYSGUwVkR3Mm1CZTAwWXFaMHhz?= =?utf-8?B?djhPbldmRFVlNnBWSmNaZGtXZmo4QlNzQmFFa0RIUEpPWTF3Um1kbnkvNVhG?= =?utf-8?B?UGR0bHFiTTl6UWFybWhRbmFYY2FLZFVCVWFpb2tYaU1Odk9ONDFiaDFWdkJN?= =?utf-8?B?ZVBWVjB4enU3akFPUmoxSEsvWGdKeVBLN0hhcUhBNjVTZTdkWDZ6STRjb2F0?= =?utf-8?B?d2NzekFXaFo1aWNvU3Vya05CcVlmMGQ3OWEvbGtuNm5MYk5lRFQvK2NEQ1ZO?= =?utf-8?B?VXd5amc5TnRQSFM5T1pqZG9lTFBsWEsxTkd2SVU2WHNsYWxiSGg2d0JCKys3?= =?utf-8?B?L1plYndvM1k3ZW93NDRyV2xIUkROM1VPMTNLOUUzMXp5K1VNQW5MejJRVk9E?= =?utf-8?Q?fzrskfYeJH9dnNhdwQyYmXoF41kjAGfW+DT8Nxy?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230035)(1800799019)(366011)(376009); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzMxMU02WWlVdXdpcDEzd295M2dTODZHdXczbDBiQVp0RWQ3d2pwT3lvV1Nk?= =?utf-8?B?bXpCVmE0enpJQWl2RjBvSmNVbHlsZUh6bkFzSVNyVmNCaFMyOGJmYW9hYzhr?= =?utf-8?B?TUl6UnhsNzlWS0ZvREc3Wk11U21mN2o2VDJpb0w2NnJxT0JVYk9TMzlNQkdE?= =?utf-8?B?cVYzaDVINElHVE5CNlhwSENvQ1dJYno3QUhkemRuVGR4Q3RHYXlyajdkRmw0?= =?utf-8?B?UHpFcFptVGxySGY5WDZYRWsyYVlaRERkUmwrNWNidUxJdHVNN1BRZHhUbzA3?= =?utf-8?B?SGVReEJiZDVsYWRzakRsNXl4eUhQVDFOSEhDUjNNQnFYRFMvYkwvZG92LzVY?= =?utf-8?B?WmJXczdBM0tpK3JEQW04LzFCVW1yZUp3RlRScGVmNkJ0bG9jejJ0YTdjUDU0?= =?utf-8?B?NlFRcTE1VHM5NW5EalBFS2VVZjh4bU1DaUk5WWl1V3kyclhTaTM0ekVGM2ly?= =?utf-8?B?Z29jdTFISUtIcDA0VkFEcjYySXVYNHlxdzI1Sy9rUkFIUGlnSjgvcnUvY0ZW?= =?utf-8?B?SjNkS3RFL2F6OFRXRnVBc0RSb1ZlL2NWck94Z0ZhYlVOK1B3emRDbzVjTDFy?= =?utf-8?B?ZmhOM2drc1IybWdzVDBoNGpmV21Yb0FhMFdWUTk4NWd5MmZrZ3RXT2ROL2dX?= =?utf-8?B?dDJzL3RNU3B1R3JxVVdCK2pEMjNaTFJIVFZCUFl2QnlHdDdMb213YnBhZndp?= =?utf-8?B?WGgvaUEzazVFcTZncCtqd052VDltL2NPalRhZ0VzUzExcWJzVFlZOU5DQXFq?= =?utf-8?B?NVNtQzZZa2lJVE9DVVptcHRVSzdIbjB3WkJzaDZjWE5nK2FtN3BxekQySGJz?= =?utf-8?B?OStVTWNxS3VlRXAvWWpOQ2svS2dyNW9hVSt5UXh1QWJKRXI4alJrZVJ5cmZP?= =?utf-8?B?cXhhb0VvSjkrMDV1dXN3UkRtR3ZFZFg1MGxRSHlmaUNWZ3E2S0ZnVDlsZEc3?= =?utf-8?B?MXM5QkhoR2lIelZTQVdWaHQ0anZXc1h3TWhLK21aam5DeUh5RE8yTkZMLyta?= =?utf-8?B?bGd3aEVvMUxDVmVXWGwyN3hBSk9iZnZDR3I4d29WdXdGRmU1K05EeUxUZnJR?= =?utf-8?B?V0oyL21uWi81eEQ2UWQ4VUtLWkVzYlB5dDBmNHVDMUpvVURsUzBTVmRYR1d5?= =?utf-8?B?NTRuTUtYUnF3V3phQmlnMER6a25odHR2UUdzRmttYXZ1YkdKVWNtc041NmRs?= =?utf-8?B?d1VXMDQxcmRJWFBVNUNBZ2Z5bi9id0kzWlNpNzFMR2FzZWdoUTBQYUVkUVVa?= =?utf-8?B?bVo5cnNYNFpHbU5NRElCd2lhWHFhVktCeWNRYVYyYnA3SE05RHoxK0JseThU?= =?utf-8?B?T1BuWFk2YWZpeFp5aCtuM3dlbFJFazhFYThHVzJxaU1FYVFJbFJndlEzcitq?= =?utf-8?B?bHV6emh4bFZzVkUrQldqVzlPWTJ2cE11UnBLdnN2SzR5aXF1UEc0TVViV2F5?= =?utf-8?B?aE9XTkpGR0lULy9Bb2NDVll3ZFd3VHNMVHhnK0l6KzRNQVlrZGZNRVNWTFln?= =?utf-8?B?K25ZOFpacWt2OEN0azNFejN2aHN2WFZlS0JhZURVVlRQNTRyRWtGd0t5SFh5?= =?utf-8?B?aFNJblVkaDJLelhyUnBGNzVLWUs4VnI5MTJiTUtoL2ZJbVdhZEJJSW94OEdu?= =?utf-8?B?UVpTOGk0cnZxTFlnWkthSVNUR0xHelVjTkVMUVNUaHZJMVk5UUpuUjZSd0d0?= =?utf-8?B?Wm5uTUpYMDhldXdmMXZKVVNOaC8xM0RvdWVPQUZ3QXI5MklWUlNXdTZxK0RU?= =?utf-8?B?STV6RW9wcUpNclVXRm1XM2RhRmMyZnhzcm5VdlFuZ3lLWk8veG9nVjJmeG41?= =?utf-8?B?RUJ3NFdjcG5PK2RYUVQvb1BQZnl2WFZlS0dBOU1RVXczeG12NEtnWHdXVllJ?= =?utf-8?B?VkRMQVNWWHc4MTlJdEVvTjhacTJLQXJsTjNibXV5UjhQOHppQnB3TkhzZVdB?= =?utf-8?B?eWZiUlhrSVdpRGQ2TEE5NXNUL3VGbFc1eUhJUVdlanVpbWRaQ1BETTRMSE9Q?= =?utf-8?B?NjZoZzRVTjk1VXNOdlpkbVJWV2tnQnkvZHRneFZ1UDcrQTJ6Wk4zTDJ6Z2lU?= =?utf-8?B?b1drb1p2SmFCREFzUjBmOFZ5WXFhbEZobktVZ3ZSNEtjR0ZUMmRTcElsWDZz?= =?utf-8?Q?1YrR9Mr3nv64m7VQGISIcbqCQ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2839307-2c6d-4645-bebb-08dc8c50873d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 09:01:07.6677 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sre4Q7vDg7eas72ixMe2wMVsnwELJbR2UXgeCl1ZDiAPJ7f/SOuFoqxllAKaDoh8 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5877 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 6/13/2024 8:13 PM, Stephen Hemminger wrote: > On Thu, 13 Jun 2024 17:51:14 +0100 > Ferruh Yigit wrote: > >>> Hi Sivaprasad, >>> >>> Is this '(lcoreid_t)' cast required? Because of integer promotion I >>> think result will be correct without casting. >>> >>> (And without integer promotion considered, casting needs to be done on >>> one of the variables, not to the result, because result may be already >>> cast down I think. Anyway this is not required for this case since >>> variables are u16.) >>> >> >> Why casing required (for record) is, >> 'nb_txq' -> uint16_t, promoted to 'int' >> 'nb_fwd_ports' -> uint16_t, promoted to 'int' >> (nb_txq * nb_fwd_ports) -> result 'int' >> nb_fwd_lcores -> 'uint32_t' >> >> comparison between 'int' & 'uint32_t' gives warning. After some compiler >> version it is smart enough to not give a warning, but casting is >> required for old compilers. >> >> And back to my comment above, casting one of the parameter to >> 'lcoreid_t' also works, as it forcing promotion to 'unsigned int' >> instead. But logically casting looks odd, so keeping casting result. > > Where is the integer promotion happening? > Raslan reported following compile error, this version of the patch has the cast, but merged version, v3, doesn't. ``` ../../root/dpdk/app/test-pmd/config.c: In function 'icmp_echo_config_setup': ../../root/dpdk/app/test-pmd/config.c:5159:30: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if ((nb_txq * nb_fwd_ports) < nb_fwd_lcores) ^ ``` > Also would be better to use strtoul() instead of atoi() when parsing the args. > That gives better error handling and handles someone passing negative number correctly.