From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CBC6A034D for ; Mon, 14 Mar 2022 21:21:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B3CE4114F; Mon, 14 Mar 2022 21:21:25 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 4D2F640E2D; Mon, 14 Mar 2022 21:21:23 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8CEDB5C00E0; Mon, 14 Mar 2022 16:21:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 14 Mar 2022 16:21:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=TENOT7ZwZvBOC9 ddVnzW5Mxi19vKDudkIsyMpMeMdVY=; b=iZ8pW0geinUfRB7H9J5cyK1C2spAKX HYr4++fSWWbqD359HMAAY6gpFAt/+q/18i3vV92A0N3VKpydpfmlZRNCxKmx7JoF 1IR+WSGZWBTBq1Nt0OegolbgHDbKNOt1G0O4/WYFztaDcn4r1zOMtWV4bVxE1XUW ABYixAUbwTkHF3qpdKgfy8zFP8fVwhT2Hi+Fl8EYgT3O0mFbCOdXLfaw70QTADpF 3s8tXT/XYtXKNjMQ2D9NEuPYS8yrpj+ixoerYHrA2I5YiHsDY+4YSlLTks3lSOir B7KtRb3/u+ft9SaZO02sXbcHnkuHrFJEJD7L7HTbPzKUqVDu8xl/L58g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=TENOT7ZwZvBOC9ddVnzW5Mxi19vKDudkIsyMpMeMd VY=; b=CXgzLN20IftD/VxZGv9qrLKd54PiMosIgN0jhVUxoW78NGW1O7PAWOUS/ 5G24weCR4xfZbOocSXeCzJPL0uKSd2yuoARHNerz+MuKMucxH8VpWIy2TGRRFmTO AnkuGPc9MQBxDesr6aMS+lmvDJ28Pzc3DvaEg85+4PG9gtGaumo3rc5UTmjgFLVg JuyuLdzNSO41QrLtGH23QUARnJoPMGgiIgFbN3mmCKuTpp0nJVgNDePULycyLdNm PwIeW17pKZH5kqGCDyZizGd+x1G63fa7oDEA9mBZh3SNRMx28ajC7Ouf+sv+/eU0 9rVkImL7BamLHCVVLjkoCGG3Hx/2w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddvkedgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Mar 2022 16:21:21 -0400 (EDT) From: Thomas Monjalon To: "Liu, KevinX" Cc: "Yigit, Ferruh" , dev , "Yang, Qiming" , "Yang, SteveX" , "Xing, Beilei" , "Li, Xiaoyun" , dpdk stable , "Zhang, Yuying" , "Zhang, Qi Z" Subject: Re: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments Date: Mon, 14 Mar 2022 21:21:18 +0100 Message-ID: <4049414.1IzOArtZ34@thomas> In-Reply-To: References: <20211224150925.3296471-1-kevinx.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 14/03/2022 03:33, Zhang, Qi Z: > From: Yigit, Ferruh > > On 3/11/2022 7:04 AM, Liu, KevinX wrote: > > > From: Zhang, Yuying > > >>> From: Liu, KevinX > > >>>> Testpmd forwards packets in checksum mode that it needs to > > >>>> calculate the checksum of each layer's protocol. > > >>>> > > >>>> In process_inner_cksums, when parsing tunnel packets, inner L4 > > >>>> offset should be outer_l2_len + outer_l3_len + l2_len + l3_len. > > >>>> > > >>>> In process_outer_cksums, when parsing tunnel packets, outer L4 > > >>>> offset should be outer_l2_len + outer_l3_len. > > >>>> > > >>>> Fixes: e6b9d6411e91 ("app/testpmd: add SW L4 checksum in multi- > > >>>> segments") > > >>>> Cc: stable@dpdk.org > > >>>> > > >>>> Signed-off-by: Kevin Liu > > >> > > >> Acked-by: Yuying Zhang > > >> > > > Hi, Ferruh > > > > > > Yuying has already reviewed it days ago. > > > If you can, I hope you can change the status as soon as possible and try to > > merge the code in RC4. > > > Thank you. > > > > > > > +Thomas, he is getting patches for -rc4. > > > > And just for double check Qi, are you comfortable with patch? > > (I am asking because initially this is set with ice and testpmd patch) > > Yes, I'm OK with this patch. It has been verified on most of Intel PMDs. Applied, thanks.