From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C7A35A00C4
	for <public@inbox.dpdk.org>; Wed, 13 Jul 2022 11:15:27 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BBE9E42B6D;
	Wed, 13 Jul 2022 11:15:27 +0200 (CEST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 45C4B4069D;
 Wed, 13 Jul 2022 11:15:25 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 86C795C01CA;
 Wed, 13 Jul 2022 05:15:24 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Wed, 13 Jul 2022 05:15:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to; s=fm3; t=1657703724; x=
 1657790124; bh=HqyA0vZ7T16j/8du4oIOCN0f9wfu9BiCMcyHJ4ro1bI=; b=o
 6O/C8pDffl8k9wK/2flKGU3xxSiQNvi3XEfAq/1EAJX07VV30TjG4/DnHqLvT9zY
 UbKu7kXOidpB84rhCUu78BgbHwBpzzmmghGvDJaPSUSYsjtAyvlDsVGnf7WGs30l
 +aVBfSz7h8nAi6bB+3mGoUDNjLX2/LdBWV783N7dPkEtoe5ZPDi/cah6XL1kexnm
 mlIi/6qtvVFyTs2QVlTqB8enS2RJzQiKG0zFEFrjNHKp53Aw/VXu4HIRUdqy6fWT
 aJU0F3MV3izY3cVdbZwEpsqSVhJ8XyI0NXwuMz8/0uHMG9scVP4nJtltXjJXx8lI
 N7CwvpDtvqasQz5AoIpng==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:date:date:feedback-id:feedback-id:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657703724; x=
 1657790124; bh=HqyA0vZ7T16j/8du4oIOCN0f9wfu9BiCMcyHJ4ro1bI=; b=i
 J3hUf04jQLqTiJq1DmyOH31y+Uwk8kNNQfLv1aHMQHN+E22zU4gwIGa/1HENsj8J
 xRTvCFmk77NRuxBexNpJlebhwNevyl5pZmyiszs3e9hjzGfNZR9QnQgTdYChjqVk
 57DTRpZG7l59qW5s81WAbwlglslUQGd3LVIA7JkIq7xHZT3kbjwq3hyMbtKc5I1z
 0Z15ddUTbd8WZ2Ab3AjnLvQUxhGYQ2nY7Bg1f79pMEQnY4tfHf13G52RsS58UhUw
 ek8Lm0QVYRD0RCCs5xOF+vlu1l48gcnqSeUPAwyabNVkpm1X27WJM0BS2Ir0mrdI
 3SDR10VGy+kvW7jpdF32g==
X-ME-Sender: <xms:LI3OYkF1UYxGVmDnsvIeQNpHAj1tXzU_oGsgsm_AiBI0bTmJOCUjRQ>
 <xme:LI3OYtVu6astcg3H7OaeSu6cF5Kf8fU6R9kDQXHOQgeToZojFLMb-Uggfr3_kStWT
 fvhMU-CTOFGsPTw9g>
X-ME-Received: <xmr:LI3OYuLms8UeujMt4d-uMuR_-_5vCP-Qh-x7mSephEo510ChfFAZ2r3fd62ks0RwgQa-xftME4FZ38bZKGsbtZSf2w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejjedgudduucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
 rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
 ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei
 kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
 hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:LI3OYmHGQ-i2j_wS7bi7adpIdTpsZNs2SD4-JM9L0WlLXJGjO_ZoGg>
 <xmx:LI3OYqVhxgQtBQ8Aq27lTrdB98_5nrCqunNRvGvnj4f6FebWYNyCyQ>
 <xmx:LI3OYpNtNN8yCArTvtdfLzB9j8NdrIBEgyr4BhGdwBLGX1CTTRFiEA>
 <xmx:LI3OYoxAecxv1klA-zEoPuRPsNKoC1GjHquOk2Rj8PlKC6OnB4a8UQ>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 13 Jul 2022 05:15:23 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ke Zhang <ke1x.zhang@intel.com>
Cc: yuying.zhang@intel.com, beilei.xing@intel.com, ferruh.yigit@xilinx.com,
 dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v3] app/testpmd: fix quit testpmd with vfs and pf
Date: Wed, 13 Jul 2022 11:15:22 +0200
Message-ID: <4079218.QzVbxSjN2m@thomas>
In-Reply-To: <20220713071112.6182-1-ke1x.zhang@intel.com>
References: <20220621092453.185583-1-ke1x.zhang@intel.com>
 <20220713071112.6182-1-ke1x.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

13/07/2022 09:11, Ke Zhang:
> A segmentation fault occurs when testpmd exit.

The title talks about testpmd, but the change is in i40e.
Please update.

> This is due to fetching the device name from PF
> , PF is freed firstly and then VF representor
> is called later.

For info, a comma must follow the previous word without any space.
It is strange to see a comma at the beginning of a line.

> This commit fixes the bug by fetching the device
> name from vf representor not PF.

vf should be VF uppercase

> Fixes: e391a7b7f815 ("net/i40e: fix multi-process shared data")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
> 
> ---
> v3: Change the design and fix code in driver
> v2: Change the testpmd code to fix this issue
> ---
> ---
>  drivers/net/i40e/i40e_vf_representor.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)