From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id F0BE64D3A; Tue, 19 Feb 2019 17:03:08 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 664253573; Tue, 19 Feb 2019 11:03:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 19 Feb 2019 11:03:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Bte6cpQulDXvze3caYaKVmxhrkUyB9vkN7WB3cYGf7M=; b=dRoM70bfV04o ExafopgD90y+RPMJ6dhyXI7y0su52feV1E8X+QmoF5gNcsKkh2kZ6Pjrxoh/J0MF HwcwFQ4GHpiQwNHa2oKru9IN9r1ah4Z6HdI4qClAt299HeqncJp8ePdEwBDISpUd mfSSgQCKUd6dIyxKPkYb86SEdR0tex8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Bte6cpQulDXvze3caYaKVmxhrkUyB9vkN7WB3cYGf 7M=; b=FTxNmcJS9gdovoVZrA12t1OZ2DN7oe3HCwrUr+HcVKnkeCGoCWS8zh6tk 021z3agfN5bioPCMFbqcFfFR6O50/illbUKYB003F3+jS2Wdd6ie/hDOU2H9C4N6 oaqdKUxvoFNmJ03gFMIF7B/0ZqRHLqlL4n9/II0z2v9g2v4yWVI8qEOONEfAhwuP YmK7kbpPINAcp1s7Cfpt1YGhcqwtFnEaGOUP0twRYESHy5gw6CpqVESc5nAyaqJV Ae0zru9tjymWatwZPPV/kky9P7gE7neB62C/HZPgF0WTV6+NSjwvNKJxaNu0eOgM wl+FPlWvzUYiSxdc/Ndn/1IVmcuUg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrtdeggdekvdculddtuddrgedtledrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne cuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E3E7AE4430; Tue, 19 Feb 2019 11:03:04 -0500 (EST) From: Thomas Monjalon To: David Marchand , "Burakov, Anatoly" Cc: stable@dpdk.org, dev@dpdk.org, Olivier Matz , Kevin Traynor Date: Tue, 19 Feb 2019 17:03:03 +0100 Message-ID: <4081676.pH4rpHE09Y@xps> In-Reply-To: References: <1550074412-31285-1-git-send-email-david.marchand@redhat.com> <6d3960bc-9798-fa79-2538-339d63caf81b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH v2 2/2] eal: restrict ctrl threads to startup cpu affinity X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Feb 2019 16:03:10 -0000 19/02/2019 12:51, David Marchand: > On Tue, Feb 19, 2019 at 12:38 PM Burakov, Anatoly > wrote: > > On 14-Feb-19 1:30 PM, David Marchand wrote: > > > --- a/doc/guides/prog_guide/env_abstraction_layer.rst > > > +++ b/doc/guides/prog_guide/env_abstraction_layer.rst > > > +Control Thread API > > > +~~~~~~~~~~~~~~~~~~ > > > + > > > +It is possible to create Control Threads using the public API > > ``rte_ctrl_thread_create()``. > > > +Those threads can be used for management/infrastructure tasks and are > > used internally by DPDK for multi process support and interrupt handling. > > > + > > > +Those threads will be scheduled on cpus part of the original process > > cpu affinity from which the dataplane and service lcores are excluded. > > > + > > > +For example, on a 8 cpus system, starting a dpdk application with -l > > 2,3 (dataplane cores), then depending on the affinity configuration which > > can be controlled with tools like taskset (Linux) or cpuset (FreeBSD), > > > + > > > +- with no affinity configuration, the Control Threads will end up on > > 0-1,4-7 cpus. > > > +- with affinity restricted to 2-4, the Control Threads will end up on > > cpu 4. > > > +- with affinity restricted to 2-3, the Control Threads will end up on > > cpu 2 (master lcore, which is the default when no cpu is available). > > > > You're not winning anything by foregoing the 80 char limit on > > documentation (doxygen will still generate this correctly), but you're > > losing in readability when working in terminal. I would prefer if you > > didn't do those long lines :) > > I don't really care, I will just wait for Thomas opinion. > > > Thomas, do we want checkpatch to warn about this? http://doc.dpdk.org/guides/contributing/documentation.html#line-length Lines should not exceed 80 chars. There is a tradition of being very flexible in docs. The best is to wrap at the end of a logical group of words, like after commas or dots. So the doc updates patches are easier to read.