[dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

[dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

[Honnappa Nagarahalli]

GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not
optional for ArmV8. Hence NEON related code can be enabled
when __aarch64__ is defined.

Bugzilla ID: 82
Cc: stable@dpdk.org

Reported-by: Raslan Darawsheh <rasland@mellanox.com>
Reported-by: Thomas F Herbert <therbert@redhat.com>
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
Acked-by: Gavin Hu <gavin.hu@arm.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
V2:
* Corrected the order of contribution tags
* Added Jerin's Ack

 config/arm/meson.build | 3 ++-
 mk/rte.cpuflags.mk     | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 40dbc87..94cca49 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -157,7 +157,8 @@ else
 endif
 message(machine_args)
 
-if cc.get_define('__ARM_NEON', args: machine_args) != ''
+if (cc.get_define('__ARM_NEON', args: machine_args) != '' or
+    cc.get_define('__aarch64__', args: machine_args) != '')
 	dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1)
 	compile_time_cpuflags += ['RTE_CPUFLAG_NEON']
 endif
diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk
index 6071313..43ed841 100644
--- a/mk/rte.cpuflags.mk
+++ b/mk/rte.cpuflags.mk
@@ -89,7 +89,7 @@ CPUFLAGS += VSX
 endif
 
 # ARM flags
-ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),)
+ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),)
 CPUFLAGS += NEON
 endif
 
-- 
2.7.4

Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

[Yongseok Koh]

Hi,



Thanks,
Yongseok

> On Sep 2, 2018, at 11:32 AM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
> 
> GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not
> optional for ArmV8. Hence NEON related code can be enabled
> when __aarch64__ is defined.
> 
> Bugzilla ID: 82
> Cc: stable@dpdk.org
> 
> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
> Reported-by: Thomas F Herbert <therbert@redhat.com>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> Acked-by: Gavin Hu <gavin.hu@arm.com>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> V2:
> * Corrected the order of contribution tags
> * Added Jerin's Ack

I didn't check out the details yet but a quick question.
Do you want me to include this patch in 17.11.4?

Thanks,
Yongseok

> config/arm/meson.build | 3 ++-
> mk/rte.cpuflags.mk     | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 40dbc87..94cca49 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -157,7 +157,8 @@ else
> endif
> message(machine_args)
> 
> -if cc.get_define('__ARM_NEON', args: machine_args) != ''
> +if (cc.get_define('__ARM_NEON', args: machine_args) != '' or
> +    cc.get_define('__aarch64__', args: machine_args) != '')
> 	dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1)
> 	compile_time_cpuflags += ['RTE_CPUFLAG_NEON']
> endif
> diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk
> index 6071313..43ed841 100644
> --- a/mk/rte.cpuflags.mk
> +++ b/mk/rte.cpuflags.mk
> @@ -89,7 +89,7 @@ CPUFLAGS += VSX
> endif
> 
> # ARM flags
> -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),)
> +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),)
> CPUFLAGS += NEON
> endif
> 
> -- 
> 2.7.4
> 

Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

[Honnappa Nagarahalli]

-----Original Message-----
From: Yongseok Koh <yskoh@mellanox.com> 
Sent: Sunday, September 2, 2018 2:30 PM
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined


Hi,



Thanks,
Yongseok

> On Sep 2, 2018, at 11:32 AM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
> 
> GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not optional 
> for ArmV8. Hence NEON related code can be enabled when __aarch64__ is 
> defined.
> 
> Bugzilla ID: 82
> Cc: stable@dpdk.org
> 
> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
> Reported-by: Thomas F Herbert <therbert@redhat.com>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> Acked-by: Gavin Hu <gavin.hu@arm.com>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> V2:
> * Corrected the order of contribution tags
> * Added Jerin's Ack

I didn't check out the details yet but a quick question.
Do you want me to include this patch in 17.11.4?

Yes, please include.

Thanks,
Yongseok

> config/arm/meson.build | 3 ++-
> mk/rte.cpuflags.mk     | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build index 
> 40dbc87..94cca49 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -157,7 +157,8 @@ else
> endif
> message(machine_args)
> 
> -if cc.get_define('__ARM_NEON', args: machine_args) != ''
> +if (cc.get_define('__ARM_NEON', args: machine_args) != '' or
> +    cc.get_define('__aarch64__', args: machine_args) != '')
> 	dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1)
> 	compile_time_cpuflags += ['RTE_CPUFLAG_NEON'] endif diff --git 
> a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 6071313..43ed841 
> 100644
> --- a/mk/rte.cpuflags.mk
> +++ b/mk/rte.cpuflags.mk
> @@ -89,7 +89,7 @@ CPUFLAGS += VSX
> endif
> 
> # ARM flags
> -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),)
> +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),)
> CPUFLAGS += NEON
> endif
> 
> --
> 2.7.4
> 

Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

[Yongseok Koh]

> On Sep 2, 2018, at 12:59 PM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
> 
> -----Original Message-----
> From: Yongseok Koh <yskoh@mellanox.com> 
> Sent: Sunday, September 2, 2018 2:30 PM
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined
> 
>> On Sep 2, 2018, at 11:32 AM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
>> 
>> GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not optional 
>> for ArmV8. Hence NEON related code can be enabled when __aarch64__ is 
>> defined.
>> 
>> Bugzilla ID: 82
>> Cc: stable@dpdk.org
>> 
>> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
>> Reported-by: Thomas F Herbert <therbert@redhat.com>
>> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>> Reviewed-by: Phil Yang <phil.yang@arm.com>
>> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
>> Acked-by: Gavin Hu <gavin.hu@arm.com>
>> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>> ---
>> V2:
>> * Corrected the order of contribution tags
>> * Added Jerin's Ack
> 
> I didn't check out the details yet but a quick question.
> Do you want me to include this patch in 17.11.4?
> 
> Yes, please include.

I didn't realized that this is fixing the meson build.
17.11 doesn't have that.

Thanks,
Yongseok

>> config/arm/meson.build | 3 ++-
>> mk/rte.cpuflags.mk     | 2 +-
>> 2 files changed, 3 insertions(+), 2 deletions(-)
>> 
>> diff --git a/config/arm/meson.build b/config/arm/meson.build index 
>> 40dbc87..94cca49 100644
>> --- a/config/arm/meson.build
>> +++ b/config/arm/meson.build
>> @@ -157,7 +157,8 @@ else
>> endif
>> message(machine_args)
>> 
>> -if cc.get_define('__ARM_NEON', args: machine_args) != ''
>> +if (cc.get_define('__ARM_NEON', args: machine_args) != '' or
>> +    cc.get_define('__aarch64__', args: machine_args) != '')
>> 	dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1)
>> 	compile_time_cpuflags += ['RTE_CPUFLAG_NEON'] endif diff --git 
>> a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 6071313..43ed841 
>> 100644
>> --- a/mk/rte.cpuflags.mk
>> +++ b/mk/rte.cpuflags.mk
>> @@ -89,7 +89,7 @@ CPUFLAGS += VSX
>> endif
>> 
>> # ARM flags
>> -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),)
>> +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),)
>> CPUFLAGS += NEON
>> endif
>> 
>> --
>> 2.7.4
>> 
> 

Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

[Honnappa Nagarahalli]

-----Original Message-----
From: Yongseok Koh <yskoh@mellanox.com> 
Sent: Sunday, September 2, 2018 7:00 PM
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: stable@dpdk.org; nd <nd@arm.com>
Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

> On Sep 2, 2018, at 12:59 PM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
> 
> -----Original Message-----
> From: Yongseok Koh <yskoh@mellanox.com>
> Sent: Sunday, September 2, 2018 2:30 PM
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags 
> when __aarch64__ is defined
> 
>> On Sep 2, 2018, at 11:32 AM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
>> 
>> GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not 
>> optional for ArmV8. Hence NEON related code can be enabled when 
>> __aarch64__ is defined.
>> 
>> Bugzilla ID: 82
>> Cc: stable@dpdk.org
>> 
>> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
>> Reported-by: Thomas F Herbert <therbert@redhat.com>
>> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>> Reviewed-by: Phil Yang <phil.yang@arm.com>
>> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
>> Acked-by: Gavin Hu <gavin.hu@arm.com>
>> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>> ---
>> V2:
>> * Corrected the order of contribution tags
>> * Added Jerin's Ack
> 
> I didn't check out the details yet but a quick question.
> Do you want me to include this patch in 17.11.4?
> 
> Yes, please include.

I didn't realized that this is fixing the meson build.
17.11 doesn't have that.

Thanks,
Yongseok

It has a fix for the make build as well. Does it mean, it needs to be a different patch?

>> config/arm/meson.build | 3 ++-
>> mk/rte.cpuflags.mk     | 2 +-
>> 2 files changed, 3 insertions(+), 2 deletions(-)
>> 
>> diff --git a/config/arm/meson.build b/config/arm/meson.build index
>> 40dbc87..94cca49 100644
>> --- a/config/arm/meson.build
>> +++ b/config/arm/meson.build
>> @@ -157,7 +157,8 @@ else
>> endif
>> message(machine_args)
>> 
>> -if cc.get_define('__ARM_NEON', args: machine_args) != ''
>> +if (cc.get_define('__ARM_NEON', args: machine_args) != '' or
>> +    cc.get_define('__aarch64__', args: machine_args) != '')
>> 	dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1)
>> 	compile_time_cpuflags += ['RTE_CPUFLAG_NEON'] endif diff --git 
>> a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 6071313..43ed841
>> 100644
>> --- a/mk/rte.cpuflags.mk
>> +++ b/mk/rte.cpuflags.mk
>> @@ -89,7 +89,7 @@ CPUFLAGS += VSX
>> endif
>> 
>> # ARM flags
>> -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),)
>> +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),)
>> CPUFLAGS += NEON
>> endif
>> 
>> --
>> 2.7.4
>> 
> 

Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

[Yongseok Koh]

> On Sep 3, 2018, at 1:25 AM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
> 
> 
> 
> -----Original Message-----
> From: Yongseok Koh <yskoh@mellanox.com> 
> Sent: Sunday, September 2, 2018 7:00 PM
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Cc: stable@dpdk.org; nd <nd@arm.com>
> Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined
> 
>> On Sep 2, 2018, at 12:59 PM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
>> 
>> -----Original Message-----
>> From: Yongseok Koh <yskoh@mellanox.com>
>> Sent: Sunday, September 2, 2018 2:30 PM
>> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
>> Cc: stable@dpdk.org
>> Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags 
>> when __aarch64__ is defined
>> 
>>> On Sep 2, 2018, at 11:32 AM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
>>> 
>>> GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not 
>>> optional for ArmV8. Hence NEON related code can be enabled when 
>>> __aarch64__ is defined.
>>> 
>>> Bugzilla ID: 82
>>> Cc: stable@dpdk.org
>>> 
>>> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
>>> Reported-by: Thomas F Herbert <therbert@redhat.com>
>>> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>>> Reviewed-by: Phil Yang <phil.yang@arm.com>
>>> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
>>> Acked-by: Gavin Hu <gavin.hu@arm.com>
>>> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>>> ---
>>> V2:
>>> * Corrected the order of contribution tags
>>> * Added Jerin's Ack
>> 
>> I didn't check out the details yet but a quick question.
>> Do you want me to include this patch in 17.11.4?
>> 
>> Yes, please include.
> 
> I didn't realized that this is fixing the meson build.
> 17.11 doesn't have that.
> 
> Thanks,
> Yongseok
> 
> It has a fix for the make build as well. Does it mean, it needs to be a different patch?

I could've applied the second hunk but actually it was one minute before the
release of 17.11.4. I'm sorry that I had to skip this patch for the release.

But, I've applied it (the second hunk only) to the stable/17.11 tree today.
Please check it out and let me know if there's an issue.  This will be included
in 17.11.5 (ETA is Nov).

FYI, the most favorable way is that you send patches with '[PATCH 17.11]' prefix
based on the latest stable/17.11 so that it is never forgotten.


Thanks,
Yongseok

>>> config/arm/meson.build | 3 ++-
>>> mk/rte.cpuflags.mk     | 2 +-
>>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/config/arm/meson.build b/config/arm/meson.build index
>>> 40dbc87..94cca49 100644
>>> --- a/config/arm/meson.build
>>> +++ b/config/arm/meson.build
>>> @@ -157,7 +157,8 @@ else
>>> endif
>>> message(machine_args)
>>> 
>>> -if cc.get_define('__ARM_NEON', args: machine_args) != ''
>>> +if (cc.get_define('__ARM_NEON', args: machine_args) != '' or
>>> +    cc.get_define('__aarch64__', args: machine_args) != '')
>>> 	dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1)
>>> 	compile_time_cpuflags += ['RTE_CPUFLAG_NEON'] endif diff --git 
>>> a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 6071313..43ed841
>>> 100644
>>> --- a/mk/rte.cpuflags.mk
>>> +++ b/mk/rte.cpuflags.mk
>>> @@ -89,7 +89,7 @@ CPUFLAGS += VSX
>>> endif
>>> 
>>> # ARM flags
>>> -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),)
>>> +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),)
>>> CPUFLAGS += NEON
>>> endif
>>> 
>>> --
>>> 2.7.4

Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

[Yongseok Koh]

> On Sep 4, 2018, at 11:41 AM, Yongseok Koh <yskoh@mellanox.com> wrote:
> 
>> 
>> On Sep 3, 2018, at 1:25 AM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
>> 
>> 
>> 
>> -----Original Message-----
>> From: Yongseok Koh <yskoh@mellanox.com> 
>> Sent: Sunday, September 2, 2018 7:00 PM
>> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
>> Cc: stable@dpdk.org; nd <nd@arm.com>
>> Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined
>> 
>>> On Sep 2, 2018, at 12:59 PM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
>>> 
>>> -----Original Message-----
>>> From: Yongseok Koh <yskoh@mellanox.com>
>>> Sent: Sunday, September 2, 2018 2:30 PM
>>> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
>>> Cc: stable@dpdk.org
>>> Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags 
>>> when __aarch64__ is defined
>>> 
>>>> On Sep 2, 2018, at 11:32 AM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
>>>> 
>>>> GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not 
>>>> optional for ArmV8. Hence NEON related code can be enabled when 
>>>> __aarch64__ is defined.
>>>> 
>>>> Bugzilla ID: 82
>>>> Cc: stable@dpdk.org
>>>> 
>>>> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
>>>> Reported-by: Thomas F Herbert <therbert@redhat.com>
>>>> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>>>> Reviewed-by: Phil Yang <phil.yang@arm.com>
>>>> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
>>>> Acked-by: Gavin Hu <gavin.hu@arm.com>
>>>> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>>>> ---
>>>> V2:
>>>> * Corrected the order of contribution tags
>>>> * Added Jerin's Ack
>>> 
>>> I didn't check out the details yet but a quick question.
>>> Do you want me to include this patch in 17.11.4?
>>> 
>>> Yes, please include.
>> 
>> I didn't realized that this is fixing the meson build.
>> 17.11 doesn't have that.
>> 
>> Thanks,
>> Yongseok
>> 
>> It has a fix for the make build as well. Does it mean, it needs to be a different patch?
> 
> I could've applied the second hunk but actually it was one minute before the
> release of 17.11.4. I'm sorry that I had to skip this patch for the release.
> 
> But, I've applied it (the second hunk only) to the stable/17.11 tree today.
> Please check it out and let me know if there's an issue.  This will be included
> in 17.11.5 (ETA is Nov).
> 
> FYI, the most favorable way is that you send patches with '[PATCH 17.11]' prefix
> based on the latest stable/17.11 so that it is never forgotten.

One more FYI.
Even though this was sent to stable (without dev@dpdk.org), as you have also sent
a same patch[1] to dev@dpdk.org, this will be queued for next stable releases anyway
once it is merged to dpdk/master.

[1] https://mails.dpdk.org/archives/dev/2018-September/110713.html

Thanks,
Yongseok

>>>> config/arm/meson.build | 3 ++-
>>>> mk/rte.cpuflags.mk     | 2 +-
>>>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>>> 
>>>> diff --git a/config/arm/meson.build b/config/arm/meson.build index
>>>> 40dbc87..94cca49 100644
>>>> --- a/config/arm/meson.build
>>>> +++ b/config/arm/meson.build
>>>> @@ -157,7 +157,8 @@ else
>>>> endif
>>>> message(machine_args)
>>>> 
>>>> -if cc.get_define('__ARM_NEON', args: machine_args) != ''
>>>> +if (cc.get_define('__ARM_NEON', args: machine_args) != '' or
>>>> +    cc.get_define('__aarch64__', args: machine_args) != '')
>>>> 	dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1)
>>>> 	compile_time_cpuflags += ['RTE_CPUFLAG_NEON'] endif diff --git 
>>>> a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 6071313..43ed841
>>>> 100644
>>>> --- a/mk/rte.cpuflags.mk
>>>> +++ b/mk/rte.cpuflags.mk
>>>> @@ -89,7 +89,7 @@ CPUFLAGS += VSX
>>>> endif
>>>> 
>>>> # ARM flags
>>>> -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),)
>>>> +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),)
>>>> CPUFLAGS += NEON
>>>> endif
>>>> 
>>>> --
>>>> 2.7.4

Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

[Thomas Monjalon]

04/09/2018 20:53, Yongseok Koh:
> 
> > On Sep 4, 2018, at 11:41 AM, Yongseok Koh <yskoh@mellanox.com> wrote:
> > 
> >> On Sep 3, 2018, at 1:25 AM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:

> >>> I didn't check out the details yet but a quick question.
> >>> Do you want me to include this patch in 17.11.4?
> >>> 
> >>> Yes, please include.
> >> 
> >> I didn't realized that this is fixing the meson build.
> >> 17.11 doesn't have that.
> >> 
> >> Thanks,
> >> Yongseok
> >> 
> >> It has a fix for the make build as well. Does it mean, it needs to be a different patch?
> > 
> > I could've applied the second hunk but actually it was one minute before the
> > release of 17.11.4. I'm sorry that I had to skip this patch for the release.
> > 
> > But, I've applied it (the second hunk only) to the stable/17.11 tree today.
> > Please check it out and let me know if there's an issue.  This will be included
> > in 17.11.5 (ETA is Nov).
> > 
> > FYI, the most favorable way is that you send patches with '[PATCH 17.11]' prefix
> > based on the latest stable/17.11 so that it is never forgotten.
> 
> One more FYI.
> Even though this was sent to stable (without dev@dpdk.org), as you have also sent
> a same patch[1] to dev@dpdk.org, this will be queued for next stable releases anyway
> once it is merged to dpdk/master.
> 
> [1] https://mails.dpdk.org/archives/dev/2018-September/110713.html

There is no reason to send this patch specifically to stable@dpdk.org.
The usual process is to wait the patch is applied on master, then backport it
on stable branches.

Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

[Honnappa Nagarahalli]

-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net> 
Sent: Sunday, September 16, 2018 3:16 AM
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: stable@dpdk.org; Yongseok Koh <yskoh@mellanox.com>; nd <nd@arm.com>
Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

04/09/2018 20:53, Yongseok Koh:
> 
> > On Sep 4, 2018, at 11:41 AM, Yongseok Koh <yskoh@mellanox.com> wrote:
> > 
> >> On Sep 3, 2018, at 1:25 AM, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:

> >>> I didn't check out the details yet but a quick question.
> >>> Do you want me to include this patch in 17.11.4?
> >>> 
> >>> Yes, please include.
> >> 
> >> I didn't realized that this is fixing the meson build.
> >> 17.11 doesn't have that.
> >> 
> >> Thanks,
> >> Yongseok
> >> 
> >> It has a fix for the make build as well. Does it mean, it needs to be a different patch?
> > 
> > I could've applied the second hunk but actually it was one minute 
> > before the release of 17.11.4. I'm sorry that I had to skip this patch for the release.
> > 
> > But, I've applied it (the second hunk only) to the stable/17.11 tree today.
> > Please check it out and let me know if there's an issue.  This will 
> > be included in 17.11.5 (ETA is Nov).
> > 
> > FYI, the most favorable way is that you send patches with '[PATCH 
> > 17.11]' prefix based on the latest stable/17.11 so that it is never forgotten.
> 
> One more FYI.
> Even though this was sent to stable (without dev@dpdk.org), as you 
> have also sent a same patch[1] to dev@dpdk.org, this will be queued 
> for next stable releases anyway once it is merged to dpdk/master.
> 
> [1] https://mails.dpdk.org/archives/dev/2018-September/110713.html

There is no reason to send this patch specifically to stable@dpdk.org.
The usual process is to wait the patch is applied on master, then backport it on stable branches.

My apologies. I seem to have misunderstood a comment (http://mails.dpdk.org/archives/dev/2018-August/110342.html). Do we send patches to stable@dpdk.org only when the patches are backported?

Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

[Luca Boccassi]

On Sun, 2018-09-16 at 14:40 +0000, Honnappa Nagarahalli wrote:
> 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net> 
> Sent: Sunday, September 16, 2018 3:16 AM
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Cc: stable@dpdk.org; Yongseok Koh <yskoh@mellanox.com>; nd <nd@arm.co
> m>
> Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags
> when __aarch64__ is defined
> 
> 04/09/2018 20:53, Yongseok Koh:
> > 
> > > On Sep 4, 2018, at 11:41 AM, Yongseok Koh <yskoh@mellanox.com>
> > > wrote:
> > > 
> > > > On Sep 3, 2018, at 1:25 AM, Honnappa Nagarahalli <Honnappa.Naga
> > > > rahalli@arm.com> wrote:
> > > > > I didn't check out the details yet but a quick question.
> > > > > Do you want me to include this patch in 17.11.4?
> > > > > 
> > > > > Yes, please include.
> > > > 
> > > > I didn't realized that this is fixing the meson build.
> > > > 17.11 doesn't have that.
> > > > 
> > > > Thanks,
> > > > Yongseok
> > > > 
> > > > It has a fix for the make build as well. Does it mean, it needs
> > > > to be a different patch?
> > > 
> > > I could've applied the second hunk but actually it was one
> > > minute 
> > > before the release of 17.11.4. I'm sorry that I had to skip this
> > > patch for the release.
> > > 
> > > But, I've applied it (the second hunk only) to the stable/17.11
> > > tree today.
> > > Please check it out and let me know if there's an issue.  This
> > > will 
> > > be included in 17.11.5 (ETA is Nov).
> > > 
> > > FYI, the most favorable way is that you send patches with
> > > '[PATCH 
> > > 17.11]' prefix based on the latest stable/17.11 so that it is
> > > never forgotten.
> > 
> > One more FYI.
> > Even though this was sent to stable (without dev@dpdk.org), as you 
> > have also sent a same patch[1] to dev@dpdk.org, this will be
> > queued 
> > for next stable releases anyway once it is merged to dpdk/master.
> > 
> > [1] https://mails.dpdk.org/archives/dev/2018-September/110713.html
> 
> There is no reason to send this patch specifically to stable@dpdk.org
> .
> The usual process is to wait the patch is applied on master, then
> backport it on stable branches.
> 
> My apologies. I seem to have misunderstood a comment (http://mails.dp
> dk.org/archives/dev/2018-August/110342.html). Do we send patches to
> stable@dpdk.org only when the patches are backported?

In the commit message itself, add:

Cc: stable@dpdk.org

in the text, and it will be considered automatically for backporting
once merged in master.
Only send directly to stable when asked, or when a bug affects only a
stable release but not master (and explain why).

-- 
Kind regards,
Luca Boccassi

[dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

[Honnappa Nagarahalli]

GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not
optional for ArmV8. Hence NEON related code can be enabled
when __aarch64__ is defined.

Bugzilla ID: 82
Cc: stable@dpdk.org

Reported-by: Raslan Darawsheh <rasland@mellanox.com>
Reported-by: Thomas F Herbert <therbert@redhat.com>
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
Acked-by: Gavin Hu <gavin.hu@arm.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
V2:
* Corrected the order of contribution tags
* Added Jerin's Ack

 config/arm/meson.build | 3 ++-
 mk/rte.cpuflags.mk     | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 40dbc87..94cca49 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -157,7 +157,8 @@ else
 endif
 message(machine_args)
 
-if cc.get_define('__ARM_NEON', args: machine_args) != ''
+if (cc.get_define('__ARM_NEON', args: machine_args) != '' or
+    cc.get_define('__aarch64__', args: machine_args) != '')
 	dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1)
 	compile_time_cpuflags += ['RTE_CPUFLAG_NEON']
 endif
diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk
index 6071313..43ed841 100644
--- a/mk/rte.cpuflags.mk
+++ b/mk/rte.cpuflags.mk
@@ -89,7 +89,7 @@ CPUFLAGS += VSX
 endif
 
 # ARM flags
-ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),)
+ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),)
 CPUFLAGS += NEON
 endif
 
-- 
2.7.4