* [dpdk-stable] [PATCH 01/11] log: fix plugin level restore with patterns
[not found] <1566214919-32250-1-git-send-email-david.marchand@redhat.com>
@ 2019-08-19 11:41 ` David Marchand
2019-08-19 12:30 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
0 siblings, 1 reply; 2+ messages in thread
From: David Marchand @ 2019-08-19 11:41 UTC (permalink / raw)
To: dev; +Cc: stable
Same fix as the commit 6ff0f81d0ef7 ("log: fix pattern matching"),
fnmatch returns 0 on success.
Fixes: 7f0bb634a140 ("log: add ability to match log type with globbing")
Fixes: 6ff0f81d0ef7 ("log: fix pattern matching")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_eal/common/eal_common_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
index 4f6f227..d9e5808 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -284,7 +284,7 @@ rte_log_register_type_and_pick_level(const char *name, uint32_t level_def)
continue;
if (opt_ll->pattern) {
- if (fnmatch(opt_ll->pattern, name, 0))
+ if (fnmatch(opt_ll->pattern, name, 0) == 0)
level = opt_ll->level;
} else {
if (regexec(&opt_ll->re_match, name, 0, NULL, 0) == 0)
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 01/11] log: fix plugin level restore with patterns
2019-08-19 11:41 ` [dpdk-stable] [PATCH 01/11] log: fix plugin level restore with patterns David Marchand
@ 2019-08-19 12:30 ` Andrew Rybchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Rybchenko @ 2019-08-19 12:30 UTC (permalink / raw)
To: David Marchand, dev; +Cc: stable
On 8/19/19 2:41 PM, David Marchand wrote:
> Same fix as the commit 6ff0f81d0ef7 ("log: fix pattern matching"),
> fnmatch returns 0 on success.
>
> Fixes: 7f0bb634a140 ("log: add ability to match log type with globbing")
> Fixes: 6ff0f81d0ef7 ("log: fix pattern matching")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-19 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1566214919-32250-1-git-send-email-david.marchand@redhat.com>
2019-08-19 11:41 ` [dpdk-stable] [PATCH 01/11] log: fix plugin level restore with patterns David Marchand
2019-08-19 12:30 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).