From: Thomas Monjalon <thomas@monjalon.net>
To: mohamad.noor.alim.hussin@intel.com
Cc: bruce.richardson@intel.com, david.marchand@redhat.com,
dev@dpdk.org, stable@dpdk.org, tianfei.zhang@intel.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] ifpga/base/meson: fix looking for librt
Date: Wed, 06 Oct 2021 16:14:59 +0200 [thread overview]
Message-ID: <4127306.4MfLQztJFr@thomas> (raw)
In-Reply-To: <20210928043610.52833-1-mohamad.noor.alim.hussin@intel.com>
28/09/2021 06:36, mohamad.noor.alim.hussin@intel.com:
> From: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
>
> Finding with "librt" keyword would give the output with
> full path of librt such as
> /usr/lib/gcc/x86_64-linux-gnu/7/../../../x86_64-linux-gnu/librt.so
> instead of -lrt in libdpdk.pc pkg-config file.
>
> Assume find_library() will prepend "lib", thus remove
> "lib" from "librt" keyword. The output will shows
> as -lrt.
>
> This will cause an issue when compile DPDK app with
> static library as the path of librt has been hard-coded
> in the libdpdk.pc file.
>
> Fixes: e41856b515ce ("raw/ifpga/base: enhance driver reliability in multi-process")
> Cc: tianfei.zhang@intel.com
> Cc: stable@dpdk.org
>
> Acked-by: Tianfei Zhang <tianfei.zhang@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Signed-off-by: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
Applied, thanks.
prev parent reply other threads:[~2021-10-06 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210630092613.70647-1-mohamad.noor.alim.hussin@intel.com>
2021-06-30 10:02 ` [dpdk-stable] [PATCH v2] " Xu, Rosen
2021-07-01 13:18 ` Zhang, Tianfei
2021-07-02 1:46 ` Hussin, Mohamad Noor Alim
2021-07-14 3:40 ` Zhang, Tianfei
2021-07-15 8:00 ` [dpdk-stable] [dpdk-dev] " David Marchand
2021-07-15 8:11 ` Bruce Richardson
2021-07-22 8:16 ` [dpdk-stable] " mohamad.noor.alim.hussin
2021-08-30 9:29 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2021-09-28 4:36 ` [dpdk-stable] [PATCH v3] " mohamad.noor.alim.hussin
2021-10-06 14:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4127306.4MfLQztJFr@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mohamad.noor.alim.hussin@intel.com \
--cc=stable@dpdk.org \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).