From: Thomas Monjalon <thomas@monjalon.net>
To: Junxiao Shi <git@mail1.yoursunny.com>
Cc: stable@dpdk.org, "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Loftus, Ciara" <ciara.loftus@intel.com>
Subject: Re: [PATCH] net/af_xdp: fix custom program loading with multiple queues
Date: Mon, 14 Mar 2022 09:41:40 +0100 [thread overview]
Message-ID: <4172267.ejJDZkT8p0@thomas> (raw)
In-Reply-To: <PH0PR11MB479194FFC0F1C127FBC7F5038E0C9@PH0PR11MB4791.namprd11.prod.outlook.com>
11/03/2022 12:12, Loftus, Ciara:
> >
> > 10/03/2022 09:49, Loftus, Ciara:
> > > > When the PMD is configured to load a custom XDP program, it sets
> > > > XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD flag to prevent libbpf from
> > > > loading its default XDP program. However, when queue_count is set to
> > > > greater than 1, this flag is only set for the first XSK socket but not
> > > > for subsequent XSK sockets. This causes XSK socket creation failure.
> > > >
> > > > This commit ensures that XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD flag
> > is
> > > > set for all XSK socket creations when custom XDP program is being used.
> > > >
> > > > Fixes: 01fa83c94d7e ("net/af_xdp: workaround custom program loading")
> > > >
> > > > Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
> > >
> > > Thanks for the patch!
> > > It's probably too late to make it into 22.03 but cc-ing stable as it should be
> > backported to 21.11.x.
> > >
> > > Acked-by: Ciara Loftus <ciara.loftus@intel.com>
> >
> > I can take it in -rc4. How much are you confident there is no regression?
> >
>
> Thanks. I am confident there is no regression.
Applied, thanks.
prev parent reply other threads:[~2022-03-14 8:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2c42e3e23c18fd60@cs.arizona.edu>
2022-03-10 8:49 ` Loftus, Ciara
2022-03-10 9:41 ` Kevin Traynor
2022-03-11 8:01 ` Thomas Monjalon
2022-03-11 11:12 ` Loftus, Ciara
2022-03-14 8:41 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4172267.ejJDZkT8p0@thomas \
--to=thomas@monjalon.net \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=git@mail1.yoursunny.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).