From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id AA63ADED for <stable@dpdk.org>; Tue, 1 May 2018 11:13:34 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E892E2244F; Tue, 1 May 2018 05:13:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 01 May 2018 05:13:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=aEBR3SLhyvRIFQR6/30c2eWj3w CTBNSqCliY8Xi8sCI=; b=Jvb3FVaTrShcchVkCyIi1yGp2dfpGo90ZRku5J8e7X R8NUwnfY/xNc1Oj+UEbmptt1fnNnTifup1Q7Hs4GbGYkRIT/cgIZl1ngcD+eF0oO tpZLGd8zgYikDjMdOt76IOPjDV/sXuWG+stzBsJMPJfngTTi+VV3DxXy+7BfqIRK s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=aEBR3S LhyvRIFQR6/30c2eWj3wCTBNSqCliY8Xi8sCI=; b=NARYqE6I4b8Fv3Gmf3+W1P mgj4GQS9Fyy6TkWE42WeZGUXb4MKSlephxLP9w19yXP/42PB+Df9S3SQgtMvSHyG jmrCBim7b9aeahGUSZTAMkQqkvAETPdyfnf8R3Njk9Kjg7zTWc2R3dSQ+BOw+dyH WbRz7B4IlGgshX7iP/q2F6tUJl09N4J0w7R2RUxUdT9/twJhX5lhJ5yRAlNBn+Ko q5fHPwku2se7XklFpTcMcbjvOPfEZx49bWff/WekklqYVtjRpNZCIJQWB54fJuLk TvE1UJ5CBEx7e+XrqCQMPlgWIywBo6Cp/jLMzJNgpCIQrE4w9jh+jpGUKwccWE9w == X-ME-Sender: <xms:vS_oWp27DT9ltj1jXA5hDBRn6sh-6yvEbF-IIGQFvZ-H70FGf3PWeg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6BE19E444A; Tue, 1 May 2018 05:13:33 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Luca Boccassi <bluca@debian.org> Cc: dpdk stable <stable@dpdk.org> Date: Tue, 01 May 2018 11:13:32 +0200 Message-ID: <4251108.LijWh7TDme@xps> In-Reply-To: <1525103008.23337.25.camel@debian.org> References: <20180430140606.4615-80-luca.boccassi@gmail.com> <12735445.Izu66BeJPl@xps> <1525103008.23337.25.camel@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] patch 'fix ethdev ports enumeration' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 01 May 2018 09:13:35 -0000 30/04/2018 17:43, Luca Boccassi: > On Mon, 2018-04-30 at 17:07 +0200, Thomas Monjalon wrote: > > 30/04/2018 16:41, luca.boccassi@gmail.com: > > > Hi, > > > > > > FYI, your patch has been queued to stable release 18.02.2 > > > > > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable > > > yet. > > > It will be pushed if I get no objections before 05/02/18. So please > > > shout if anyone has objections. > > > > I did not plan to backport it. But yes, it may be a good idead. > > In this case, you need to backport some fixes on top of it: > > net/mvpp2: fix build > > ethdev: remove experimental flag of ports enumeration > > Are you sure about those 2? The first one doesn't apply as there's no > mvpp2 in 18.02, and the second one changes the API True. After a second thought, I think you can try to get the below commit with existing experimental constraint (without above commit). > > > --- > > > From beef7e18559abf272f9ca0a4d1b62f8d32c47b02 Mon Sep 17 00:00:00 > > > 2001 > > > From: Thomas Monjalon <thomas@monjalon.net> > > > Date: Thu, 5 Apr 2018 17:33:20 +0200 > > > Subject: [PATCH] fix ethdev ports enumeration > > > > > > [ upstream commit 8728ccf37615904cf23fb8763895b05c9a3c6b0c ] > > > > > > Some DPDK applications wrongly assume these requirements: > > > - no hotplug, i.e. ports are never detached > > > - all allocated ports are available to the application > > > > > > Such application iterates over ports by its own mean. > > > The most common pattern is to request the port count and > > > assume ports with index in the range [0..count[ can be used. > > > > > > There are three consequences when using such wrong design: > > > - new ports having an index higher than the port count won't be > > > seen > > > - old ports being detached (RTE_ETH_DEV_UNUSED) can be seen as > > > ghosts > > > - failsafe sub-devices (RTE_ETH_DEV_DEFERRED) will be seen by > > > the application > > > > > > Such mistake will be less common with growing hotplug awareness. > > > All applications and examples inside this repository - except > > > testpmd - > > > must be fixed to use the iterator RTE_ETH_FOREACH_DEV. > > > > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > > > > > > > >