From: Thomas Monjalon <thomas@monjalon.net>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
stable@dpdk.org, "Liu, Yongxin" <yongxin.liu@windriver.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Laatz, Kevin" <kevin.laatz@intel.com>,
Chengwen Feng <fengchengwen@huawei.com>,
"Walsh, Conor" <conor.walsh@intel.com>
Subject: Re: [PATCH] dma/idxd: fix AVX2 code in non-datapath functions
Date: Tue, 21 Jun 2022 18:21:16 +0200 [thread overview]
Message-ID: <4253453.687JKscXgg@thomas> (raw)
In-Reply-To: <SA2PR11MB521067C14B9DCE6E23398AEEFFB09@SA2PR11MB5210.namprd11.prod.outlook.com>
20/06/2022 11:20, Walsh, Conor:
> > While all systems which will use the idxd driver for hardware will
> > support AVX2, if the driver is present the initialization functions e.g.
> > to register logs, will be called on all systems - irrespective of HW
> > support. This can cause issues if the system running DPDK does not have
> > AVX2, and the compiler has included AVX instructions in the
> > initialization code.
> >
> > To fix this, remove AVX2 instruction set from the whole build of the
> > driver. Instead, we add "target(avx2)" attribute to all datapath
> > functions, so those - and only those functions - will having AVX2
> > instructions in them.
> >
> > Bugzilla ID: 1038
> > Fixes: 3d36a0a1c7de ("dma/idxd: add data path job submission")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Conor Walsh <conor.walsh@intel.com>
Applied, thanks.
prev parent reply other threads:[~2022-06-21 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 10:59 Bruce Richardson
2022-06-20 9:20 ` Walsh, Conor
2022-06-21 16:21 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4253453.687JKscXgg@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=conor.walsh@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=kevin.laatz@intel.com \
--cc=stable@dpdk.org \
--cc=yongxin.liu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).