From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Timothy McDaniel <timothy.mcdaniel@intel.com>,
Kent Wires <kent.wires@intel.com>,
dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
stable@dpdk.org, Luca Boccassi <bluca@debian.org>,
Bruce Richardson <bruce.richardson@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [PATCH] event/dlb2: fix meson build
Date: Thu, 3 Nov 2022 16:22:41 +0000 [thread overview]
Message-ID: <42f937a0-d308-ed59-ba35-fe2124a72d09@amd.com> (raw)
In-Reply-To: <3277434.9LS3J3VOpE@thomas>
On 11/3/2022 3:35 PM, Thomas Monjalon wrote:
> 03/11/2022 16:22, Ferruh Yigit:
>> "meson setup" fails when '-Werror' compiler flag is enabled [1].
>> This is not a build error in the driver but a build error in meson
>> during "meson setup" stage.
>>
>> This issue exists for a while but meson takes it as a warning and
>> ignores it unless '-Werror' compiler flag is provided.
> [...]
>> Reproduced via `meson -Dc_args='-Werror' build`
>
> Is it different of 'meson --werror" as in devtools/test-meson-builds.sh
> or 'meson -Dwerror=true' as in .ci/linux-build.sh?
>
As I checked now, it seems there is a difference.
Via "meson --werror" & "meson -Dwerror=true",
'-Werror' flag is used to compile dpdk source code, but meson doesn't
use the flag for its internal logic, so this seems more proper usage.
Via "meson -Dc_args='-Werror'" & "CFLAGS='-Werror' meson" usage,
'-Werror' flag is used both to compile dpdk code and meson internal
logic, so that is why this usage cause build error.
And independent from the above usage difference, event/dlb2 meson file
is wrong and this fix is required.
I assume 'dlb2_avx512.c' compiled because of the '-mavx512vl' fallback
and that is why mentioned error is not detected.
next prev parent reply other threads:[~2022-11-03 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 15:22 Ferruh Yigit
2022-11-03 15:35 ` Thomas Monjalon
2022-11-03 16:22 ` Ferruh Yigit [this message]
2022-11-04 11:00 ` Jerin Jacob
2022-11-07 14:22 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42f937a0-d308-ed59-ba35-fe2124a72d09@amd.com \
--to=ferruh.yigit@amd.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=kent.wires@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=timothy.mcdaniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).