In RegEx device probing, there is register read trying after context device creation. When the reading fails, the context device was not freed what caused a memory leak. Free it. Fixes: f324162e8e77 ("regex/mlx5: support combined rule file") Cc: stable@dpdk.org Signed-off-by: Michael Baum <michaelba@nvidia.com> --- drivers/regex/mlx5/mlx5_regex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c index f17b6df47f..8866a4d0c6 100644 --- a/drivers/regex/mlx5/mlx5_regex.c +++ b/drivers/regex/mlx5/mlx5_regex.c @@ -171,7 +171,7 @@ mlx5_regex_dev_probe(struct rte_device *rte_dev) MLX5_RXP_CSR_IDENTIFIER, &val); if (ret) { DRV_LOG(ERR, "CSR read failed!"); - return -1; + goto dev_error; } if (val == MLX5_RXP_BF2_IDENTIFIER) priv->is_bf2 = 1; -- 2.25.1
From: Michael Baum
> In RegEx device probing, there is register read trying after context device
> creation.
>
> When the reading fails, the context device was not freed what caused a
> memory leak.
>
> Free it.
>
> Fixes: f324162e8e77 ("regex/mlx5: support combined rule file")
> Cc: stable@dpdk.org
>
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
> -----Original Message-----
> From: Michael Baum <michaelba@nvidia.com>
>
> In RegEx device probing, there is register read trying after context device
> creation.
>
> When the reading fails, the context device was not freed what caused a
> memory leak.
>
> Free it.
>
> Fixes: f324162e8e77 ("regex/mlx5: support combined rule file")
> Cc: stable@dpdk.org
>
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> ---
> drivers/regex/mlx5/mlx5_regex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regex/mlx5/mlx5_regex.c
> b/drivers/regex/mlx5/mlx5_regex.c index f17b6df47f..8866a4d0c6 100644
> --- a/drivers/regex/mlx5/mlx5_regex.c
> +++ b/drivers/regex/mlx5/mlx5_regex.c
> @@ -171,7 +171,7 @@ mlx5_regex_dev_probe(struct rte_device *rte_dev)
> MLX5_RXP_CSR_IDENTIFIER, &val);
> if (ret) {
> DRV_LOG(ERR, "CSR read failed!");
> - return -1;
> + goto dev_error;
> }
> if (val == MLX5_RXP_BF2_IDENTIFIER)
> priv->is_bf2 = 1;
> --
> 2.25.1
Thanks,
Acked-by: Ori Kam <orika@nvidia.com>
01/09/2021 10:11, Ori Kam:
> > From: Michael Baum <michaelba@nvidia.com>
> >
> > In RegEx device probing, there is register read trying after context device
> > creation.
> >
> > When the reading fails, the context device was not freed what caused a
> > memory leak.
> >
> > Free it.
> >
> > Fixes: f324162e8e77 ("regex/mlx5: support combined rule file")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Michael Baum <michaelba@nvidia.com>
>
> Thanks,
> Acked-by: Ori Kam <orika@nvidia.com>
Applied, thanks.
Title changed to:
regex/mlx5: fix leak after probing failure