* [dpdk-stable] [PATCH 1/2] mk: fix build on arm64
@ 2019-10-28 11:25 Ali Alnubani
2019-10-28 11:25 ` [dpdk-stable] [PATCH 2/2] mk: disable OcteonTx2 on old compilers Ali Alnubani
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Ali Alnubani @ 2019-10-28 11:25 UTC (permalink / raw)
To: dev; +Cc: jerinj, pbhagavatula, stable
OcteonTx was disabled for causing an internal compiler error on old gcc
versions.
See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers").
The condition that was added later to apply disabling OcteonTx
only on arm64 caused the condition to never be obeyed because it
compares ["arm64"] to [arm64].
This fixes the condition by using RTE_ARCH instead of CONFIG_RTE_ARCH,
because the former has the quotes removed, while the later doesn't.
Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64")
Cc: stable@dpdk.org
Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
mk/toolchain/gcc/rte.toolchain-compat.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
index ea40a11c0..00d6fd642 100644
--- a/mk/toolchain/gcc/rte.toolchain-compat.mk
+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
@@ -99,7 +99,7 @@ else
endif
# Disable octeontx event PMD for gcc < 4.8.6 & ARCH=arm64
- ifeq ($(CONFIG_RTE_ARCH), arm64)
+ ifeq ($(RTE_ARCH), arm64)
ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo 1), 1)
CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
--
2.23.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH 2/2] mk: disable OcteonTx2 on old compilers
2019-10-28 11:25 [dpdk-stable] [PATCH 1/2] mk: fix build on arm64 Ali Alnubani
@ 2019-10-28 11:25 ` Ali Alnubani
2019-10-30 11:49 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2019-10-28 16:34 ` [dpdk-stable] [dpdk-dev] [PATCH 1/2] mk: fix build on arm64 Thomas Monjalon
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Ali Alnubani @ 2019-10-28 11:25 UTC (permalink / raw)
To: dev; +Cc: jerinj, pbhagavatula, stable
This disables OcteonTx2 for gcc 4.8.5 as the compiler is
emitting "internal compiler error" for aarch64.
Fixes: 9a8864c8b5da ("net/octeontx2: add build and doc infrastructure")
Cc: stable@dpdk.org
Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
mk/toolchain/gcc/rte.toolchain-compat.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
index 00d6fd642..dd2c4e5da 100644
--- a/mk/toolchain/gcc/rte.toolchain-compat.mk
+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
@@ -104,6 +104,9 @@ else
CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d
+ CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV=d
+ CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL=d
+ CONFIG_RTE_LIBRTE_OCTEONTX2_PMD=d
endif
endif
--
2.23.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] mk: fix build on arm64
2019-10-28 11:25 [dpdk-stable] [PATCH 1/2] mk: fix build on arm64 Ali Alnubani
2019-10-28 11:25 ` [dpdk-stable] [PATCH 2/2] mk: disable OcteonTx2 on old compilers Ali Alnubani
@ 2019-10-28 16:34 ` Thomas Monjalon
2019-10-30 11:42 ` Jerin Jacob
2019-11-04 13:30 ` [dpdk-stable] [PATCH v2 " Ali Alnubani
3 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2019-10-28 16:34 UTC (permalink / raw)
To: Ali Alnubani; +Cc: dev, jerinj, pbhagavatula, stable
28/10/2019 12:25, Ali Alnubani:
> OcteonTx was disabled for causing an internal compiler error on old gcc
> versions.
> See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers").
>
> The condition that was added later to apply disabling OcteonTx
> only on arm64 caused the condition to never be obeyed because it
> compares ["arm64"] to [arm64].
>
> This fixes the condition by using RTE_ARCH instead of CONFIG_RTE_ARCH,
> because the former has the quotes removed, while the later doesn't.
>
> Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> ---
> - ifeq ($(CONFIG_RTE_ARCH), arm64)
> + ifeq ($(RTE_ARCH), arm64)
Acked-by: Thomas Monjalon <thomas@monjalon.net>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] mk: fix build on arm64
2019-10-28 11:25 [dpdk-stable] [PATCH 1/2] mk: fix build on arm64 Ali Alnubani
2019-10-28 11:25 ` [dpdk-stable] [PATCH 2/2] mk: disable OcteonTx2 on old compilers Ali Alnubani
2019-10-28 16:34 ` [dpdk-stable] [dpdk-dev] [PATCH 1/2] mk: fix build on arm64 Thomas Monjalon
@ 2019-10-30 11:42 ` Jerin Jacob
2019-11-04 13:30 ` [dpdk-stable] [PATCH v2 " Ali Alnubani
3 siblings, 0 replies; 8+ messages in thread
From: Jerin Jacob @ 2019-10-30 11:42 UTC (permalink / raw)
To: Ali Alnubani; +Cc: dpdk-dev, Jerin Jacob, Pavan Nikhilesh, stable
On Mon, Oct 28, 2019 at 4:56 PM Ali Alnubani <alialnu@mellanox.com> wrote:
>
> OcteonTx was disabled for causing an internal compiler error on old gcc
> versions.
> See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers").
>
> The condition that was added later to apply disabling OcteonTx
> only on arm64 caused the condition to never be obeyed because it
> compares ["arm64"] to [arm64].
>
> This fixes the condition by using RTE_ARCH instead of CONFIG_RTE_ARCH,
> because the former has the quotes removed, while the later doesn't.
>
> Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> mk/toolchain/gcc/rte.toolchain-compat.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
> index ea40a11c0..00d6fd642 100644
> --- a/mk/toolchain/gcc/rte.toolchain-compat.mk
> +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
> @@ -99,7 +99,7 @@ else
> endif
>
> # Disable octeontx event PMD for gcc < 4.8.6 & ARCH=arm64
> - ifeq ($(CONFIG_RTE_ARCH), arm64)
> + ifeq ($(RTE_ARCH), arm64)
> ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo 1), 1)
> CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
> CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] mk: disable OcteonTx2 on old compilers
2019-10-28 11:25 ` [dpdk-stable] [PATCH 2/2] mk: disable OcteonTx2 on old compilers Ali Alnubani
@ 2019-10-30 11:49 ` Jerin Jacob
0 siblings, 0 replies; 8+ messages in thread
From: Jerin Jacob @ 2019-10-30 11:49 UTC (permalink / raw)
To: Ali Alnubani; +Cc: dpdk-dev, Jerin Jacob, Pavan Nikhilesh, stable
On Mon, Oct 28, 2019 at 4:56 PM Ali Alnubani <alialnu@mellanox.com> wrote:
>
> This disables OcteonTx2 for gcc 4.8.5 as the compiler is
> emitting "internal compiler error" for aarch64.
>
> Fixes: 9a8864c8b5da ("net/octeontx2: add build and doc infrastructure")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> ---
> mk/toolchain/gcc/rte.toolchain-compat.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
> index 00d6fd642..dd2c4e5da 100644
> --- a/mk/toolchain/gcc/rte.toolchain-compat.mk
> +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
> @@ -104,6 +104,9 @@ else
> CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
> CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
> CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d
> + CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV=d
> + CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL=d
> + CONFIG_RTE_LIBRTE_OCTEONTX2_PMD=d
# Please add the following config also as there may be a connection in future
CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_CRYPTO=d
CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_DMA_RAWDEV=d
# s/OcteonTx2/OCTEON TX2/g in git commit and subject
With the above change:
Acked-by: Jerin Jacob <jerinj@marvell.com>
> endif
> endif
>
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH v2 1/2] mk: fix build on arm64
2019-10-28 11:25 [dpdk-stable] [PATCH 1/2] mk: fix build on arm64 Ali Alnubani
` (2 preceding siblings ...)
2019-10-30 11:42 ` Jerin Jacob
@ 2019-11-04 13:30 ` Ali Alnubani
2019-11-04 13:30 ` [dpdk-stable] [PATCH v2 2/2] mk: disable OCTEON TX2 on old compilers Ali Alnubani
3 siblings, 1 reply; 8+ messages in thread
From: Ali Alnubani @ 2019-11-04 13:30 UTC (permalink / raw)
To: dev; +Cc: jerinj, pbhagavatula, stable, Thomas Monjalon
OcteonTx was disabled for causing an internal compiler error on old gcc
versions.
See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers").
The condition that was added later to apply disabling OcteonTx
only on arm64 caused the condition to never be obeyed because it
compares ["arm64"] to [arm64].
This fixes the condition by using RTE_ARCH instead of CONFIG_RTE_ARCH,
because the former has the quotes removed, while the later doesn't.
Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64")
Cc: stable@dpdk.org
Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
mk/toolchain/gcc/rte.toolchain-compat.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
index ea40a11c0..00d6fd642 100644
--- a/mk/toolchain/gcc/rte.toolchain-compat.mk
+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
@@ -99,7 +99,7 @@ else
endif
# Disable octeontx event PMD for gcc < 4.8.6 & ARCH=arm64
- ifeq ($(CONFIG_RTE_ARCH), arm64)
+ ifeq ($(RTE_ARCH), arm64)
ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo 1), 1)
CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
--
2.23.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH v2 2/2] mk: disable OCTEON TX2 on old compilers
2019-11-04 13:30 ` [dpdk-stable] [PATCH v2 " Ali Alnubani
@ 2019-11-04 13:30 ` Ali Alnubani
2019-11-08 15:32 ` Thomas Monjalon
0 siblings, 1 reply; 8+ messages in thread
From: Ali Alnubani @ 2019-11-04 13:30 UTC (permalink / raw)
To: dev; +Cc: jerinj, pbhagavatula, stable
This disables OCTEON TX2 for gcc 4.8.5 as the compiler is
emitting "internal compiler error" for aarch64.
Fixes: 9a8864c8b5da ("net/octeontx2: add build and doc infrastructure")
Cc: stable@dpdk.org
Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
v2: Disabled configs PMD_OCTEONTX2_CRYPTO & PMD_OCTEONTX2_DMA_RAWDEV.
mk/toolchain/gcc/rte.toolchain-compat.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
index 00d6fd642..41c18f525 100644
--- a/mk/toolchain/gcc/rte.toolchain-compat.mk
+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
@@ -104,6 +104,11 @@ else
CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d
+ CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_DMA_RAWDEV=d
+ CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV=d
+ CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_CRYPTO=d
+ CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL=d
+ CONFIG_RTE_LIBRTE_OCTEONTX2_PMD=d
endif
endif
--
2.23.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [PATCH v2 2/2] mk: disable OCTEON TX2 on old compilers
2019-11-04 13:30 ` [dpdk-stable] [PATCH v2 2/2] mk: disable OCTEON TX2 on old compilers Ali Alnubani
@ 2019-11-08 15:32 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2019-11-08 15:32 UTC (permalink / raw)
To: Ali Alnubani; +Cc: stable, dev, jerinj, pbhagavatula
04/11/2019 14:30, Ali Alnubani:
> This disables OCTEON TX2 for gcc 4.8.5 as the compiler is
> emitting "internal compiler error" for aarch64.
>
> Fixes: 9a8864c8b5da ("net/octeontx2: add build and doc infrastructure")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-11-08 15:33 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-28 11:25 [dpdk-stable] [PATCH 1/2] mk: fix build on arm64 Ali Alnubani
2019-10-28 11:25 ` [dpdk-stable] [PATCH 2/2] mk: disable OcteonTx2 on old compilers Ali Alnubani
2019-10-30 11:49 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2019-10-28 16:34 ` [dpdk-stable] [dpdk-dev] [PATCH 1/2] mk: fix build on arm64 Thomas Monjalon
2019-10-30 11:42 ` Jerin Jacob
2019-11-04 13:30 ` [dpdk-stable] [PATCH v2 " Ali Alnubani
2019-11-04 13:30 ` [dpdk-stable] [PATCH v2 2/2] mk: disable OCTEON TX2 on old compilers Ali Alnubani
2019-11-08 15:32 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).