From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] mempool: fix anonymous populate
Date: Mon, 20 Jan 2020 11:08:49 +0100 [thread overview]
Message-ID: <4388597.neEnAmRlxL@xps> (raw)
In-Reply-To: <20200117143429.10120-1-olivier.matz@6wind.com>
17/01/2020 15:34, Olivier Matz:
> The documentation says that a negative errno is returned on error, but
> in most places that's not the case.
>
> Fix the documentation and the exceptions in code. The second one
> (return from populate_virt) also fixes a memory leak.
>
> Note that testpmd was using the function correctly.
>
> Fixes: aa10457eb4c2 ("mempool: make mempool populate and free api public")
> Fixes: 6780f72fb82f ("mempool: populate with anonymous memory")
> Fixes: 66e7ba0bad4c ("mempool: ensure mempool is initialized before populating")
> Cc: stable@dpdk.org
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
prev parent reply other threads:[~2020-01-20 10:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 14:34 [dpdk-stable] " Olivier Matz
2020-01-20 10:08 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4388597.neEnAmRlxL@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).