* [dpdk-stable] [PATCH v3] sched : fix traffic class oversubscription parameter
[not found] <20210309161002.31384-1-savinay.dharmappa@intel.com>
@ 2021-04-21 6:50 ` Savinay Dharmappa
2021-04-21 14:53 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-04-21 15:24 ` [dpdk-stable] " Dumitrescu, Cristian
0 siblings, 2 replies; 3+ messages in thread
From: Savinay Dharmappa @ 2021-04-21 6:50 UTC (permalink / raw)
To: dev, jasvinder.singh, cristian.dumitrescu; +Cc: savinay.dharmappa, stable
This patch fixes the traffic class oversubscription watermark
value by initialising it with computed value of maximum watermark.
Fixes: ac6fcb841b0f ("sched: update subport rate dynamically")
Cc: stable@dpdk.org
Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
v3: update the title.
---
lib/librte_sched/rte_sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
index 7c56880681..cd87e688e4 100644
--- a/lib/librte_sched/rte_sched.c
+++ b/lib/librte_sched/rte_sched.c
@@ -1249,7 +1249,6 @@ rte_sched_subport_config(struct rte_sched_port *port,
#ifdef RTE_SCHED_SUBPORT_TC_OV
/* TC oversubscription */
s->tc_ov_wm_min = port->mtu;
- s->tc_ov_wm = s->tc_ov_wm_max;
s->tc_ov_period_id = 0;
s->tc_ov = 0;
s->tc_ov_n = 0;
@@ -1277,6 +1276,7 @@ rte_sched_subport_config(struct rte_sched_port *port,
#ifdef RTE_SCHED_SUBPORT_TC_OV
s->tc_ov_wm_max = rte_sched_time_ms_to_bytes(profile->tc_period,
s->pipe_tc_be_rate_max);
+ s->tc_ov_wm = s->tc_ov_wm_max;
#endif
s->profile = subport_profile_id;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter
2021-04-21 6:50 ` [dpdk-stable] [PATCH v3] sched : fix traffic class oversubscription parameter Savinay Dharmappa
@ 2021-04-21 14:53 ` Thomas Monjalon
2021-04-21 15:24 ` [dpdk-stable] " Dumitrescu, Cristian
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-04-21 14:53 UTC (permalink / raw)
To: Savinay Dharmappa; +Cc: dev, jasvinder.singh, cristian.dumitrescu, stable
21/04/2021 08:50, Savinay Dharmappa:
> This patch fixes the traffic class oversubscription watermark
> value by initialising it with computed value of maximum watermark.
>
> Fixes: ac6fcb841b0f ("sched: update subport rate dynamically")
> Cc: stable@dpdk.org
>
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH v3] sched : fix traffic class oversubscription parameter
2021-04-21 6:50 ` [dpdk-stable] [PATCH v3] sched : fix traffic class oversubscription parameter Savinay Dharmappa
2021-04-21 14:53 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
@ 2021-04-21 15:24 ` Dumitrescu, Cristian
1 sibling, 0 replies; 3+ messages in thread
From: Dumitrescu, Cristian @ 2021-04-21 15:24 UTC (permalink / raw)
To: Dharmappa, Savinay, dev, Singh, Jasvinder; +Cc: stable
> -----Original Message-----
> From: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Sent: Wednesday, April 21, 2021 7:50 AM
> To: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>;
> Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: Dharmappa, Savinay <savinay.dharmappa@intel.com>; stable@dpdk.org
> Subject: [PATCH v3] sched : fix traffic class oversubscription parameter
>
> This patch fixes the traffic class oversubscription watermark
> value by initialising it with computed value of maximum watermark.
>
> Fixes: ac6fcb841b0f ("sched: update subport rate dynamically")
> Cc: stable@dpdk.org
>
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
> v3: update the title.
> ---
> lib/librte_sched/rte_sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
> index 7c56880681..cd87e688e4 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -1249,7 +1249,6 @@ rte_sched_subport_config(struct rte_sched_port
> *port,
> #ifdef RTE_SCHED_SUBPORT_TC_OV
> /* TC oversubscription */
> s->tc_ov_wm_min = port->mtu;
> - s->tc_ov_wm = s->tc_ov_wm_max;
> s->tc_ov_period_id = 0;
> s->tc_ov = 0;
> s->tc_ov_n = 0;
> @@ -1277,6 +1276,7 @@ rte_sched_subport_config(struct rte_sched_port
> *port,
> #ifdef RTE_SCHED_SUBPORT_TC_OV
> s->tc_ov_wm_max = rte_sched_time_ms_to_bytes(profile-
> >tc_period,
> s-
> >pipe_tc_be_rate_max);
> + s->tc_ov_wm = s->tc_ov_wm_max;
> #endif
> s->profile = subport_profile_id;
>
> --
> 2.17.1
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-21 15:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210309161002.31384-1-savinay.dharmappa@intel.com>
2021-04-21 6:50 ` [dpdk-stable] [PATCH v3] sched : fix traffic class oversubscription parameter Savinay Dharmappa
2021-04-21 14:53 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-04-21 15:24 ` [dpdk-stable] " Dumitrescu, Cristian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).