* Re: [dpdk-stable] [PATCH] bus/pci: fix unknown NUMA node value on Windows
2021-09-27 18:43 [dpdk-stable] [PATCH] bus/pci: fix unknown NUMA node value on Windows Pallavi Kadam
@ 2021-09-27 18:29 ` Menon, Ranjit
2021-09-27 18:34 ` Menon, Ranjit
1 sibling, 0 replies; 4+ messages in thread
From: Menon, Ranjit @ 2021-09-27 18:29 UTC (permalink / raw)
To: Pallavi Kadam, dev
Cc: stable, thomas, talshn, dmitry.kozliuk, Narcisa.Vasile, Vipin.Varghese
On 9/27/2021 11:43 AM, Pallavi Kadam wrote:
> Based on the rte_eth_dev_socket_id() documentation,
> set the default numa_node to -1. When the API is unsuccessful,
> set numa_node to 0.
> This change more correctly resembles the Linux code.
>
> Fixes: bf7cf1f947bd ("bus/pci: fix unknown NUMA node value on Windows")
> Cc: stable@dpdk.org
>
> Reported-by: Vipin Varghese <vipin.varghese@intel.com>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> ---
> drivers/bus/pci/windows/pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
> index 343ef6f33b..644c452c76 100644
> --- a/drivers/bus/pci/windows/pci.c
> +++ b/drivers/bus/pci/windows/pci.c
> @@ -237,6 +237,7 @@ get_device_resource_info(HDEVINFO dev_info,
> }
>
> /* Get NUMA node using DEVPKEY_Device_Numa_Node */
> + dev->device.numa_node = SOCKET_ID_ANY;
> res = SetupDiGetDevicePropertyW(dev_info, dev_info_data,
> &DEVPKEY_Device_Numa_Node, &property_type,
> (BYTE *)&numa_node, sizeof(numa_node), NULL, 0);
> @@ -244,7 +245,7 @@ get_device_resource_info(HDEVINFO dev_info,
> DWORD error = GetLastError();
> if (error == ERROR_NOT_FOUND) {
> /* On older CPUs, NUMA is not bound to PCIe locality. */
> - dev->device.numa_node = SOCKET_ID_ANY;
> + dev->device.numa_node = 0;
> return ERROR_SUCCESS;
> }
> RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW"
Acked-by: Ranjit Menon <ranjit.menon@intel.com
<mailto:ranjit.menon@intel.com>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH] bus/pci: fix unknown NUMA node value on Windows
2021-09-27 18:43 [dpdk-stable] [PATCH] bus/pci: fix unknown NUMA node value on Windows Pallavi Kadam
2021-09-27 18:29 ` Menon, Ranjit
@ 2021-09-27 18:34 ` Menon, Ranjit
2021-09-30 16:22 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Menon, Ranjit @ 2021-09-27 18:34 UTC (permalink / raw)
To: Pallavi Kadam, dev
Cc: stable, thomas, talshn, dmitry.kozliuk, Narcisa.Vasile, Vipin.Varghese
(Sending the ACK again since Outlook appeared to make the email address
a smart link!)
On 9/27/2021 11:43 AM, Pallavi Kadam wrote:
> Based on the rte_eth_dev_socket_id() documentation,
> set the default numa_node to -1. When the API is unsuccessful,
> set numa_node to 0.
> This change more correctly resembles the Linux code.
>
> Fixes: bf7cf1f947bd ("bus/pci: fix unknown NUMA node value on Windows")
> Cc: stable@dpdk.org
>
> Reported-by: Vipin Varghese <vipin.varghese@intel.com>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> ---
> drivers/bus/pci/windows/pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
> index 343ef6f33b..644c452c76 100644
> --- a/drivers/bus/pci/windows/pci.c
> +++ b/drivers/bus/pci/windows/pci.c
> @@ -237,6 +237,7 @@ get_device_resource_info(HDEVINFO dev_info,
> }
>
> /* Get NUMA node using DEVPKEY_Device_Numa_Node */
> + dev->device.numa_node = SOCKET_ID_ANY;
> res = SetupDiGetDevicePropertyW(dev_info, dev_info_data,
> &DEVPKEY_Device_Numa_Node, &property_type,
> (BYTE *)&numa_node, sizeof(numa_node), NULL, 0);
> @@ -244,7 +245,7 @@ get_device_resource_info(HDEVINFO dev_info,
> DWORD error = GetLastError();
> if (error == ERROR_NOT_FOUND) {
> /* On older CPUs, NUMA is not bound to PCIe locality. */
> - dev->device.numa_node = SOCKET_ID_ANY;
> + dev->device.numa_node = 0;
> return ERROR_SUCCESS;
> }
> RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW"
Acked-by: Ranjit Menon <ranjit.menon@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH] bus/pci: fix unknown NUMA node value on Windows
@ 2021-09-27 18:43 Pallavi Kadam
2021-09-27 18:29 ` Menon, Ranjit
2021-09-27 18:34 ` Menon, Ranjit
0 siblings, 2 replies; 4+ messages in thread
From: Pallavi Kadam @ 2021-09-27 18:43 UTC (permalink / raw)
To: dev
Cc: stable, thomas, talshn, dmitry.kozliuk, ranjit.menon,
Narcisa.Vasile, Vipin.Varghese, pallavi.kadam
Based on the rte_eth_dev_socket_id() documentation,
set the default numa_node to -1. When the API is unsuccessful,
set numa_node to 0.
This change more correctly resembles the Linux code.
Fixes: bf7cf1f947bd ("bus/pci: fix unknown NUMA node value on Windows")
Cc: stable@dpdk.org
Reported-by: Vipin Varghese <vipin.varghese@intel.com>
Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
---
drivers/bus/pci/windows/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
index 343ef6f33b..644c452c76 100644
--- a/drivers/bus/pci/windows/pci.c
+++ b/drivers/bus/pci/windows/pci.c
@@ -237,6 +237,7 @@ get_device_resource_info(HDEVINFO dev_info,
}
/* Get NUMA node using DEVPKEY_Device_Numa_Node */
+ dev->device.numa_node = SOCKET_ID_ANY;
res = SetupDiGetDevicePropertyW(dev_info, dev_info_data,
&DEVPKEY_Device_Numa_Node, &property_type,
(BYTE *)&numa_node, sizeof(numa_node), NULL, 0);
@@ -244,7 +245,7 @@ get_device_resource_info(HDEVINFO dev_info,
DWORD error = GetLastError();
if (error == ERROR_NOT_FOUND) {
/* On older CPUs, NUMA is not bound to PCIe locality. */
- dev->device.numa_node = SOCKET_ID_ANY;
+ dev->device.numa_node = 0;
return ERROR_SUCCESS;
}
RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW"
--
2.31.1.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH] bus/pci: fix unknown NUMA node value on Windows
2021-09-27 18:34 ` Menon, Ranjit
@ 2021-09-30 16:22 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2021-09-30 16:22 UTC (permalink / raw)
To: Pallavi Kadam
Cc: dev, stable, talshn, dmitry.kozliuk, Narcisa.Vasile,
Vipin.Varghese, Menon, Ranjit
27/09/2021 20:34, Menon, Ranjit:
> On 9/27/2021 11:43 AM, Pallavi Kadam wrote:
> > Based on the rte_eth_dev_socket_id() documentation,
> > set the default numa_node to -1. When the API is unsuccessful,
> > set numa_node to 0.
> > This change more correctly resembles the Linux code.
> >
> > Fixes: bf7cf1f947bd ("bus/pci: fix unknown NUMA node value on Windows")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Vipin Varghese <vipin.varghese@intel.com>
> > Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
>
> Acked-by: Ranjit Menon <ranjit.menon@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-30 16:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 18:43 [dpdk-stable] [PATCH] bus/pci: fix unknown NUMA node value on Windows Pallavi Kadam
2021-09-27 18:29 ` Menon, Ranjit
2021-09-27 18:34 ` Menon, Ranjit
2021-09-30 16:22 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).