patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Trahe, Fiona" <fiona.trahe@intel.com>,
	"Dybkowski, AdamX" <adamx.dybkowski@intel.com>,
	Akhil Goyal <akhil.goyal@nxp.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] common/qat: fix uninitialized variable bug
Date: Wed, 29 Jul 2020 15:19:16 +0200	[thread overview]
Message-ID: <4451101.0yOHXH3JGe@thomas> (raw)
In-Reply-To: <VI1PR04MB316817C5743C98EACAA2FD22E6750@VI1PR04MB3168.eurprd04.prod.outlook.com>

26/07/2020 21:19, Akhil Goyal:
> > >
> > > [Adam] The ret variable value (signed) is not returned directly, please check the
> > rest of this function in src
> > > code. This is just checked to calculate how many ops were enqueued. And if all
> > checks skip (meaning the
> > > op was not processed by sym crypto, asym crypto nor compression), we
> > should note the user that the
> > > actual op was NOT enqueued. That's why ret is set to -1.
> > [Fiona] ok. makes sense thanks. In that case
> > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> 
> Cc: stable@dpdk.org
> 
> Applied to dpdk-next-crypto


This patch should not have been merged.
The explanation is missing.

This is the commit log:
"This patch fixes the uninitialized variable bug in QAT PMD."

We don't even know what is the consequence and the scope.
That's not acceptable for a fix.



      reply	other threads:[~2020-07-29 13:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200724094010.1025-1-adamx.dybkowski@intel.com>
     [not found] ` <SN6PR11MB28809B1E596D8C13E0A5E67AE4770@SN6PR11MB2880.namprd11.prod.outlook.com>
     [not found]   ` <BY5PR11MB3910FDACA0105A48C7690050ED770@BY5PR11MB3910.namprd11.prod.outlook.com>
     [not found]     ` <SN6PR11MB2880FBB5D2F3AE513895D10EE4770@SN6PR11MB2880.namprd11.prod.outlook.com>
2020-07-26 19:19       ` [dpdk-stable] " Akhil Goyal
2020-07-29 13:19         ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4451101.0yOHXH3JGe@thomas \
    --to=thomas@monjalon.net \
    --cc=adamx.dybkowski@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).