* Re: [dpdk-stable] [PATCH] common/qat: fix uninitialized variable bug [not found] ` <SN6PR11MB2880FBB5D2F3AE513895D10EE4770@SN6PR11MB2880.namprd11.prod.outlook.com> @ 2020-07-26 19:19 ` Akhil Goyal 2020-07-29 13:19 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon 0 siblings, 1 reply; 2+ messages in thread From: Akhil Goyal @ 2020-07-26 19:19 UTC (permalink / raw) To: Trahe, Fiona, Dybkowski, AdamX, dev; +Cc: stable > > > > [Adam] The ret variable value (signed) is not returned directly, please check the > rest of this function in src > > code. This is just checked to calculate how many ops were enqueued. And if all > checks skip (meaning the > > op was not processed by sym crypto, asym crypto nor compression), we > should note the user that the > > actual op was NOT enqueued. That's why ret is set to -1. > [Fiona] ok. makes sense thanks. In that case > Acked-by: Fiona Trahe <fiona.trahe@intel.com> Cc: stable@dpdk.org Applied to dpdk-next-crypto Thanks ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] common/qat: fix uninitialized variable bug 2020-07-26 19:19 ` [dpdk-stable] [PATCH] common/qat: fix uninitialized variable bug Akhil Goyal @ 2020-07-29 13:19 ` Thomas Monjalon 0 siblings, 0 replies; 2+ messages in thread From: Thomas Monjalon @ 2020-07-29 13:19 UTC (permalink / raw) To: Trahe, Fiona, Dybkowski, AdamX, Akhil Goyal; +Cc: dev, stable 26/07/2020 21:19, Akhil Goyal: > > > > > > [Adam] The ret variable value (signed) is not returned directly, please check the > > rest of this function in src > > > code. This is just checked to calculate how many ops were enqueued. And if all > > checks skip (meaning the > > > op was not processed by sym crypto, asym crypto nor compression), we > > should note the user that the > > > actual op was NOT enqueued. That's why ret is set to -1. > > [Fiona] ok. makes sense thanks. In that case > > Acked-by: Fiona Trahe <fiona.trahe@intel.com> > > Cc: stable@dpdk.org > > Applied to dpdk-next-crypto This patch should not have been merged. The explanation is missing. This is the commit log: "This patch fixes the uninitialized variable bug in QAT PMD." We don't even know what is the consequence and the scope. That's not acceptable for a fix. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-29 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200724094010.1025-1-adamx.dybkowski@intel.com>
[not found] ` <SN6PR11MB28809B1E596D8C13E0A5E67AE4770@SN6PR11MB2880.namprd11.prod.outlook.com>
[not found] ` <BY5PR11MB3910FDACA0105A48C7690050ED770@BY5PR11MB3910.namprd11.prod.outlook.com>
[not found] ` <SN6PR11MB2880FBB5D2F3AE513895D10EE4770@SN6PR11MB2880.namprd11.prod.outlook.com>
2020-07-26 19:19 ` [dpdk-stable] [PATCH] common/qat: fix uninitialized variable bug Akhil Goyal
2020-07-29 13:19 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).