From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: dpdk stable <stable@dpdk.org>, Martin Harvey <mharvey@solarflare.com>
Subject: Re: [dpdk-stable] [PATCH 17.11 3/3] net/sfc/base: fix PreFAST warnings because of unused return
Date: Mon, 21 Jan 2019 09:59:07 +0300 [thread overview]
Message-ID: <4470fbb8-d0f0-ea2b-8a3e-743243343109@solarflare.com> (raw)
In-Reply-To: <862A9DB5-B963-403C-991C-305DA2E19FF9@mellanox.com>
On 1/19/19 3:42 AM, Yongseok Koh wrote:
>> On Jan 18, 2019, at 7:59 AM, Andrew Rybchenko <arybchenko@solarflare.com> wrote:
>>
>> From: Martin Harvey <mharvey@solarflare.com>
>>
>> [ backported from upstream commit f394c63d2d33449443a42e86da826c38e98d59b3 ]
>>
>> Fixes: 19b64c6ac35f ("net/sfc/base: import libefx base")
>> Fixes: d96a34d165b1 ("net/sfc/base: import NVRAM support")
>> Fixes: e7cd430c864f ("net/sfc/base: import SFN7xxx family support")
>>
>> Signed-off-by: Martin Harvey <mharvey@solarflare.com>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
> Compilation failed. Two errors for the label.
>
> drivers/net/sfc/base/ef10_filter.c: In function ‘ef10_filter_insert_all_multicast’:
> drivers/net/sfc/base/ef10_filter.c:1247:3: error: label ‘fail2’ used but not defined
> goto fail2;
> ^
> drivers/net/sfc/base/ef10_filter.c: In function ‘ef10_filter_get_workarounds’:
> drivers/net/sfc/base/ef10_filter.c:1409:1: error: label ‘fail2’ defined but not used [-Werror=unused-label]
> fail2:
> ^
> cc1: all warnings being treated as errors
> make[4]: *** [ef10_filter.o] Error 1
I'm sorry for it - forgot to refresh the patch before sending.
Thanks a lot,
Andrew.
next prev parent reply other threads:[~2019-01-21 6:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 15:59 [dpdk-stable] [PATCH 17.11 1/3] net/sfc/base: remove Falcon-specific concurrency check Andrew Rybchenko
2019-01-18 15:59 ` [dpdk-stable] [PATCH 17.11 2/3] net/sfc/base: fix out of bounds read when dereferencing sdup Andrew Rybchenko
2019-01-18 15:59 ` [dpdk-stable] [PATCH 17.11 3/3] net/sfc/base: fix PreFAST warnings because of unused return Andrew Rybchenko
2019-01-19 0:42 ` Yongseok Koh
2019-01-21 6:59 ` Andrew Rybchenko [this message]
2019-01-21 6:58 ` [dpdk-stable] [PATCH 17.11 v2 1/3] net/sfc/base: remove Falcon-specific concurrency check Andrew Rybchenko
2019-01-21 6:58 ` [dpdk-stable] [PATCH 17.11 v2 2/3] net/sfc/base: fix out of bounds read when dereferencing sdup Andrew Rybchenko
2019-01-21 6:58 ` [dpdk-stable] [PATCH 17.11 v2 3/3] net/sfc/base: fix PreFAST warnings because of unused return Andrew Rybchenko
2019-01-22 7:38 ` [dpdk-stable] [PATCH 17.11 v2 1/3] net/sfc/base: remove Falcon-specific concurrency check Yongseok Koh
2019-01-22 7:38 ` Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4470fbb8-d0f0-ea2b-8a3e-743243343109@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=mharvey@solarflare.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).