From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 6E3A34CA6 for ; Mon, 21 Jan 2019 07:59:18 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 42D6D980053; Mon, 21 Jan 2019 06:59:17 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 21 Jan 2019 06:59:11 +0000 To: Yongseok Koh CC: dpdk stable , Martin Harvey References: <1547827150-26208-1-git-send-email-arybchenko@solarflare.com> <1547827150-26208-3-git-send-email-arybchenko@solarflare.com> <862A9DB5-B963-403C-991C-305DA2E19FF9@mellanox.com> From: Andrew Rybchenko Message-ID: <4470fbb8-d0f0-ea2b-8a3e-743243343109@solarflare.com> Date: Mon, 21 Jan 2019 09:59:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <862A9DB5-B963-403C-991C-305DA2E19FF9@mellanox.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24378.003 X-TM-AS-Result: No-9.526300-8.000000-10 X-TMASE-MatchedRID: pBwXUM+nCwsOwH4pD14DsPHkpkyUphL9X5TqQagR07fgnPSamzwyJgX3 landsdtjMH15E661CBOWDdA25oOVzKEv3c3lVecUolVO7uyOCDUu+gIp3UuevMOtrkhuZC9Wx/T z8B+VV2shJ/ufappeEl+24nCsUSFNt7DW3B48kkHdB/CxWTRRu4as+d5/8j56abj5T47HjHQEMq aWpWeGKddkAE/3ytPQArxJIdmFU3p2madUWCN/8Q== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--9.526300-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24378.003 X-MDID: 1548053958-xnCPKImIrzu4 Subject: Re: [dpdk-stable] [PATCH 17.11 3/3] net/sfc/base: fix PreFAST warnings because of unused return X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 06:59:18 -0000 On 1/19/19 3:42 AM, Yongseok Koh wrote: >> On Jan 18, 2019, at 7:59 AM, Andrew Rybchenko wrote: >> >> From: Martin Harvey >> >> [ backported from upstream commit f394c63d2d33449443a42e86da826c38e98d59b3 ] >> >> Fixes: 19b64c6ac35f ("net/sfc/base: import libefx base") >> Fixes: d96a34d165b1 ("net/sfc/base: import NVRAM support") >> Fixes: e7cd430c864f ("net/sfc/base: import SFN7xxx family support") >> >> Signed-off-by: Martin Harvey >> Signed-off-by: Andrew Rybchenko >> --- > Compilation failed. Two errors for the label. > > drivers/net/sfc/base/ef10_filter.c: In function ‘ef10_filter_insert_all_multicast’: > drivers/net/sfc/base/ef10_filter.c:1247:3: error: label ‘fail2’ used but not defined > goto fail2; > ^ > drivers/net/sfc/base/ef10_filter.c: In function ‘ef10_filter_get_workarounds’: > drivers/net/sfc/base/ef10_filter.c:1409:1: error: label ‘fail2’ defined but not used [-Werror=unused-label] > fail2: > ^ > cc1: all warnings being treated as errors > make[4]: *** [ef10_filter.o] Error 1 I'm sorry for it - forgot to refresh the patch before sending. Thanks a lot, Andrew.