From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9C4142C54 for ; Wed, 7 Jun 2023 20:47:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B90C142D1A; Wed, 7 Jun 2023 20:47:15 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2051.outbound.protection.outlook.com [40.107.223.51]) by mails.dpdk.org (Postfix) with ESMTP id 248EC41611; Wed, 7 Jun 2023 20:47:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UGTgxhPfvGoUOs7bL8U69eWklrL78EijnMFv/Kozig85oRKciEehrwQFo7FzvXH/6oGwhlqgkucjGsGXHXNQezWVz88IhVJh5TAl8zk9a6x1FkPMVraxUI/FCMSqO5XL1oVFJFFsZEwoE13zDd85N/c1T9135R4eWzUKL0BJA/ZBSx8mzWSd6XnCZih9BfvPATdKAdCxZUxbblNamM7PimmTVFnh6OsvOp5uOsfTlO5m9pse8qJHRBMqOWQh+XtKry2zdp+OnVCMI8z/FLH77fFMz32z+V2Vf0UhVeLL/Q0702k16EXmR+IUAAU6IZtelwSLXXGd2hhOxPnSTZ2t2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bscnSoHQzv61zOwthCHH2i+vERC4vVzsX7kp0/araIE=; b=h/JJp5WNVQgzFFIoY06ZUwwz5vH1WUfy+oLclz81zfjusnmhuf6P5x5Mmw5DcRINh5sOJ8TMHAu4y5REInrtLu3i9x/pHV1DzsQCjwnJ/gXuW0+9zG1w2WrvKOQHwpVy+fs9hIyc+0DijMB70KYX/aAjjFSC9zjN+bGRhGSNwtipX9dOoflilfTvhFH6TArBRF3RmMzrCxlWmMgwm1vWOKriJnPB5PN90JG6IciE29GiUuzN1jM8Gpd4VNIzHAcr6WbSRa/WYCGUqYKQOvP9YEeV+a+ty8Vf+tsFpB5YqzjGfunwBEY1irCFlOJDTcuUxqvfeeelOWtgXwny4ieTqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bscnSoHQzv61zOwthCHH2i+vERC4vVzsX7kp0/araIE=; b=C5JBW+JupZXv4SrOUdMEuOrFbMAwhx7ssvGPCJKjiLIyCs0ngjmmfCem7sCXhm4R5xrfNI+IJ6g2LX3X2QI4cGn+wzitneA8QZqFGWlEJAtNJik4aC1BKYB4vDhI9txdIBZY5IVY67dOtk/GVa3YR179Q5rTwG1A/NuY7k5auTA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN0PR12MB6365.namprd12.prod.outlook.com (2603:10b6:208:3c2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.19; Wed, 7 Jun 2023 18:47:10 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6455.037; Wed, 7 Jun 2023 18:47:10 +0000 Message-ID: <44fb2571-8f96-570d-cb35-210fa5f52d9f@amd.com> Date: Wed, 7 Jun 2023 19:47:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le Content-Language: en-US From: Ferruh Yigit To: Stephen Hemminger Cc: David Christensen , dev@dpdk.org, stable@dpdk.org References: <20230322212439.524725-1-drc@linux.vnet.ibm.com> <20230323170145.129901-1-drc@linux.vnet.ibm.com> <165a233b-b41b-3a65-1866-5b7c94993b40@amd.com> <20230515162032.36a4f3ec@hermes.local> <20230515182838.08e49a7c@hermes.local> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0085.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN0PR12MB6365:EE_ X-MS-Office365-Filtering-Correlation-Id: 208357ed-38dc-4e06-2ee6-08db678799dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mhpczi4zXM9ysznq1Qr9a7IQsgNxjX2/5H8Xpeat6D4m6q5J5fCyYlxkEHv0PylTeweHizWU9ZPQdMayRiBih2pvNklK9er5wLpiUd2Z/6yfXppx/FncEh8VKw7JZ9+iY0cDDBwqJ3JDEOPIgD8DEPCRw4zfLwTcpEI8yzmzW9OHu1WnZBqY1YQgFJLSUdtW1H9CBbdWiCmv099IsYcKM43Ai+xX0fPl8rl6pHdB7bGjBvxNkMMBU1d8db/2zv9b7PgvBvy0hpld00EpVdVGWhP+x05vZJ6ZXRVB76eL7ex70L27dIz5wBSqMCCvALH7rTnRdIKwTwxRwPHDE1S1exFwYsoIFYNdZa2JuzW0fIOi4iW9TyyUiXtloCm3vkhl4r2DE4hHtPz4n1lr2CyvaYTMcne5YrCkcvbOGEwEwSZ6wLInJLbQWLdQZWOon0qSH+q4gcTe2OROzcnhylRThIrcDVMJ/+IkaslUIb0Agi8jtFdel0ARttD/YeXCYtxUReeHPAVOc7Lo7/dMXhCWM/JdHsNyMnR3hpce4W4SRU/w7LB3GF2sa9pMKfd7kYEZ9kR+da2MXx7Y5Q6+6TU4jUeREXv7EFBBbsxhD+r+RVi1Bim6x09/XCjytzgk3OxSCMBhYIdRWcHLggei0yFhuQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(451199021)(6486002)(6916009)(36756003)(66556008)(66946007)(66476007)(4326008)(2906002)(44832011)(5660300002)(31696002)(86362001)(38100700002)(41300700001)(316002)(8936002)(8676002)(478600001)(31686004)(186003)(83380400001)(2616005)(6666004)(53546011)(6506007)(26005)(6512007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SitEL0Y2Uk4wMHhXTEljTUxBRy95TmVRSFBDczdSQ1dDd2w0cGR0Y0NldXM2?= =?utf-8?B?bjlqVU1pdWVFUTdWcUZ2Wlh3UVppNVJycExMaDdIMjdCRVZsSTY1b1hua09M?= =?utf-8?B?WlU2OEQrbXFBWUwyOHp3WnFYWXFlOFdhcDBwS0tPQWJWd3pQZndUNml1QWJN?= =?utf-8?B?RmxXQXNTaFhQdFJlaHpxSmdZWTNSR2xyS2ZrdjFwcUhKc05vQmJlVVhWaS8z?= =?utf-8?B?V1JzYmlReGluc05GWW5Xeks4NXBwL1FmTmdGNWtJS21QNk1OOW9pelFEdHR2?= =?utf-8?B?OWVySlFha2d0aXhmNU1ScDVmWk1mdmZEOG9RUHdBYTU3WVVBMXI1Y1pRaTNL?= =?utf-8?B?U09qc200VWF4ak1aZ2VLZ3BlZC9UTzVZNXlyY09wcmhnWTR1VDZibTllNEth?= =?utf-8?B?MTFGMUVsQnNVYU5pZEtlSWY4b1o3ZWpOQklhdHJXcm5YSVBKZURzQVNjamkw?= =?utf-8?B?R2FBUmtxb0tCK29uc2dVSGJJVnV1NnpBZHQ2RkZRSG1maFd4blZ6OVk0RjY3?= =?utf-8?B?WmlkM2liY3VmU2xuT0NQR2hYUkx6NUY5SDlBeXZxVUV1TGxtdWV0c2pVbEw1?= =?utf-8?B?empKUXk1UmFUa3hNYWhEU2VETXJwczdrZkFrZXNTaUx4dEFvN0szWTR2OW9s?= =?utf-8?B?TkJSaERjZ1FKYUp4UVBwN2RZQTl0VXFlQVBIQ3RlcFZHMXo4Z2lkOTlwRG9M?= =?utf-8?B?S3J0WnordjBCR05rQjVPRUt2OEJUemNoN2w3TTEzcVVlbmUzV0E3TUZrY25N?= =?utf-8?B?bTNaVzhaaU8rT2NOM1hpT2pFdUZEWXhSYi9xL25jbkpWWE01ZmpJWTRVaE1P?= =?utf-8?B?WmVJYk56YkVRUzBuc2NKdnM1TVgwYXlCYzA5Y0FXZjNyVTRUNllwR0gzbGVB?= =?utf-8?B?b2RpZXIvRnB3L2ZvR0pDQVJOVnNhVFZ0MC9kblAvNHUzUWcwRjhnUkVsTGRz?= =?utf-8?B?RlFrTVVFOXVSS1BsaDhiTFh4VFNhTjE5SlR3R0d3dnlIaGg2WnRJWTZ0bHZi?= =?utf-8?B?T3c2OE5ncERVV0dRaEZKZlpoYXVteXlPK3R3dnVsN2R2SzV1R0hFVVJ0NDd3?= =?utf-8?B?bnpGMy9DV2lTNk9VdG5IK0lVQWdneFBhUjZWNnBiUTBlVmRuYTVuQnFZdFQ3?= =?utf-8?B?QWRncDlpTkJHTE1nRzBXbENiejdmbXNaNlZaOEVhSi9Ka1MyOTE5eUtKSWRs?= =?utf-8?B?T1piR3A0a2RsdFovdEZOdWZqNmdUcTllWVpITkNtank5TkZreTN3Qis4c0ZD?= =?utf-8?B?OUNHalZ4UDVHU1VKRWRadnRseHhvMHorUGErbUlBWDhMc2pXVERjY0JtN3V1?= =?utf-8?B?dGhwbmZZdnNtaU5Mc25PaDZHTUQwR3hla3N1SXVGelhjQ2paSTBvandTdWE0?= =?utf-8?B?ZU5PbnlLUmFUMUFPRCt5dnhVcTVsdjZmSldMeDlDdWNoVlAxS1ZSZEtjUFRK?= =?utf-8?B?NUEzclplUHBVZFZvNXo2azcyYjJ3bUYzbWdsWTg1VUZzb1RDR1k5YjhScnNx?= =?utf-8?B?aEc3TERadFpNTjhiTDcybUxnNko2MWI4YytaRXZXaU00RWtndHRJcThIanV6?= =?utf-8?B?ektDbytEd3N2MWl3M2pocTBqanFRWHdSOTdGVEVPNm43NzVHV0Q0dlp5bnY5?= =?utf-8?B?MlRDYi8zZkp6ZXo5QkZicWZnWDNKcERpVkt1SzlVQVZ6ZzFYNkhMS2RrcVJ6?= =?utf-8?B?UVBwMVNreFM3cFNqR0JFWnM0K3hGQnJhc0VacllKVUFKdVBDK1BheVRDemsv?= =?utf-8?B?MDlDdTNlQ0pROEZoSlI2M2F2b1RvZk1maUExclIwOE03NEp0UCtOWGZWMXUr?= =?utf-8?B?d00rK2l0MG8rUE4zdkpPYWZnMXZMYm1hL3pQS3ZEN2hOMjhjR0JmMHQ1Umhl?= =?utf-8?B?T0FNMjd6N2FKcWlwcnp0ZXZiRzNBSEZUaXZVRjArMGxhV2N1cTNERUhOTkdj?= =?utf-8?B?VXhybml2SS8rSmJ2dDJXcXNYVkNnVGNuNmxHYTErYk52Tyt4U2Z5QUtaSGsx?= =?utf-8?B?NzV3T0E0amFFeUdXT1lCbFR2SW40cWpSbnJ1cjM2ekxKM3FYdGo1YUUycHFD?= =?utf-8?B?L0JpSW91KzA0eFhOc3JXNkFwNy82c0FORVFaSmZKQm44QWpLRmkvWUNQZmEz?= =?utf-8?Q?o2tpBEWsBPGzYtBHK6Qcnhc67?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 208357ed-38dc-4e06-2ee6-08db678799dd X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 18:47:10.5775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3hAR7ZfymXxqN9Rug3aqPLhBbJ320ZwppGCEhe8gFUvGGKvXaVBFGEwn8g9UFJ/h X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6365 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 5/16/2023 10:55 AM, Ferruh Yigit wrote: > On 5/16/2023 2:28 AM, Stephen Hemminger wrote: >> On Tue, 16 May 2023 00:35:56 +0100 >> Ferruh Yigit wrote: >> >>> Yes only some scripts and possible applications that hotplug tap >>> interface with hardcoded parameters may impacted, don't know how big is >>> this amount but this ends up breaking something that was working before >>> upgrading DPDK for them. >>> >>> And I believe the motivation is weak to break the behavior. >>> >>> Won't it be better to update 'rte_ether_unformat_addr()' to accept more >>> flexible syntax, and use it? Is there any disadvantage of this approach? >> >> It is already more flexible than the standard ether_aton(). > > I mean to accept single chars, as 'tap' currently does, like "a:a:a:a:a:a". > > Agree that impact of tap change is small, but if we can eliminate it > completely without any side affect, why not? > > > As accepting single char will be expanding 'rte_ether_unformat_addr()' > capability, it will be backward compatible, am I missing anything? > Hi David, If API update is not planned, what do you think to just solve the build error without changing functionality with a change something like below: ``` - (strlen(mac_byte) == strspn(mac_byte, - ETH_TAP_CMP_MAC_FMT))) { + (strlen(mac_byte) == strspn(mac_byte, ETH_TAP_CMP_MAC_FMT)) && + index < RTE_ETHER_ADDR_LEN) { ```